From a4a229df3a822239429c93da3201d3fe7f0906ce Mon Sep 17 00:00:00 2001
From: Jose Diaz-Gonzalez <email@josediazgonzalez.com>
Date: Sat, 22 Nov 2025 22:06:28 -0500
Subject: [PATCH] fix: do not start nginx if there are no apps with nginx as a
 proxy

Also start it by default in the case where there are no apps at all, as that likely means this is a first-time installation.
---
 plugins/nginx-vhosts/install | 26 ++++++++++++++++++++++++--
 1 file changed, 24 insertions(+), 2 deletions(-)

diff --git a/plugins/nginx-vhosts/install b/plugins/nginx-vhosts/install
index c8bcb3a7a..748dec90e 100755
--- a/plugins/nginx-vhosts/install
+++ b/plugins/nginx-vhosts/install
@@ -156,9 +156,31 @@ trigger-nginx-vhosts-install() {
   # avoid failing runit init calls on install
   # the runit binaries are not yet available during dockerfile building
   # and therefore both these calls will fail
-  if [[ ! -x /usr/bin/sv ]] && [[ "$(fn-plugin-property-get "nginx" "--global" "proxy-status")" != "stopped" ]]; then
-    fn-nginx-vhosts-nginx-init-cmd start || fn-nginx-vhosts-nginx-init-cmd reload
+  if [[ -x /usr/bin/sv ]]; then
+    return
   fi
+
+  # avoid starting nginx if it was stopped via the nginx:stop command
+  if [[ "$(fn-plugin-property-get "nginx" "--global" "proxy-status")" == "stopped" ]]; then
+    return
+  fi
+
+  # only start nginx if there is an app with the nginx proxy type
+  local start_nginx=false
+  local has_apps=false
+  for app in $(dokku_apps "false" 2>/dev/null); do
+    has_apps=true
+    if [[ "$(plugn trigger proxy-type "$app")" == "nginx" ]]; then
+      start_nginx=true
+      break
+    fi
+  done
+
+  if [[ "$start_nginx" == "false" ]] && [[ "$has_apps" == "true" ]]; then
+    return
+  fi
+
+  fn-nginx-vhosts-nginx-init-cmd start || fn-nginx-vhosts-nginx-init-cmd reload
 }
 
 trigger-nginx-vhosts-install "$@"