Mirrors/dokku
1
0
Fork 0
mirror of https://github.com/dokku/dokku.git synced 2025-12-29 00:25:08 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: respond to all review comments

Browse Source
This commit is contained in:
Jose Diaz-Gonzalez
2017-04-26 18:49:19 -06:00
committed by Michael Hobbs
parent 1e8831d9a0
commit 72eb8a06f0
4 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/common/common.go
View File

@@ -162,7 +162,7 @@ func ContainerIsRunning(containerId string) bool {
if err != nil {
return false
}
return string(b[:]) == "true"
return strings.TrimSpace(string(b[:])) == "true"
}
// DirectoryExists returns if a path exists and is a directory
@@ -234,7 +234,7 @@ func FileExists(filePath string) bool {
return fi.Mode().IsRegular()
}
// GetAppImageName returnS image identifier for a given app, tag tuple. validate if tag is presented
// GetAppImageName returns image identifier for a given app, tag tuple. validate if tag is presented
func GetAppImageName(appName, imageTag, imageRepo string) (imageName string) {
err := VerifyAppName(appName)
if err != nil {
@@ -302,7 +302,7 @@ func LogInfo1(text string) {
fmt.Fprintln(os.Stdout, fmt.Sprintf("-----> %s", text))
}
// LogInfo2Quiet is the info1 header formatter (with quiet option)
// LogInfo1Quiet is the info1 header formatter (with quiet option)
func LogInfo1Quiet(text string) {
if os.Getenv("DOKKU_QUIET_OUTPUT") != "" {
LogInfo1(text)