From 45551c3c5baa79c28f7480515f921c905eb5ff5b Mon Sep 17 00:00:00 2001 From: Michael Hobbs Date: Tue, 29 Mar 2016 11:31:14 -0700 Subject: [PATCH] clarify dockerfile port exposure. remove reference to DOKKU_DOCKERFILE_PORT. closes #2028 --- docs/deployment/dockerfiles.md | 9 ++------- plugins/00_dokku-standard/subcommands/deploy | 1 - 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/docs/deployment/dockerfiles.md b/docs/deployment/dockerfiles.md index ab990c1bc..ea4ef6eb5 100644 --- a/docs/deployment/dockerfiles.md +++ b/docs/deployment/dockerfiles.md @@ -11,14 +11,9 @@ To use a dockerfiles for deployment, commit a valid `Dockerfile` to the root of ## Exposed ports -By default, Dokku will extract the first `EXPOSE` tcp port and use said port with nginx to proxy your app to that port. For applications that have multiple ports exposed, you may override this port via the following command: +Dokku will extract all tcp ports exposed using the `EXPOSE` directive and use said ports with nginx to proxy your app to those ports. (nginx does not support proxying udp) If you would like to change the exposed port, you should do so within your `Dockerfile` and app. -```shell -# replace APP with the name of your application -dokku config:set APP DOKKU_DOCKERFILE_PORT=8000 -``` - -Dokku will not expose other ports on your application without a [custom docker-option](/dokku/docker-options/). +NOTE: UDP ports can be exposed by disabling the nginx proxy with `dokku proxy:disable myapp` If you do not have a port explicitly exposed, Dokku will automatically expose port `5000` for your application. diff --git a/plugins/00_dokku-standard/subcommands/deploy b/plugins/00_dokku-standard/subcommands/deploy index 77a2929ea..15b135b01 100755 --- a/plugins/00_dokku-standard/subcommands/deploy +++ b/plugins/00_dokku-standard/subcommands/deploy @@ -43,7 +43,6 @@ dokku_deploy_cmd() { if [[ -z "$DOKKU_HEROKUISH" ]]; then local DOKKU_DOCKERFILE_PORTS=($(config_get "$APP" DOKKU_DOCKERFILE_PORTS || true)) - local DOKKU_DOCKERFILE_PORT=$(config_get "$APP" DOKKU_DOCKERFILE_PORT || true) local DOKKU_DOCKERFILE_START_CMD=$(config_get "$APP" DOKKU_DOCKERFILE_START_CMD || true) local DOKKU_PROCFILE_START_CMD=$(get_cmd_from_procfile "$APP" "$PROC_TYPE") local START_CMD=${DOKKU_DOCKERFILE_START_CMD:-$DOKKU_PROCFILE_START_CMD}