From 2a02aa0b9b9d62a7943bd1fdd0bdba0edc6c4307 Mon Sep 17 00:00:00 2001 From: Jose Diaz-Gonzalez Date: Sun, 27 Feb 2022 18:20:44 -0500 Subject: [PATCH] fix: ensure vector component sources have valid names The dot (.) character is invalid. Closes #5044 --- plugins/logs/functions.go | 1 + tests/unit/logs.bats | 10 ++++++++++ 2 files changed, 11 insertions(+) diff --git a/plugins/logs/functions.go b/plugins/logs/functions.go index 50aa6a2ca..b4acc8007 100644 --- a/plugins/logs/functions.go +++ b/plugins/logs/functions.go @@ -167,6 +167,7 @@ func writeVectorConfig() error { continue } + appName = strings.ReplaceAll(appName, ".", "-") sink, err := sinkValueToConfig(appName, value) if err != nil { return err diff --git a/tests/unit/logs.bats b/tests/unit/logs.bats index 58af987c8..7225831c9 100644 --- a/tests/unit/logs.bats +++ b/tests/unit/logs.bats @@ -522,6 +522,11 @@ teardown() { assert_failure assert_output_contains "Vector container does not exist" + run /bin/bash -c "dokku apps:create example.com" + echo "output: $output" + echo "status: $status" + assert_success + run /bin/bash -c "dokku logs:vector-start 2>&1" echo "output: $output" echo "status: $status" @@ -534,6 +539,11 @@ teardown() { assert_success assert_output_contains "Vector container logs" + run /bin/bash -c "dokku --force apps:destroy example.com" + echo "output: $output" + echo "status: $status" + assert_success + run /bin/bash -c "dokku logs:vector-logs --num 10 2>&1" echo "output: $output" echo "status: $status"