mirror of
https://github.com/dokku/dokku.git
synced 2026-08-29 10:08:53 +02:00
fix: use image pull secrets instead of registries.yaml to reference private repositories
While this will now more or less require a local docker login - which can be overridden by setting the image-pull-secrets property - this ensures every deploy has a valid context. One annoying thing is that the secret is per-app vs global, meaning that if the secret must be rotated, all apps need to be redeployed. A future change can fix that by deploying a global secret, or if folks really desire, this can be done by setting the image-pull-secrets property on the app/globally.
This commit is contained in:
@@ -45,6 +45,7 @@ type GlobalValues struct {
|
||||
type GlobalImage struct {
|
||||
ImagePullSecrets string `yaml:"image_pull_secrets"`
|
||||
Name string `yaml:"name"`
|
||||
PullSecretBase64 string `yaml:"pull_secret_base64"`
|
||||
Type string `yaml:"type"`
|
||||
WorkingDir string `yaml:"working_dir"`
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user