From 7d7d29ab5f7f89b3d1b189028ff8d2843df1e39e Mon Sep 17 00:00:00 2001
From: riggraz <riccardo.graziosi97@gmail.com>
Date: Mon, 27 Jan 2025 12:57:44 +0100
Subject: [PATCH] Add allow_attachment_upload flag to tenant_settings

---
 .../SiteSettings/General/GeneralSiteSettingsP.tsx | 15 ++++++++++++++-
 app/javascript/containers/GeneralSiteSettings.tsx |  2 ++
 app/javascript/interfaces/ITenantSetting.ts       |  1 +
 app/policies/tenant_setting_policy.rb             |  1 +
 app/views/site_settings/general.html.erb          |  1 +
 config/locales/backend/backend.en.yml             |  1 +
 config/locales/en.yml                             |  1 +
 ..._allow_attachment_upload_to_tenant_settings.rb |  5 +++++
 db/schema.rb                                      |  3 ++-
 9 files changed, 28 insertions(+), 2 deletions(-)
 create mode 100644 db/migrate/20250127115010_add_allow_attachment_upload_to_tenant_settings.rb

diff --git a/app/javascript/components/SiteSettings/General/GeneralSiteSettingsP.tsx b/app/javascript/components/SiteSettings/General/GeneralSiteSettingsP.tsx
index 169d92b9..4dc33704 100644
--- a/app/javascript/components/SiteSettings/General/GeneralSiteSettingsP.tsx
+++ b/app/javascript/components/SiteSettings/General/GeneralSiteSettingsP.tsx
@@ -39,6 +39,7 @@ export interface ISiteSettingsGeneralForm {
   isPrivate: boolean;
   allowAnonymousFeedback: boolean;
   feedbackApprovalPolicy: string;
+  allowAttachmentUpload: boolean;
   logoLinksTo: string;
   logoCustomUrl?: string;
   showRoadmapInHeader: boolean;
@@ -75,6 +76,7 @@ interface Props {
     isPrivate: boolean,
     allowAnonymousFeedback: boolean,
     feedbackApprovalPolicy: string,
+    allowAttachmentUpload: boolean,
     logoLinksTo: string,
     logoCustomUrl: string,
     showRoadmapInHeader: boolean,
@@ -105,7 +107,6 @@ const GeneralSiteSettingsP = ({
     formState: { isDirty, isSubmitSuccessful, errors },
     watch,
     control,
-    getValues,
   } = useForm<ISiteSettingsGeneralForm>({
     defaultValues: {
       siteName: originForm.siteName,
@@ -122,6 +123,7 @@ const GeneralSiteSettingsP = ({
       isPrivate: originForm.isPrivate,
       allowAnonymousFeedback: originForm.allowAnonymousFeedback,
       feedbackApprovalPolicy: originForm.feedbackApprovalPolicy,
+      allowAttachmentUpload: originForm.allowAttachmentUpload,
       logoLinksTo: originForm.logoLinksTo,
       logoCustomUrl: originForm.logoCustomUrl,
       showRoadmapInHeader: originForm.showRoadmapInHeader,
@@ -149,6 +151,7 @@ const GeneralSiteSettingsP = ({
       data.isPrivate,
       data.allowAnonymousFeedback,
       data.feedbackApprovalPolicy,
+      data.allowAttachmentUpload,
       data.logoLinksTo,
       data.logoCustomUrl,
       data.showRoadmapInHeader,
@@ -524,6 +527,16 @@ const GeneralSiteSettingsP = ({
                 { I18n.t('site_settings.general.feedback_approval_policy_help') }
               </SmallMutedText>
             </div>
+
+            <div className="formGroup">
+              <div className="checkboxSwitch">
+                <input {...register('allowAttachmentUpload')} type="checkbox" id="allow_attachment_upload" />
+                <label htmlFor="allow_attachment_upload">{ getLabel('tenant_setting', 'allow_attachment_upload') }</label>
+                <SmallMutedText>
+                  { I18n.t('site_settings.general.allow_attachment_upload_help') }
+                </SmallMutedText>
+              </div>
+            </div>
           </div>
 
           <div id="header" className="settingsGroup">
diff --git a/app/javascript/containers/GeneralSiteSettings.tsx b/app/javascript/containers/GeneralSiteSettings.tsx
index 5e9d783a..e77b6a66 100644
--- a/app/javascript/containers/GeneralSiteSettings.tsx
+++ b/app/javascript/containers/GeneralSiteSettings.tsx
@@ -31,6 +31,7 @@ const mapDispatchToProps = (dispatch: any) => ({
     isPrivate: boolean,
     allowAnonymousFeedback: boolean,
     feedbackApprovalPolicy: TenantSettingFeedbackApprovalPolicy,
+    allowAttachmentUpload: boolean,
     logoLinksTo: TenantSettingLogoLinksTo,
     logoCustomUrl: string,
     showRoadmapInHeader: boolean,
@@ -55,6 +56,7 @@ const mapDispatchToProps = (dispatch: any) => ({
         is_private: isPrivate,
         allow_anonymous_feedback: allowAnonymousFeedback,
         feedback_approval_policy: feedbackApprovalPolicy,
+        allow_attachment_upload: allowAttachmentUpload,
         logo_links_to: logoLinksTo,
         logo_custom_url: logoCustomUrl,
         show_roadmap_in_header: showRoadmapInHeader,
diff --git a/app/javascript/interfaces/ITenantSetting.ts b/app/javascript/interfaces/ITenantSetting.ts
index 4f01858b..c11b359e 100644
--- a/app/javascript/interfaces/ITenantSetting.ts
+++ b/app/javascript/interfaces/ITenantSetting.ts
@@ -58,6 +58,7 @@ interface ITenantSetting {
   allowed_email_domains?: string;
   allow_anonymous_feedback?: boolean;
   feedback_approval_policy?: TenantSettingFeedbackApprovalPolicy;
+  allow_attachment_upload?: boolean;
   show_vote_count?: boolean;
   show_vote_button_in_board?: boolean;
   show_roadmap_in_header?: boolean;
diff --git a/app/policies/tenant_setting_policy.rb b/app/policies/tenant_setting_policy.rb
index de0b1b50..14e1ee14 100644
--- a/app/policies/tenant_setting_policy.rb
+++ b/app/policies/tenant_setting_policy.rb
@@ -10,6 +10,7 @@ class TenantSettingPolicy < ApplicationPolicy
         :allowed_email_domains,
         :allow_anonymous_feedback,
         :feedback_approval_policy,
+        :allow_attachment_upload,
         :show_vote_count,
         :show_vote_button_in_board,
         :hide_unused_statuses_in_filter_by_status,
diff --git a/app/views/site_settings/general.html.erb b/app/views/site_settings/general.html.erb
index 30cc0031..0236b9be 100644
--- a/app/views/site_settings/general.html.erb
+++ b/app/views/site_settings/general.html.erb
@@ -18,6 +18,7 @@
             isPrivate: @tenant_setting.is_private,
             allowAnonymousFeedback: @tenant_setting.allow_anonymous_feedback,
             feedbackApprovalPolicy: @tenant_setting.feedback_approval_policy,
+            allowAttachmentUpload: @tenant_setting.allow_attachment_upload,
             logoLinksTo: @tenant_setting.logo_links_to,
             logoCustomUrl: @tenant_setting.logo_custom_url,
             showRoadmapInHeader: @tenant_setting.show_roadmap_in_header,
diff --git a/config/locales/backend/backend.en.yml b/config/locales/backend/backend.en.yml
index 684604f8..5009cdbd 100644
--- a/config/locales/backend/backend.en.yml
+++ b/config/locales/backend/backend.en.yml
@@ -140,6 +140,7 @@ en:
         allowed_email_domains: 'Allowed email domains'
         allow_anonymous_feedback: 'Allow anonymous feedback'
         feedback_approval_policy: 'Feedback approval policy'
+        allow_attachment_upload: 'Allow attachment upload'
         show_vote_count: 'Show vote count to users'
         show_vote_button_in_board: 'Show vote buttons in board page'
         hide_unused_statuses_in_filter_by_status: 'Hide unused statuses in filter by status'
diff --git a/config/locales/en.yml b/config/locales/en.yml
index d2ca2963..17e9f04f 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -215,6 +215,7 @@ en:
       feedback_approval_policy_never_require_approval: 'Never require approval'
       feedback_approval_policy_always_require_approval: 'Always require approval'
       feedback_approval_policy_help: 'If you require approval, submitted feedback will remain hidden from the public until a moderator or administrator approves it. Feedback submitted by moderators and administrators is always approved automatically.'
+      allow_attachment_upload_help: 'If you enable this setting, users will be able to upload images to their feedback.'
       subtitle_header: 'Header'
       logo_links_to_root_page: 'Root page'
       logo_links_to_custom_url: 'Custom URL'
diff --git a/db/migrate/20250127115010_add_allow_attachment_upload_to_tenant_settings.rb b/db/migrate/20250127115010_add_allow_attachment_upload_to_tenant_settings.rb
new file mode 100644
index 00000000..f7865d9e
--- /dev/null
+++ b/db/migrate/20250127115010_add_allow_attachment_upload_to_tenant_settings.rb
@@ -0,0 +1,5 @@
+class AddAllowAttachmentUploadToTenantSettings < ActiveRecord::Migration[6.1]
+  def change
+    add_column :tenant_settings, :allow_attachment_upload, :boolean, default: true
+  end
+end
diff --git a/db/schema.rb b/db/schema.rb
index f8385338..a9b85460 100644
--- a/db/schema.rb
+++ b/db/schema.rb
@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2025_01_22_131133) do
+ActiveRecord::Schema.define(version: 2025_01_27_115010) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
@@ -227,6 +227,7 @@ ActiveRecord::Schema.define(version: 2025_01_22_131133) do
     t.integer "logo_links_to", default: 0, null: false
     t.string "logo_custom_url"
     t.boolean "hide_unused_statuses_in_filter_by_status", default: false, null: false
+    t.boolean "allow_attachment_upload", default: true
     t.index ["tenant_id"], name: "index_tenant_settings_on_tenant_id"
   end