From 716d6a0ae18d2c0dd6aea2e3b1d5d4a6c0683d2c Mon Sep 17 00:00:00 2001
From: Levi Zim <rsworktech@outlook.com>
Date: Sun, 6 Oct 2024 00:04:43 +0800
Subject: [PATCH] Use safe kill from nix crate

Previously the code uses unsafe kill from libc and on the first look it
appears that it forgets to check the result.

I think you mean to ignore the errors that might occur when killing the child,
right? This commit makes the intent more clear with less unsafe code.
---
 src/pty.rs | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/pty.rs b/src/pty.rs
index e54b258..40ef47b 100644
--- a/src/pty.rs
+++ b/src/pty.rs
@@ -3,7 +3,7 @@ use crate::tty::{Tty, TtySize};
 use anyhow::{bail, Result};
 use nix::errno::Errno;
 use nix::sys::select::{select, FdSet};
-use nix::sys::signal;
+use nix::sys::signal::{self, kill, Signal};
 use nix::sys::wait::{self, WaitPidFlag, WaitStatus};
 use nix::unistd::{self, ForkResult};
 use nix::{libc, pty};
@@ -264,7 +264,8 @@ fn copy<T: Tty + ?Sized, H: Handler>(
         }
 
         if kill_the_child {
-            unsafe { libc::kill(child.as_raw(), SIGTERM) };
+            // Any errors occurred when killing the child are ignored.
+            let _ = kill(child, Signal::SIGTERM);
             return Ok(None);
         }
     }