Include idle_time_limit in written header

This commit is contained in:
Marcin Kulik
2023-10-28 10:44:12 +02:00
parent 46f7576017
commit 00b5c8feca
5 changed files with 49 additions and 24 deletions

View File

@@ -3,7 +3,7 @@ pub mod raw;
use std::io; use std::io;
pub trait Writer { pub trait Writer {
fn header(&mut self, size: (u16, u16)) -> io::Result<()>; fn header(&mut self, size: (u16, u16), idle_time_limit: Option<f32>) -> io::Result<()>;
fn output(&mut self, time: f64, data: &[u8]) -> io::Result<()>; fn output(&mut self, time: f64, data: &[u8]) -> io::Result<()>;
fn input(&mut self, time: f64, data: &[u8]) -> io::Result<()>; fn input(&mut self, time: f64, data: &[u8]) -> io::Result<()>;
} }

View File

@@ -13,14 +13,14 @@ pub struct Writer<W: Write> {
pub struct Header { pub struct Header {
pub terminal_size: (usize, usize), pub terminal_size: (usize, usize),
pub idle_time_limit: Option<f64>, pub idle_time_limit: Option<f32>,
} }
#[derive(Deserialize)] #[derive(Deserialize)]
pub struct V2Header { pub struct V2Header {
pub width: usize, pub width: usize,
pub height: usize, pub height: usize,
pub idle_time_limit: Option<f64>, pub idle_time_limit: Option<f32>,
} }
pub struct Event { pub struct Event {
@@ -50,13 +50,13 @@ where
} }
pub fn write_header(&mut self, header: &Header) -> io::Result<()> { pub fn write_header(&mut self, header: &Header) -> io::Result<()> {
write_header(&mut self.writer, header) writeln!(self.writer, "{}", serde_json::to_string(header)?)
} }
pub fn write_event(&mut self, mut event: Event) -> io::Result<()> { pub fn write_event(&mut self, mut event: Event) -> io::Result<()> {
event.time += self.time_offset; event.time += self.time_offset;
write_event(&mut self.writer, &event) writeln!(self.writer, "{}", serde_json::to_string(&event)?)
} }
} }
@@ -64,10 +64,10 @@ impl<W> super::Writer for Writer<W>
where where
W: Write, W: Write,
{ {
fn header(&mut self, size: (u16, u16)) -> io::Result<()> { fn header(&mut self, size: (u16, u16), idle_time_limit: Option<f32>) -> io::Result<()> {
let header = Header { let header = Header {
terminal_size: (size.0 as usize, size.1 as usize), terminal_size: (size.0 as usize, size.1 as usize),
idle_time_limit: None, idle_time_limit,
}; };
self.write_header(&header) self.write_header(&header)
@@ -125,14 +125,6 @@ fn parse_event(line: String, i: usize) -> anyhow::Result<Event> {
Ok(Event { time, code, data }) Ok(Event { time, code, data })
} }
pub fn write_header<W: Write>(sink: &mut W, header: &Header) -> io::Result<()> {
writeln!(sink, "{}", serde_json::to_string(header)?)
}
pub fn write_event<W: Write>(sink: &mut W, event: &Event) -> io::Result<()> {
writeln!(sink, "{}", serde_json::to_string(event)?)
}
pub fn get_duration<S: AsRef<Path>>(path: S) -> anyhow::Result<f64> { pub fn get_duration<S: AsRef<Path>>(path: S) -> anyhow::Result<f64> {
let file = fs::File::open(path)?; let file = fs::File::open(path)?;
let reader = io::BufReader::new(file); let reader = io::BufReader::new(file);
@@ -180,11 +172,17 @@ impl serde::Serialize for Header {
S: serde::Serializer, S: serde::Serializer,
{ {
use serde::ser::SerializeMap; use serde::ser::SerializeMap;
let mut map = serializer.serialize_map(Some(3))?;
let len = if self.idle_time_limit.is_none() { 3 } else { 4 };
let mut map = serializer.serialize_map(Some(len))?;
map.serialize_entry("version", &2)?; map.serialize_entry("version", &2)?;
map.serialize_entry("width", &self.terminal_size.0)?; map.serialize_entry("width", &self.terminal_size.0)?;
map.serialize_entry("height", &self.terminal_size.1)?; map.serialize_entry("height", &self.terminal_size.1)?;
// TODO idle_time_limit
if let Some(limit) = self.idle_time_limit {
map.serialize_entry("idle_time_limit", &limit)?;
}
map.end() map.end()
} }
} }
@@ -280,4 +278,24 @@ mod tests {
assert_eq!(asciicast, "{\"version\":2,\"width\":80,\"height\":24}\n[1.0,\"o\",\"hello\\r\\n\"]\n[2.0,\"o\",\"world\"]\n"); assert_eq!(asciicast, "{\"version\":2,\"width\":80,\"height\":24}\n[1.0,\"o\",\"hello\\r\\n\"]\n[2.0,\"o\",\"world\"]\n");
} }
#[test]
fn write_header() {
let mut data = Vec::new();
let mut fw = Writer::new(io::Cursor::new(&mut data), 0.0);
let header = Header {
terminal_size: (80, 24),
idle_time_limit: Some(1.5),
};
fw.write_header(&header).unwrap();
let asciicast = String::from_utf8(data).unwrap();
assert_eq!(
asciicast,
"{\"version\":2,\"width\":80,\"height\":24,\"idle_time_limit\":1.5}\n"
);
}
} }

View File

@@ -11,7 +11,7 @@ impl<W> Writer<W> {
} }
impl<W: Write> super::Writer for Writer<W> { impl<W: Write> super::Writer for Writer<W> {
fn header(&mut self, size: (u16, u16)) -> io::Result<()> { fn header(&mut self, size: (u16, u16), _idle_time_limit: Option<f32>) -> io::Result<()> {
write!(self.writer, "\x1b[8;{};{}t", size.1, size.0) write!(self.writer, "\x1b[8;{};{}t", size.1, size.0)
} }

View File

@@ -53,7 +53,7 @@ enum Commands {
/// Limit idle time to given number of seconds /// Limit idle time to given number of seconds
#[arg(short, long, value_name = "SECS")] #[arg(short, long, value_name = "SECS")]
idle_time_limit: Option<f64>, idle_time_limit: Option<f32>,
/// Override terminal width (columns) for recorded command /// Override terminal width (columns) for recorded command
#[arg(long)] #[arg(long)]
@@ -149,7 +149,7 @@ fn main() -> Result<()> {
Box::new(writer) Box::new(writer)
}; };
let mut recorder = recorder::Recorder::new(writer, append, stdin); let mut recorder = recorder::Recorder::new(writer, append, stdin, idle_time_limit);
let command = if command == "$SHELL" { let command = if command == "$SHELL" {
env::var("SHELL").ok().unwrap_or("/bin/sh".to_owned()) env::var("SHELL").ok().unwrap_or("/bin/sh".to_owned())

View File

@@ -5,18 +5,25 @@ use std::time;
pub struct Recorder { pub struct Recorder {
writer: Box<dyn format::Writer>, writer: Box<dyn format::Writer>,
start_time: time::Instant,
append: bool, append: bool,
record_input: bool, record_input: bool,
start_time: time::Instant, idle_time_limit: Option<f32>,
} }
impl Recorder { impl Recorder {
pub fn new(writer: Box<dyn format::Writer>, append: bool, record_input: bool) -> Self { pub fn new(
writer: Box<dyn format::Writer>,
append: bool,
record_input: bool,
idle_time_limit: Option<f32>,
) -> Self {
Recorder { Recorder {
writer, writer,
start_time: time::Instant::now(),
append, append,
record_input, record_input,
start_time: time::Instant::now(), idle_time_limit,
} }
} }
@@ -30,7 +37,7 @@ impl pty::Recorder for Recorder {
self.start_time = time::Instant::now(); self.start_time = time::Instant::now();
if !self.append { if !self.append {
self.writer.header(size) self.writer.header(size, self.idle_time_limit)
} else { } else {
Ok(()) Ok(())
} }