mirror of
https://github.com/microsoft/PowerToys.git
synced 2025-12-15 19:27:56 +01:00
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request The old implementation checked `HKLM\Software\Classes\powertoys\InstallScope` first. If this key existed (even as a remnant from incomplete uninstall), it would immediately return `PerMachine` without validating the actual installation. ### Fix - Uses Windows standard Uninstall registry (most reliable source of truth) - Identifies PowerToys Bundle by exact `BundleUpgradeCode` GUID match - MSI component entries (always in HKLM) are automatically ignored since they don't have `BundleUpgradeCode` - Checks HKCU first, then HKLM, properly handling the fact that Bundle location reflects true install scope <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #43696 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed
540 lines
20 KiB
C++
540 lines
20 KiB
C++
#pragma once
|
|
|
|
#include <Windows.h>
|
|
|
|
#include <functional>
|
|
#include <string>
|
|
#include <variant>
|
|
#include <vector>
|
|
#include <optional>
|
|
#include <cassert>
|
|
#include <sstream>
|
|
|
|
#include "../logger/logger.h"
|
|
#include "../utils/winapi_error.h"
|
|
#include "../version/version.h"
|
|
|
|
namespace registry
|
|
{
|
|
namespace detail
|
|
{
|
|
struct on_exit
|
|
{
|
|
std::function<void()> f;
|
|
|
|
on_exit(std::function<void()> f) :
|
|
f{ std::move(f) } {}
|
|
~on_exit() { f(); }
|
|
};
|
|
|
|
template<class... Ts>
|
|
struct overloaded : Ts...
|
|
{
|
|
using Ts::operator()...;
|
|
};
|
|
|
|
template<class... Ts>
|
|
overloaded(Ts...) -> overloaded<Ts...>;
|
|
|
|
inline const wchar_t* getScopeName(HKEY scope)
|
|
{
|
|
if (scope == HKEY_LOCAL_MACHINE)
|
|
{
|
|
return L"HKLM";
|
|
}
|
|
else if (scope == HKEY_CURRENT_USER)
|
|
{
|
|
return L"HKCU";
|
|
}
|
|
else if (scope == HKEY_CLASSES_ROOT)
|
|
{
|
|
return L"HKCR";
|
|
}
|
|
else
|
|
{
|
|
return L"HK??";
|
|
}
|
|
}
|
|
}
|
|
|
|
namespace install_scope
|
|
{
|
|
const wchar_t INSTALL_SCOPE_REG_KEY[] = L"Software\\Classes\\powertoys\\";
|
|
const wchar_t UNINSTALL_REG_KEY[] = L"Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall";
|
|
|
|
// Bundle UpgradeCode from PowerToys.wxs (with braces as stored in registry)
|
|
const wchar_t BUNDLE_UPGRADE_CODE[] = L"{6341382D-C0A9-4238-9188-BE9607E3FAB2}";
|
|
|
|
enum class InstallScope
|
|
{
|
|
PerMachine = 0,
|
|
PerUser,
|
|
};
|
|
|
|
// Helper function to find PowerToys bundle in Windows Uninstall registry by BundleUpgradeCode
|
|
inline bool find_powertoys_bundle_in_uninstall_registry(HKEY rootKey)
|
|
{
|
|
HKEY uninstallKey{};
|
|
if (RegOpenKeyExW(rootKey, UNINSTALL_REG_KEY, 0, KEY_READ, &uninstallKey) != ERROR_SUCCESS)
|
|
{
|
|
return false;
|
|
}
|
|
detail::on_exit closeUninstallKey{ [uninstallKey] { RegCloseKey(uninstallKey); } };
|
|
|
|
DWORD index = 0;
|
|
wchar_t subKeyName[256];
|
|
|
|
// Enumerate all subkeys under Uninstall
|
|
while (RegEnumKeyW(uninstallKey, index++, subKeyName, 256) == ERROR_SUCCESS)
|
|
{
|
|
HKEY productKey{};
|
|
if (RegOpenKeyExW(uninstallKey, subKeyName, 0, KEY_READ, &productKey) != ERROR_SUCCESS)
|
|
{
|
|
continue;
|
|
}
|
|
detail::on_exit closeProductKey{ [productKey] { RegCloseKey(productKey); } };
|
|
|
|
// Check BundleUpgradeCode value (specific to WiX Bundle installations)
|
|
wchar_t bundleUpgradeCode[256]{};
|
|
DWORD bundleUpgradeCodeSize = sizeof(bundleUpgradeCode);
|
|
|
|
if (RegQueryValueExW(productKey, L"BundleUpgradeCode", nullptr, nullptr,
|
|
reinterpret_cast<LPBYTE>(bundleUpgradeCode), &bundleUpgradeCodeSize) == ERROR_SUCCESS)
|
|
{
|
|
if (_wcsicmp(bundleUpgradeCode, BUNDLE_UPGRADE_CODE) == 0)
|
|
{
|
|
return true;
|
|
}
|
|
}
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
inline const InstallScope get_current_install_scope()
|
|
{
|
|
// 1. Check HKCU Uninstall registry first (user-level bundle)
|
|
// Note: MSI components are always in HKLM regardless of install scope,
|
|
// but the Bundle entry will be in HKCU for per-user installations
|
|
if (find_powertoys_bundle_in_uninstall_registry(HKEY_CURRENT_USER))
|
|
{
|
|
Logger::info(L"Found user-level PowerToys bundle via BundleUpgradeCode in HKCU");
|
|
return InstallScope::PerUser;
|
|
}
|
|
|
|
// 2. Check HKLM Uninstall registry (machine-level bundle)
|
|
if (find_powertoys_bundle_in_uninstall_registry(HKEY_LOCAL_MACHINE))
|
|
{
|
|
Logger::info(L"Found machine-level PowerToys bundle via BundleUpgradeCode in HKLM");
|
|
return InstallScope::PerMachine;
|
|
}
|
|
|
|
// 3. Fallback to legacy custom registry key detection
|
|
Logger::info(L"PowerToys bundle not found in Uninstall registry, falling back to legacy detection");
|
|
|
|
// Open HKLM key
|
|
HKEY perMachineKey{};
|
|
if (RegOpenKeyExW(HKEY_LOCAL_MACHINE,
|
|
INSTALL_SCOPE_REG_KEY,
|
|
0,
|
|
KEY_READ,
|
|
&perMachineKey) != ERROR_SUCCESS)
|
|
{
|
|
// Open HKCU key
|
|
HKEY perUserKey{};
|
|
if (RegOpenKeyExW(HKEY_CURRENT_USER,
|
|
INSTALL_SCOPE_REG_KEY,
|
|
0,
|
|
KEY_READ,
|
|
&perUserKey) != ERROR_SUCCESS)
|
|
{
|
|
// both keys are missing
|
|
Logger::warn(L"No PowerToys installation detected, defaulting to PerMachine");
|
|
return InstallScope::PerMachine;
|
|
}
|
|
else
|
|
{
|
|
DWORD dataSize{};
|
|
if (RegGetValueW(
|
|
perUserKey,
|
|
nullptr,
|
|
L"InstallScope",
|
|
RRF_RT_REG_SZ,
|
|
nullptr,
|
|
nullptr,
|
|
&dataSize) != ERROR_SUCCESS)
|
|
{
|
|
// HKCU key is missing
|
|
RegCloseKey(perUserKey);
|
|
return InstallScope::PerMachine;
|
|
}
|
|
|
|
std::wstring data;
|
|
data.resize(dataSize / sizeof(wchar_t));
|
|
|
|
if (RegGetValueW(
|
|
perUserKey,
|
|
nullptr,
|
|
L"InstallScope",
|
|
RRF_RT_REG_SZ,
|
|
nullptr,
|
|
&data[0],
|
|
&dataSize) != ERROR_SUCCESS)
|
|
{
|
|
// HKCU key is missing
|
|
RegCloseKey(perUserKey);
|
|
return InstallScope::PerMachine;
|
|
}
|
|
RegCloseKey(perUserKey);
|
|
|
|
if (data.contains(L"perUser"))
|
|
{
|
|
return InstallScope::PerUser;
|
|
}
|
|
}
|
|
}
|
|
|
|
return InstallScope::PerMachine;
|
|
}
|
|
}
|
|
|
|
template<class>
|
|
inline constexpr bool always_false_v = false;
|
|
|
|
struct ValueChange
|
|
{
|
|
using value_t = std::variant<DWORD, std::wstring>;
|
|
static constexpr size_t VALUE_BUFFER_SIZE = 512;
|
|
|
|
HKEY scope{};
|
|
std::wstring path;
|
|
std::optional<std::wstring> name; // none == default
|
|
value_t value;
|
|
bool required = true;
|
|
|
|
ValueChange(const HKEY scope, std::wstring path, std::optional<std::wstring> name, value_t value, bool required = true) :
|
|
scope{ scope }, path{ std::move(path) }, name{ std::move(name) }, value{ std::move(value) }, required{ required }
|
|
{
|
|
}
|
|
|
|
std::wstring toString() const
|
|
{
|
|
using namespace detail;
|
|
|
|
std::wstring value_str;
|
|
std::visit(overloaded{ [&](DWORD value) {
|
|
std::wostringstream oss;
|
|
oss << value;
|
|
value_str = oss.str();
|
|
},
|
|
[&](const std::wstring& value) { value_str = value; } },
|
|
value);
|
|
|
|
return fmt::format(L"{}\\{}\\{}:{}", detail::getScopeName(scope), path, name ? *name : L"Default", value_str);
|
|
}
|
|
|
|
bool isApplied() const
|
|
{
|
|
HKEY key{};
|
|
if (auto res = RegOpenKeyExW(scope, path.c_str(), 0, KEY_READ, &key); res != ERROR_SUCCESS)
|
|
{
|
|
Logger::info(L"isApplied of {}: RegOpenKeyExW failed: {}", toString(), get_last_error_or_default(res));
|
|
return false;
|
|
}
|
|
detail::on_exit closeKey{ [key] { RegCloseKey(key); } };
|
|
|
|
const DWORD expectedType = valueTypeToWinapiType(value);
|
|
|
|
DWORD retrievedType{};
|
|
wchar_t buffer[VALUE_BUFFER_SIZE];
|
|
DWORD valueSize = sizeof(buffer);
|
|
if (auto res = RegQueryValueExW(key,
|
|
name.has_value() ? name->c_str() : nullptr,
|
|
0,
|
|
&retrievedType,
|
|
reinterpret_cast<LPBYTE>(&buffer),
|
|
&valueSize);
|
|
res != ERROR_SUCCESS)
|
|
{
|
|
Logger::info(L"isApplied of {}: RegQueryValueExW failed: {}", toString(), get_last_error_or_default(res));
|
|
return false;
|
|
}
|
|
|
|
if (expectedType != retrievedType)
|
|
{
|
|
return false;
|
|
}
|
|
|
|
if (const auto retrievedValue = bufferToValue(buffer, valueSize, retrievedType))
|
|
{
|
|
return value == retrievedValue;
|
|
}
|
|
else
|
|
{
|
|
return false;
|
|
}
|
|
}
|
|
|
|
bool apply() const
|
|
{
|
|
HKEY key{};
|
|
|
|
if (auto res = RegCreateKeyExW(scope, path.c_str(), 0, nullptr, REG_OPTION_NON_VOLATILE, KEY_WRITE, nullptr, &key, nullptr); res !=
|
|
ERROR_SUCCESS)
|
|
{
|
|
Logger::error(L"apply of {}: RegCreateKeyExW failed: {}", toString(), get_last_error_or_default(res));
|
|
return false;
|
|
}
|
|
detail::on_exit closeKey{ [key] { RegCloseKey(key); } };
|
|
|
|
wchar_t buffer[VALUE_BUFFER_SIZE];
|
|
DWORD valueSize;
|
|
DWORD valueType;
|
|
|
|
valueToBuffer(value, buffer, valueSize, valueType);
|
|
if (auto res = RegSetValueExW(key,
|
|
name.has_value() ? name->c_str() : nullptr,
|
|
0,
|
|
valueType,
|
|
reinterpret_cast<BYTE*>(buffer),
|
|
valueSize);
|
|
res != ERROR_SUCCESS)
|
|
{
|
|
Logger::error(L"apply of {}: RegSetValueExW failed: {}", toString(), get_last_error_or_default(res));
|
|
return false;
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
bool unApply() const
|
|
{
|
|
HKEY key{};
|
|
if (auto res = RegOpenKeyExW(scope, path.c_str(), 0, KEY_ALL_ACCESS, &key); res != ERROR_SUCCESS)
|
|
{
|
|
Logger::error(L"unApply of {}: RegOpenKeyExW failed: {}", toString(), get_last_error_or_default(res));
|
|
return false;
|
|
}
|
|
detail::on_exit closeKey{ [key] { RegCloseKey(key); } };
|
|
|
|
// delete the value itself
|
|
if (auto res = RegDeleteKeyValueW(scope, path.c_str(), name.has_value() ? name->c_str() : nullptr); res != ERROR_SUCCESS)
|
|
{
|
|
Logger::error(L"unApply of {}: RegDeleteKeyValueW failed: {}", toString(), get_last_error_or_default(res));
|
|
return false;
|
|
}
|
|
|
|
// Check if the path doesn't contain anything and delete it if so
|
|
DWORD nValues = 0;
|
|
DWORD maxValueLen = 0;
|
|
const auto ok =
|
|
RegQueryInfoKeyW(
|
|
key, nullptr, nullptr, nullptr, nullptr, nullptr, nullptr, &nValues, nullptr, &maxValueLen, nullptr, nullptr) ==
|
|
ERROR_SUCCESS;
|
|
|
|
if (ok && (!nValues || !maxValueLen))
|
|
{
|
|
RegDeleteTreeW(scope, path.c_str());
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool requiresElevation() const { return scope == HKEY_LOCAL_MACHINE; }
|
|
|
|
private:
|
|
static DWORD valueTypeToWinapiType(const value_t& v)
|
|
{
|
|
return std::visit(
|
|
[](auto&& arg) {
|
|
using T = std::decay_t<decltype(arg)>;
|
|
if constexpr (std::is_same_v<T, DWORD>)
|
|
return REG_DWORD;
|
|
else if constexpr (std::is_same_v<T, std::wstring>)
|
|
return REG_SZ;
|
|
else
|
|
static_assert(always_false_v<T>, "support for this registry type is not implemented");
|
|
},
|
|
v);
|
|
}
|
|
|
|
static void valueToBuffer(const value_t& value, wchar_t buffer[VALUE_BUFFER_SIZE], DWORD& valueSize, DWORD& type)
|
|
{
|
|
using detail::overloaded;
|
|
|
|
std::visit(overloaded{ [&](DWORD value) {
|
|
*reinterpret_cast<DWORD*>(buffer) = value;
|
|
type = REG_DWORD;
|
|
valueSize = sizeof(value);
|
|
},
|
|
[&](const std::wstring& value) {
|
|
assert(value.size() < VALUE_BUFFER_SIZE);
|
|
value.copy(buffer, value.size());
|
|
type = REG_SZ;
|
|
valueSize = static_cast<DWORD>(sizeof(wchar_t) * value.size());
|
|
} },
|
|
value);
|
|
}
|
|
|
|
static std::optional<value_t> bufferToValue(const wchar_t buffer[VALUE_BUFFER_SIZE],
|
|
const DWORD valueSize,
|
|
const DWORD type)
|
|
{
|
|
switch (type)
|
|
{
|
|
case REG_DWORD:
|
|
return *reinterpret_cast<const DWORD*>(buffer);
|
|
case REG_SZ:
|
|
{
|
|
if (!valueSize)
|
|
{
|
|
return std::wstring{};
|
|
}
|
|
std::wstring result{ buffer, valueSize / sizeof(wchar_t) };
|
|
while (result[result.size() - 1] == L'\0')
|
|
{
|
|
result.resize(result.size() - 1);
|
|
}
|
|
return result;
|
|
}
|
|
default:
|
|
return std::nullopt;
|
|
}
|
|
}
|
|
};
|
|
|
|
struct ChangeSet
|
|
{
|
|
std::vector<ValueChange> changes;
|
|
|
|
bool isApplied() const
|
|
{
|
|
for (const auto& c : changes)
|
|
{
|
|
if (c.required && !c.isApplied())
|
|
{
|
|
return false;
|
|
}
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool apply() const
|
|
{
|
|
bool ok = true;
|
|
for (const auto& c : changes)
|
|
{
|
|
ok = (c.apply()||!c.required) && ok;
|
|
}
|
|
return ok;
|
|
}
|
|
|
|
bool unApply() const
|
|
{
|
|
bool ok = true;
|
|
for (const auto& c : changes)
|
|
{
|
|
ok = (c.unApply()||!c.required) && ok;
|
|
}
|
|
return ok;
|
|
}
|
|
};
|
|
|
|
const inline std::wstring DOTNET_COMPONENT_CATEGORY_CLSID = L"{62C8FE65-4EBB-45E7-B440-6E39B2CDBF29}";
|
|
const inline std::wstring ITHUMBNAIL_PROVIDER_CLSID = L"{E357FCCD-A995-4576-B01F-234630154E96}";
|
|
const inline std::wstring IPREVIEW_HANDLER_CLSID = L"{8895b1c6-b41f-4c1c-a562-0d564250836f}";
|
|
|
|
namespace shellex
|
|
{
|
|
enum PreviewHandlerType
|
|
{
|
|
preview,
|
|
thumbnail
|
|
};
|
|
|
|
inline registry::ChangeSet generatePreviewHandler(const PreviewHandlerType handlerType,
|
|
const bool perUser,
|
|
std::wstring handlerClsid,
|
|
std::wstring powertoysVersion,
|
|
std::wstring fullPathToHandler,
|
|
std::wstring className,
|
|
std::wstring displayName,
|
|
std::vector<std::wstring> fileTypes,
|
|
std::wstring perceivedType = L"",
|
|
std::wstring fileKindType = L"")
|
|
{
|
|
const HKEY scope = perUser ? HKEY_CURRENT_USER : HKEY_LOCAL_MACHINE;
|
|
|
|
std::wstring clsidPath = L"Software\\Classes\\CLSID";
|
|
clsidPath += L'\\';
|
|
clsidPath += handlerClsid;
|
|
|
|
std::wstring inprocServerPath = clsidPath;
|
|
inprocServerPath += L'\\';
|
|
inprocServerPath += L"InprocServer32";
|
|
|
|
std::wstring assemblyKeyValue;
|
|
if (const auto lastDotPos = className.rfind(L'.'); lastDotPos != std::wstring::npos)
|
|
{
|
|
assemblyKeyValue = L"PowerToys." + className.substr(lastDotPos + 1);
|
|
}
|
|
else
|
|
{
|
|
assemblyKeyValue = L"PowerToys." + className;
|
|
}
|
|
|
|
assemblyKeyValue += L", Version=";
|
|
assemblyKeyValue += powertoysVersion;
|
|
assemblyKeyValue += L", Culture=neutral";
|
|
|
|
std::wstring versionPath = inprocServerPath;
|
|
versionPath += L'\\';
|
|
versionPath += powertoysVersion;
|
|
|
|
using vec_t = std::vector<registry::ValueChange>;
|
|
// TODO: verify that we actually need all of those
|
|
vec_t changes = { { scope, clsidPath, L"DisplayName", displayName },
|
|
{ scope, clsidPath, std::nullopt, className },
|
|
{ scope, inprocServerPath, std::nullopt, fullPathToHandler },
|
|
{ scope, inprocServerPath, L"Assembly", assemblyKeyValue },
|
|
{ scope, inprocServerPath, L"Class", className },
|
|
{ scope, inprocServerPath, L"ThreadingModel", L"Apartment" } };
|
|
|
|
for (const auto& fileType : fileTypes)
|
|
{
|
|
std::wstring fileTypePath = L"Software\\Classes\\" + fileType;
|
|
std::wstring fileAssociationPath = fileTypePath + L"\\shellex\\";
|
|
fileAssociationPath += handlerType == PreviewHandlerType::preview ? IPREVIEW_HANDLER_CLSID : ITHUMBNAIL_PROVIDER_CLSID;
|
|
changes.push_back({ scope, fileAssociationPath, std::nullopt, handlerClsid });
|
|
if (!fileKindType.empty())
|
|
{
|
|
// Registering a file type as a kind needs to be done at the HKEY_LOCAL_MACHINE level.
|
|
// Make it optional as well so that we don't fail registering the handler if we can't write to HKEY_LOCAL_MACHINE.
|
|
std::wstring kindMapPath = L"Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\KindMap";
|
|
changes.push_back({ HKEY_LOCAL_MACHINE, kindMapPath, fileType, fileKindType, false});
|
|
}
|
|
if (!perceivedType.empty())
|
|
{
|
|
changes.push_back({ scope, fileTypePath, L"PerceivedType", perceivedType });
|
|
}
|
|
if (handlerType == PreviewHandlerType::preview && fileType == L".reg")
|
|
{
|
|
// this regfile registry key has precedence over Software\Classes\.reg for .reg files
|
|
std::wstring regfilePath = L"Software\\Classes\\regfile\\shellex\\" + IPREVIEW_HANDLER_CLSID + L"\\";
|
|
changes.push_back({ scope, regfilePath, std::nullopt, handlerClsid });
|
|
}
|
|
}
|
|
|
|
if (handlerType == PreviewHandlerType::preview)
|
|
{
|
|
const std::wstring previewHostClsid = L"{6d2b5079-2f0b-48dd-ab7f-97cec514d30b}";
|
|
const std::wstring previewHandlerListPath = LR"(Software\Microsoft\Windows\CurrentVersion\PreviewHandlers)";
|
|
|
|
changes.push_back({ scope, clsidPath, L"AppID", previewHostClsid });
|
|
changes.push_back({ scope, previewHandlerListPath, handlerClsid, displayName });
|
|
}
|
|
|
|
return registry::ChangeSet{ .changes = std::move(changes) };
|
|
}
|
|
}
|
|
}
|