mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-02-23 19:49:43 +01:00
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request As title <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] Closes: #xxx <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Tests should be picked up and run and pass
181 lines
5.5 KiB
C++
181 lines
5.5 KiB
C++
#include "pch.h"
|
|
#include "TestHelpers.h"
|
|
#include <logger_helper.h>
|
|
|
|
using namespace Microsoft::VisualStudio::CppUnitTestFramework;
|
|
using namespace LoggerHelpers;
|
|
|
|
namespace UnitTestsCommonUtils
|
|
{
|
|
TEST_CLASS(LoggerHelperTests)
|
|
{
|
|
public:
|
|
// get_log_folder_path tests
|
|
TEST_METHOD(GetLogFolderPath_ValidAppPath_ReturnsPath)
|
|
{
|
|
auto result = get_log_folder_path(L"TestApp");
|
|
|
|
Assert::IsFalse(result.empty());
|
|
// Should contain the app name or be a valid path
|
|
auto pathStr = result.wstring();
|
|
Assert::IsTrue(pathStr.length() > 0);
|
|
}
|
|
|
|
TEST_METHOD(GetLogFolderPath_EmptyAppPath_ReturnsPath)
|
|
{
|
|
auto result = get_log_folder_path(L"");
|
|
|
|
// Should still return a base path
|
|
Assert::IsTrue(true); // Just verify no crash
|
|
}
|
|
|
|
TEST_METHOD(GetLogFolderPath_SpecialCharacters_Works)
|
|
{
|
|
auto result = get_log_folder_path(L"Test App With Spaces");
|
|
|
|
// Should handle spaces in path
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
TEST_METHOD(GetLogFolderPath_ConsistentResults)
|
|
{
|
|
auto result1 = get_log_folder_path(L"TestApp");
|
|
auto result2 = get_log_folder_path(L"TestApp");
|
|
|
|
Assert::AreEqual(result1.wstring(), result2.wstring());
|
|
}
|
|
|
|
// dir_exists tests
|
|
TEST_METHOD(DirExists_WindowsDirectory_ReturnsTrue)
|
|
{
|
|
bool result = dir_exists(std::filesystem::path(L"C:\\Windows"));
|
|
Assert::IsTrue(result);
|
|
}
|
|
|
|
TEST_METHOD(DirExists_NonExistentDirectory_ReturnsFalse)
|
|
{
|
|
bool result = dir_exists(std::filesystem::path(L"C:\\NonExistentDir12345"));
|
|
Assert::IsFalse(result);
|
|
}
|
|
|
|
TEST_METHOD(DirExists_FileInsteadOfDir_ReturnsTrue)
|
|
{
|
|
// notepad.exe is a file, not a directory
|
|
bool result = dir_exists(std::filesystem::path(L"C:\\Windows\\notepad.exe"));
|
|
Assert::IsTrue(result);
|
|
}
|
|
|
|
TEST_METHOD(DirExists_EmptyPath_ReturnsFalse)
|
|
{
|
|
bool result = dir_exists(std::filesystem::path(L""));
|
|
Assert::IsFalse(result);
|
|
}
|
|
|
|
TEST_METHOD(DirExists_TempDirectory_ReturnsTrue)
|
|
{
|
|
wchar_t tempPath[MAX_PATH];
|
|
GetTempPathW(MAX_PATH, tempPath);
|
|
|
|
bool result = dir_exists(std::filesystem::path(tempPath));
|
|
Assert::IsTrue(result);
|
|
}
|
|
|
|
// delete_old_log_folder tests
|
|
TEST_METHOD(DeleteOldLogFolder_NonExistentFolder_DoesNotCrash)
|
|
{
|
|
delete_old_log_folder(std::filesystem::path(L"C:\\NonExistentLogFolder12345"));
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
TEST_METHOD(DeleteOldLogFolder_ValidEmptyFolder_Works)
|
|
{
|
|
TestHelpers::TempDirectory tempDir;
|
|
|
|
// Create a subfolder structure
|
|
auto logFolder = std::filesystem::path(tempDir.path()) / L"logs";
|
|
std::filesystem::create_directories(logFolder);
|
|
|
|
Assert::IsTrue(std::filesystem::exists(logFolder));
|
|
|
|
delete_old_log_folder(logFolder);
|
|
|
|
// Folder may or may not be deleted depending on implementation
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
// delete_other_versions_log_folders tests
|
|
TEST_METHOD(DeleteOtherVersionsLogFolders_NonExistentPath_DoesNotCrash)
|
|
{
|
|
delete_other_versions_log_folders(L"C:\\NonExistent\\Path", L"1.0.0");
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
TEST_METHOD(DeleteOtherVersionsLogFolders_EmptyVersion_DoesNotCrash)
|
|
{
|
|
wchar_t tempPath[MAX_PATH];
|
|
GetTempPathW(MAX_PATH, tempPath);
|
|
|
|
delete_other_versions_log_folders(tempPath, L"");
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
// Thread safety tests
|
|
TEST_METHOD(GetLogFolderPath_ThreadSafe)
|
|
{
|
|
std::vector<std::thread> threads;
|
|
std::atomic<int> successCount{ 0 };
|
|
|
|
for (int i = 0; i < 10; ++i)
|
|
{
|
|
threads.emplace_back([&successCount, i]() {
|
|
auto path = get_log_folder_path(L"TestApp" + std::to_wstring(i));
|
|
if (!path.empty())
|
|
{
|
|
successCount++;
|
|
}
|
|
});
|
|
}
|
|
|
|
for (auto& t : threads)
|
|
{
|
|
t.join();
|
|
}
|
|
|
|
Assert::AreEqual(10, successCount.load());
|
|
}
|
|
|
|
TEST_METHOD(DirExists_ThreadSafe)
|
|
{
|
|
std::vector<std::thread> threads;
|
|
std::atomic<int> successCount{ 0 };
|
|
|
|
for (int i = 0; i < 10; ++i)
|
|
{
|
|
threads.emplace_back([&successCount]() {
|
|
for (int j = 0; j < 10; ++j)
|
|
{
|
|
dir_exists(std::filesystem::path(L"C:\\Windows"));
|
|
successCount++;
|
|
}
|
|
});
|
|
}
|
|
|
|
for (auto& t : threads)
|
|
{
|
|
t.join();
|
|
}
|
|
|
|
Assert::AreEqual(100, successCount.load());
|
|
}
|
|
|
|
// Path construction tests
|
|
TEST_METHOD(GetLogFolderPath_ReturnsValidFilesystemPath)
|
|
{
|
|
auto result = get_log_folder_path(L"TestApp");
|
|
|
|
// Should be a valid path that we can use with filesystem operations
|
|
Assert::IsTrue(result.is_absolute() || result.has_root_name() || !result.empty());
|
|
}
|
|
};
|
|
}
|