mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-02-23 19:49:43 +01:00
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request As title <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] Closes: #xxx <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Tests should be picked up and run and pass
147 lines
4.6 KiB
C++
147 lines
4.6 KiB
C++
#include "pch.h"
|
|
#include "TestHelpers.h"
|
|
#include <MsiUtils.h>
|
|
|
|
using namespace Microsoft::VisualStudio::CppUnitTestFramework;
|
|
|
|
namespace UnitTestsCommonUtils
|
|
{
|
|
TEST_CLASS(MsiUtilsTests)
|
|
{
|
|
public:
|
|
// GetMsiPackageInstalledPath tests
|
|
TEST_METHOD(GetMsiPackageInstalledPath_PerUser_DoesNotCrash)
|
|
{
|
|
auto result = GetMsiPackageInstalledPath(true);
|
|
// Result depends on installation state, but should not crash
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
TEST_METHOD(GetMsiPackageInstalledPath_PerMachine_DoesNotCrash)
|
|
{
|
|
auto result = GetMsiPackageInstalledPath(false);
|
|
// Result depends on installation state, but should not crash
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
TEST_METHOD(GetMsiPackageInstalledPath_ConsistentResults)
|
|
{
|
|
auto result1 = GetMsiPackageInstalledPath(true);
|
|
auto result2 = GetMsiPackageInstalledPath(true);
|
|
|
|
// Results should be consistent
|
|
Assert::AreEqual(result1.has_value(), result2.has_value());
|
|
if (result1.has_value() && result2.has_value())
|
|
{
|
|
Assert::AreEqual(*result1, *result2);
|
|
}
|
|
}
|
|
|
|
TEST_METHOD(GetMsiPackageInstalledPath_PerUserVsPerMachine_MayDiffer)
|
|
{
|
|
auto perUser = GetMsiPackageInstalledPath(true);
|
|
auto perMachine = GetMsiPackageInstalledPath(false);
|
|
|
|
// These may or may not be equal depending on installation
|
|
// Just verify they don't crash
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
// GetMsiPackagePath tests
|
|
TEST_METHOD(GetMsiPackagePath_DoesNotCrash)
|
|
{
|
|
auto result = GetMsiPackagePath();
|
|
// Result depends on installation state, but should not crash
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
TEST_METHOD(GetMsiPackagePath_ConsistentResults)
|
|
{
|
|
auto result1 = GetMsiPackagePath();
|
|
auto result2 = GetMsiPackagePath();
|
|
|
|
// Results should be consistent
|
|
Assert::AreEqual(result1, result2);
|
|
}
|
|
|
|
// Thread safety tests
|
|
TEST_METHOD(GetMsiPackageInstalledPath_ThreadSafe)
|
|
{
|
|
std::vector<std::thread> threads;
|
|
std::atomic<int> successCount{ 0 };
|
|
|
|
for (int i = 0; i < 5; ++i)
|
|
{
|
|
threads.emplace_back([&successCount]() {
|
|
for (int j = 0; j < 5; ++j)
|
|
{
|
|
GetMsiPackageInstalledPath(j % 2 == 0);
|
|
successCount++;
|
|
}
|
|
});
|
|
}
|
|
|
|
for (auto& t : threads)
|
|
{
|
|
t.join();
|
|
}
|
|
|
|
Assert::AreEqual(25, successCount.load());
|
|
}
|
|
|
|
TEST_METHOD(GetMsiPackagePath_ThreadSafe)
|
|
{
|
|
std::vector<std::thread> threads;
|
|
std::atomic<int> successCount{ 0 };
|
|
|
|
for (int i = 0; i < 5; ++i)
|
|
{
|
|
threads.emplace_back([&successCount]() {
|
|
for (int j = 0; j < 5; ++j)
|
|
{
|
|
GetMsiPackagePath();
|
|
successCount++;
|
|
}
|
|
});
|
|
}
|
|
|
|
for (auto& t : threads)
|
|
{
|
|
t.join();
|
|
}
|
|
|
|
Assert::AreEqual(25, successCount.load());
|
|
}
|
|
|
|
// Return value format tests
|
|
TEST_METHOD(GetMsiPackageInstalledPath_ReturnsValidPathOrEmpty)
|
|
{
|
|
auto path = GetMsiPackageInstalledPath(true);
|
|
|
|
if (path.has_value() && !path->empty())
|
|
{
|
|
// If a path is returned, it should contain backslash or be a valid path format
|
|
Assert::IsTrue(path->find(L'\\') != std::wstring::npos ||
|
|
path->find(L'/') != std::wstring::npos ||
|
|
path->length() >= 2); // At minimum drive letter + colon
|
|
}
|
|
// No value or empty is also valid (not installed)
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
TEST_METHOD(GetMsiPackagePath_ReturnsValidPathOrEmpty)
|
|
{
|
|
auto path = GetMsiPackagePath();
|
|
|
|
if (!path.empty())
|
|
{
|
|
// If a path is returned, it should be a valid path format
|
|
Assert::IsTrue(path.find(L'\\') != std::wstring::npos ||
|
|
path.find(L'/') != std::wstring::npos ||
|
|
path.length() >= 2);
|
|
}
|
|
Assert::IsTrue(true);
|
|
}
|
|
};
|
|
}
|