mirror of
https://github.com/microsoft/PowerToys.git
synced 2025-12-16 03:37:59 +01:00
fdd1f47d85
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Fixes a logic issue in the UI test automation pipeline where selecting `latestMainOfficialBuild` would still trigger a full PowerToys build instead of only building UI tests. ### Why The pipeline was using template variables in compilation-time conditions, which doesn't work correctly in pipeline ### fix Replace template variable references with direct parameter comparisons in compilation-time conditions <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] Closes: #xxx - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed
111 lines
4.1 KiB
YAML
111 lines
4.1 KiB
YAML
# Template for official build path: Download Official Build + Build UI Tests Only + Run Tests
|
|
parameters:
|
|
- name: platform
|
|
type: string
|
|
- name: buildSource
|
|
type: string
|
|
- name: specificBuildId
|
|
type: string
|
|
default: 'xxxx'
|
|
- name: useLatestWebView2
|
|
type: boolean
|
|
default: false
|
|
- name: uiTestModules
|
|
type: object
|
|
default: []
|
|
|
|
stages:
|
|
# Stage 1: Build UI Tests Only
|
|
- stage: BuildUITests_${{ parameters.platform }}
|
|
displayName: Build UI Tests Only ${{ parameters.platform }}
|
|
dependsOn: []
|
|
jobs:
|
|
- template: job-build-ui-tests.yml
|
|
parameters:
|
|
pool:
|
|
${{ if eq(variables['System.CollectionId'], 'cb55739e-4afe-46a3-970f-1b49d8ee7564') }}:
|
|
name: SHINE-INT-L
|
|
${{ else }}:
|
|
name: SHINE-OSS-L
|
|
buildPlatforms:
|
|
- ${{ parameters.platform }}
|
|
uiTestModules: ${{ parameters.uiTestModules }}
|
|
|
|
# Stage 2: Run UI Tests with Official Build
|
|
- ${{ if eq(parameters.platform, 'x64') }}:
|
|
- stage: Test_x64Win10_OfficialBuild
|
|
displayName: Test x64Win10 (Official Build)
|
|
dependsOn: BuildUITests_${{ parameters.platform }}
|
|
jobs:
|
|
- template: job-test-project.yml
|
|
parameters:
|
|
platform: x64Win10
|
|
configuration: Release
|
|
useLatestWebView2: ${{ parameters.useLatestWebView2 }}
|
|
buildSource: ${{ parameters.buildSource }}
|
|
specificBuildId: ${{ parameters.specificBuildId }}
|
|
uiTestModules: ${{ parameters.uiTestModules }}
|
|
|
|
# Additional per-user installation test
|
|
- template: job-test-project.yml
|
|
parameters:
|
|
platform: x64Win10
|
|
configuration: Release
|
|
useLatestWebView2: ${{ parameters.useLatestWebView2 }}
|
|
buildSource: ${{ parameters.buildSource }}
|
|
specificBuildId: ${{ parameters.specificBuildId }}
|
|
uiTestModules: ${{ parameters.uiTestModules }}
|
|
installMode: 'peruser'
|
|
jobSuffix: '_PerUser'
|
|
|
|
- stage: Test_x64Win11_OfficialBuild
|
|
displayName: Test x64Win11 (Official Build)
|
|
dependsOn: BuildUITests_${{ parameters.platform }}
|
|
jobs:
|
|
- template: job-test-project.yml
|
|
parameters:
|
|
platform: x64Win11
|
|
configuration: Release
|
|
useLatestWebView2: ${{ parameters.useLatestWebView2 }}
|
|
buildSource: ${{ parameters.buildSource }}
|
|
specificBuildId: ${{ parameters.specificBuildId }}
|
|
uiTestModules: ${{ parameters.uiTestModules }}
|
|
|
|
# Additional per-user installation test
|
|
- template: job-test-project.yml
|
|
parameters:
|
|
platform: x64Win11
|
|
configuration: Release
|
|
useLatestWebView2: ${{ parameters.useLatestWebView2 }}
|
|
buildSource: ${{ parameters.buildSource }}
|
|
specificBuildId: ${{ parameters.specificBuildId }}
|
|
uiTestModules: ${{ parameters.uiTestModules }}
|
|
installMode: 'peruser'
|
|
jobSuffix: '_PerUser'
|
|
|
|
- ${{ if ne(parameters.platform, 'x64') }}:
|
|
- stage: Test_${{ parameters.platform }}_OfficialBuild
|
|
displayName: Test ${{ parameters.platform }} (Official Build)
|
|
dependsOn: BuildUITests_${{ parameters.platform }}
|
|
jobs:
|
|
- template: job-test-project.yml
|
|
parameters:
|
|
platform: ${{ parameters.platform }}
|
|
configuration: Release
|
|
useLatestWebView2: ${{ parameters.useLatestWebView2 }}
|
|
buildSource: ${{ parameters.buildSource }}
|
|
specificBuildId: ${{ parameters.specificBuildId }}
|
|
uiTestModules: ${{ parameters.uiTestModules }}
|
|
|
|
# Additional per-user installation test
|
|
- template: job-test-project.yml
|
|
parameters:
|
|
platform: ${{ parameters.platform }}
|
|
configuration: Release
|
|
useLatestWebView2: ${{ parameters.useLatestWebView2 }}
|
|
buildSource: ${{ parameters.buildSource }}
|
|
specificBuildId: ${{ parameters.specificBuildId }}
|
|
uiTestModules: ${{ parameters.uiTestModules }}
|
|
installMode: 'peruser'
|
|
jobSuffix: '_PerUser'
|