mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-02-24 04:00:02 +01:00
6acb793184
What the title says. 😄
Rather than relying on the potentially overloaded `!=` or `==` operators
when checking for null, now we'll use the `is` expression (possibly
combined with the `not` operator) to ensure correct checking. Probably
overkill for many of these classes, but decided to err on the side of
consistency. Would matter more on classes that may be inherited or
extended.
Using `is` and `is not` will provide us a guarantee that no
user-overloaded equality operators (`==`/`!=`) is invoked when a
`expression is null` is evaluated.
In code form, changed all instances of:
```c#
something != null
something == null
```
to:
```c#
something is not null
something is null
```
The one exception was checking null on a `KeyChord`. `KeyChord` is a
struct which is never null so VS will raise an error when trying this
versus just providing a warning when using `keyChord != null`. In
reality, we shouldn't do this check because it can't ever be null. In
the case of a `KeyChord` it **would** be a `KeyChord` equivalent to:
```c#
KeyChord keyChord = new ()
{
Modifiers = 0,
Vkey = 0,
ScanCode = 0
};
```
77 lines
2.4 KiB
C#
77 lines
2.4 KiB
C#
// Copyright (c) Microsoft Corporation
|
|
// The Microsoft Corporation licenses this file to you under the MIT license.
|
|
// See the LICENSE file in the project root for more information.
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using ManagedCommon;
|
|
using Microsoft.CmdPal.Ext.Apps.Utils;
|
|
using Windows.Win32;
|
|
using Windows.Win32.Storage.Packaging.Appx;
|
|
using Windows.Win32.System.Com;
|
|
|
|
namespace Microsoft.CmdPal.Ext.Apps.Programs;
|
|
|
|
public static class AppxPackageHelper
|
|
{
|
|
internal static unsafe List<IntPtr> GetAppsFromManifest(IStream* stream)
|
|
{
|
|
PInvoke.CoCreateInstance(typeof(AppxFactory).GUID, null, CLSCTX.CLSCTX_INPROC_SERVER, out IAppxFactory* appxFactory).ThrowOnFailure();
|
|
using var handle = new SafeComHandle((IntPtr)appxFactory);
|
|
|
|
IAppxManifestReader* reader = null;
|
|
IAppxManifestApplicationsEnumerator* manifestApps = null;
|
|
var result = new List<IntPtr>();
|
|
|
|
appxFactory->CreateManifestReader(stream, &reader);
|
|
using var readerHandle = new SafeComHandle((IntPtr)reader);
|
|
reader->GetApplications(&manifestApps);
|
|
using var manifestAppsHandle = new SafeComHandle((IntPtr)manifestApps);
|
|
|
|
while (true)
|
|
{
|
|
manifestApps->GetHasCurrent(out var hasCurrent);
|
|
if (hasCurrent == false)
|
|
{
|
|
break;
|
|
}
|
|
|
|
IAppxManifestApplication* manifestApp = null;
|
|
|
|
try
|
|
{
|
|
manifestApps->GetCurrent(&manifestApp).ThrowOnFailure();
|
|
|
|
var hr = manifestApp->GetStringValue("AppListEntry", out var appListEntryPtr);
|
|
var appListEntry = ComFreeHelper.GetStringAndFree(hr, appListEntryPtr);
|
|
|
|
if (appListEntry != "none")
|
|
{
|
|
result.Add((IntPtr)manifestApp);
|
|
}
|
|
else if (manifestApp is not null)
|
|
{
|
|
manifestApp->Release();
|
|
}
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
if (manifestApp is not null)
|
|
{
|
|
manifestApp->Release();
|
|
}
|
|
|
|
Logger.LogError($"Failed to get current application from manifest: {ex.Message}");
|
|
}
|
|
|
|
manifestApps->MoveNext(out var hasNext);
|
|
if (hasNext == false)
|
|
{
|
|
break;
|
|
}
|
|
}
|
|
|
|
return result;
|
|
}
|
|
}
|