mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-02-23 19:49:43 +01:00
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Introduce a new PowerToys' module PowerDisplay to let user can control their monitor settings without touching monitor's button. Support feature list: Common: 1. Profiles support 2. Integration with LightSwitch (auto switch profile when theme change) 3. TrayIcon 4. Save and restore settings when startup 5. Shortcut 6. Rotation 7. GPO support 8. Auto re-discovery monitor when plugging and unplugging monitors. 9. Identify Monitors 10. Quick profile switch Especially for DDC/CI monitor: 1. Brightness 2. Contrast 3. Volume 4. Color temperature (preset profile) 5. Input source 6. Power State (poweroff) Design doc: https://github.com/microsoft/PowerToys/blob/yuleng/display/pr/3/doc/devdocs/modules/powerdisplay/design.md AOT compatibility: I designed this module for AOT from the start, so I'm pretty sure at least 95% of it is AOT compatible. But unfortunately, PowerToys still have a AOT blocker to block this module publish with AOT. Currently PowerToys will check the .net file version (file version not lib version) to avoid crash. So, all modules should reference Common.UI or add UseWPF to avoid overwrite the .net file with different version (which may cause crash). Todo: - [ ] BugBash - [ ] Icon - [ ] IdentifyWindow UI improvement Demo Main UI: <img width="546" height="671" alt="image" src="https://github.com/user-attachments/assets/b0ad9ac5-8000-4365-a192-ab8c2d66d4f1" /> Input Source: <img width="536" height="674" alt="image" src="https://github.com/user-attachments/assets/80f9ccd7-4f8c-4201-b177-cc86c5bcc9e3" /> Settings UI: <img width="1581" height="1191" alt="image" src="https://github.com/user-attachments/assets/6a82e4bb-8f96-4f28-abf9-d7c45e1c8ef7" /> <img width="1525" height="1146" alt="image" src="https://github.com/user-attachments/assets/aae81e65-08fd-453a-bf52-02a74f2fdea0" /> Closes: #42942 #42678 #41117 #38109 #35564 #34932 #28500 #1052 #18149 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #1052 - [x] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [x] **Tests:** Added/updated and all pass - [x] **Localization:** All end-user-facing strings can be localized - [x] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed --------- Co-authored-by: Yu Leng <yuleng@microsoft.com> Co-authored-by: Niels Laute <niels.laute@live.nl> Co-authored-by: moooyo <lengyuchn@gmail.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
334 lines
12 KiB
C++
334 lines
12 KiB
C++
#include "pch.h"
|
|
#include "LightSwitchStateManager.h"
|
|
#include <logger.h>
|
|
#include <LightSwitchUtils.h>
|
|
#include "ThemeScheduler.h"
|
|
#include <ThemeHelper.h>
|
|
#include <common/interop/shared_constants.h>
|
|
|
|
void ApplyTheme(bool shouldBeLight);
|
|
|
|
// Constructor
|
|
LightSwitchStateManager::LightSwitchStateManager()
|
|
{
|
|
Logger::info(L"[LightSwitchStateManager] Initialized");
|
|
}
|
|
|
|
// Called when settings.json changes
|
|
void LightSwitchStateManager::OnSettingsChanged()
|
|
{
|
|
std::lock_guard<std::mutex> lock(_stateMutex);
|
|
|
|
// If manual override was active, clear it so new settings take effect
|
|
if (_state.isManualOverride)
|
|
{
|
|
_state.isManualOverride = false;
|
|
}
|
|
|
|
EvaluateAndApplyIfNeeded();
|
|
}
|
|
|
|
// Called once per minute
|
|
void LightSwitchStateManager::OnTick()
|
|
{
|
|
std::lock_guard<std::mutex> lock(_stateMutex);
|
|
if (_state.lastAppliedMode != ScheduleMode::FollowNightLight)
|
|
{
|
|
EvaluateAndApplyIfNeeded();
|
|
}
|
|
}
|
|
|
|
// Called when manual override is triggered (via hotkey)
|
|
void LightSwitchStateManager::OnManualOverride()
|
|
{
|
|
std::lock_guard<std::mutex> lock(_stateMutex);
|
|
Logger::info(L"[LightSwitchStateManager] Manual override triggered");
|
|
_state.isManualOverride = !_state.isManualOverride;
|
|
|
|
// When entering manual override, sync internal theme state to match the current system
|
|
// The hotkey handler in ModuleInterface has already toggled the theme, so we read the new state
|
|
if (_state.isManualOverride)
|
|
{
|
|
_state.isSystemLightActive = GetCurrentSystemTheme();
|
|
_state.isAppsLightActive = GetCurrentAppsTheme();
|
|
|
|
Logger::debug(L"[LightSwitchStateManager] Synced internal theme state to current system theme ({}) and apps theme ({}).",
|
|
(_state.isSystemLightActive ? L"light" : L"dark"),
|
|
(_state.isAppsLightActive ? L"light" : L"dark"));
|
|
|
|
// Notify PowerDisplay about the theme change triggered by hotkey
|
|
// The theme has already been applied by ModuleInterface, we just need to notify PowerDisplay
|
|
NotifyPowerDisplay(_state.isSystemLightActive);
|
|
}
|
|
|
|
EvaluateAndApplyIfNeeded();
|
|
}
|
|
|
|
// Runs with the registry observer detects a change in Night Light settings.
|
|
void LightSwitchStateManager::OnNightLightChange()
|
|
{
|
|
std::lock_guard<std::mutex> lock(_stateMutex);
|
|
|
|
bool newNightLightState = IsNightLightEnabled();
|
|
|
|
// In Follow Night Light mode, treat a Night Light toggle as a boundary
|
|
if (_state.lastAppliedMode == ScheduleMode::FollowNightLight && _state.isManualOverride)
|
|
{
|
|
Logger::info(L"[LightSwitchStateManager] Night Light changed while manual override active; "
|
|
L"treating as a boundary and clearing manual override.");
|
|
_state.isManualOverride = false;
|
|
}
|
|
|
|
if (newNightLightState != _state.isNightLightActive)
|
|
{
|
|
Logger::info(L"[LightSwitchStateManager] Night Light toggled to {}",
|
|
newNightLightState ? L"ON" : L"OFF");
|
|
|
|
_state.isNightLightActive = newNightLightState;
|
|
}
|
|
else
|
|
{
|
|
Logger::debug(L"[LightSwitchStateManager] Night Light change event fired, but no actual change.");
|
|
}
|
|
|
|
EvaluateAndApplyIfNeeded();
|
|
}
|
|
|
|
// Helpers
|
|
bool LightSwitchStateManager::CoordinatesAreValid(const std::wstring& lat, const std::wstring& lon)
|
|
{
|
|
try
|
|
{
|
|
double latVal = std::stod(lat);
|
|
double lonVal = std::stod(lon);
|
|
return !(latVal == 0 && lonVal == 0) && (latVal >= -90.0 && latVal <= 90.0) && (lonVal >= -180.0 && lonVal <= 180.0);
|
|
}
|
|
catch (...)
|
|
{
|
|
return false;
|
|
}
|
|
}
|
|
|
|
void LightSwitchStateManager::SyncInitialThemeState()
|
|
{
|
|
std::lock_guard<std::mutex> lock(_stateMutex);
|
|
_state.isSystemLightActive = GetCurrentSystemTheme();
|
|
_state.isAppsLightActive = GetCurrentAppsTheme();
|
|
_state.isNightLightActive = IsNightLightEnabled();
|
|
Logger::debug(L"[LightSwitchStateManager] Synced initial state to current system theme ({})",
|
|
_state.isSystemLightActive ? L"light" : L"dark");
|
|
Logger::debug(L"[LightSwitchStateManager] Synced initial state to current apps theme ({})",
|
|
_state.isAppsLightActive ? L"light" : L"dark");
|
|
|
|
// This will ensure that the theme is applied according to current settings at startup
|
|
EvaluateAndApplyIfNeeded();
|
|
}
|
|
|
|
static std::pair<int, int> update_sun_times(auto& settings)
|
|
{
|
|
double latitude = std::stod(settings.latitude);
|
|
double longitude = std::stod(settings.longitude);
|
|
|
|
SYSTEMTIME st;
|
|
GetLocalTime(&st);
|
|
|
|
SunTimes newTimes = CalculateSunriseSunset(latitude, longitude, st.wYear, st.wMonth, st.wDay);
|
|
|
|
int newLightTime = newTimes.sunriseHour * 60 + newTimes.sunriseMinute;
|
|
int newDarkTime = newTimes.sunsetHour * 60 + newTimes.sunsetMinute;
|
|
|
|
try
|
|
{
|
|
auto values = PowerToysSettings::PowerToyValues::load_from_settings_file(L"LightSwitch");
|
|
values.add_property(L"lightTime", newLightTime);
|
|
values.add_property(L"darkTime", newDarkTime);
|
|
values.save_to_settings_file();
|
|
|
|
Logger::info(L"[LightSwitchService] Updated sun times and saved to config.");
|
|
}
|
|
catch (const std::exception& e)
|
|
{
|
|
std::string msg = e.what();
|
|
std::wstring wmsg(msg.begin(), msg.end());
|
|
Logger::error(L"[LightSwitchService] Exception during sun time update: {}", wmsg);
|
|
}
|
|
|
|
return { newLightTime, newDarkTime };
|
|
}
|
|
|
|
// Internal: decide what should happen now
|
|
void LightSwitchStateManager::EvaluateAndApplyIfNeeded()
|
|
{
|
|
LightSwitchSettings::instance().LoadSettings();
|
|
const auto& _currentSettings = LightSwitchSettings::settings();
|
|
auto now = GetNowMinutes();
|
|
|
|
// Early exit: OFF mode just pauses activity
|
|
if (_currentSettings.scheduleMode == ScheduleMode::Off)
|
|
{
|
|
_state.lastTickMinutes = now;
|
|
return;
|
|
}
|
|
|
|
bool coordsValid = CoordinatesAreValid(_currentSettings.latitude, _currentSettings.longitude);
|
|
|
|
// Handle Sun Mode recalculation
|
|
if (_currentSettings.scheduleMode == ScheduleMode::SunsetToSunrise && coordsValid)
|
|
{
|
|
SYSTEMTIME st;
|
|
GetLocalTime(&st);
|
|
bool newDay = (_state.lastEvaluatedDay != st.wDay);
|
|
bool modeChangedToSun = (_state.lastAppliedMode != ScheduleMode::SunsetToSunrise &&
|
|
_currentSettings.scheduleMode == ScheduleMode::SunsetToSunrise);
|
|
|
|
if (newDay || modeChangedToSun)
|
|
{
|
|
auto [newLightTime, newDarkTime] = update_sun_times(_currentSettings);
|
|
_state.lastEvaluatedDay = st.wDay;
|
|
_state.effectiveLightMinutes = newLightTime + _currentSettings.sunrise_offset;
|
|
_state.effectiveDarkMinutes = newDarkTime + _currentSettings.sunset_offset;
|
|
}
|
|
else
|
|
{
|
|
_state.effectiveLightMinutes = _currentSettings.lightTime + _currentSettings.sunrise_offset;
|
|
_state.effectiveDarkMinutes = _currentSettings.darkTime + _currentSettings.sunset_offset;
|
|
}
|
|
}
|
|
else if (_currentSettings.scheduleMode == ScheduleMode::FixedHours)
|
|
{
|
|
_state.effectiveLightMinutes = _currentSettings.lightTime;
|
|
_state.effectiveDarkMinutes = _currentSettings.darkTime;
|
|
}
|
|
|
|
// Handle manual override logic
|
|
if (_state.isManualOverride)
|
|
{
|
|
bool crossedBoundary = false;
|
|
if (_state.lastTickMinutes != -1)
|
|
{
|
|
int prev = _state.lastTickMinutes;
|
|
|
|
// Handle midnight wraparound safely
|
|
if (now < prev)
|
|
{
|
|
crossedBoundary =
|
|
(prev <= _state.effectiveLightMinutes || now >= _state.effectiveLightMinutes) ||
|
|
(prev <= _state.effectiveDarkMinutes || now >= _state.effectiveDarkMinutes);
|
|
}
|
|
else
|
|
{
|
|
crossedBoundary =
|
|
(prev < _state.effectiveLightMinutes && now >= _state.effectiveLightMinutes) ||
|
|
(prev < _state.effectiveDarkMinutes && now >= _state.effectiveDarkMinutes);
|
|
}
|
|
}
|
|
|
|
if (crossedBoundary)
|
|
{
|
|
_state.isManualOverride = false;
|
|
}
|
|
else
|
|
{
|
|
_state.lastTickMinutes = now;
|
|
return;
|
|
}
|
|
}
|
|
|
|
_state.lastAppliedMode = _currentSettings.scheduleMode;
|
|
|
|
bool shouldBeLight = false;
|
|
if (_currentSettings.scheduleMode == ScheduleMode::FollowNightLight)
|
|
{
|
|
shouldBeLight = !_state.isNightLightActive;
|
|
}
|
|
else
|
|
{
|
|
shouldBeLight = ShouldBeLight(now, _state.effectiveLightMinutes, _state.effectiveDarkMinutes);
|
|
}
|
|
|
|
bool appsNeedsToChange = _currentSettings.changeApps && (_state.isAppsLightActive != shouldBeLight);
|
|
bool systemNeedsToChange = _currentSettings.changeSystem && (_state.isSystemLightActive != shouldBeLight);
|
|
|
|
/* Logger::debug(
|
|
L"[LightSwitchStateManager] now = {:02d}:{:02d}, light boundary = {:02d}:{:02d} ({}), dark boundary = {:02d}:{:02d} ({})",
|
|
now / 60,
|
|
now % 60,
|
|
_state.effectiveLightMinutes / 60,
|
|
_state.effectiveLightMinutes % 60,
|
|
_state.effectiveLightMinutes,
|
|
_state.effectiveDarkMinutes / 60,
|
|
_state.effectiveDarkMinutes % 60,
|
|
_state.effectiveDarkMinutes); */
|
|
|
|
/* Logger::debug("should be light = {}, apps needs change = {}, system needs change = {}",
|
|
shouldBeLight ? "true" : "false",
|
|
appsNeedsToChange ? "true" : "false",
|
|
systemNeedsToChange ? "true" : "false"); */
|
|
|
|
// Only apply theme if there's a change or no override active
|
|
if (!_state.isManualOverride && (appsNeedsToChange || systemNeedsToChange))
|
|
{
|
|
Logger::info(L"[LightSwitchStateManager] Applying {} theme", shouldBeLight ? L"light" : L"dark");
|
|
ApplyTheme(shouldBeLight);
|
|
|
|
_state.isSystemLightActive = GetCurrentSystemTheme();
|
|
_state.isAppsLightActive = GetCurrentAppsTheme();
|
|
|
|
// Notify PowerDisplay to apply display profile if configured
|
|
NotifyPowerDisplay(shouldBeLight);
|
|
}
|
|
|
|
_state.lastTickMinutes = now;
|
|
}
|
|
|
|
// Notify PowerDisplay module about theme change to apply display profiles
|
|
void LightSwitchStateManager::NotifyPowerDisplay(bool isLight)
|
|
{
|
|
const auto& settings = LightSwitchSettings::settings();
|
|
|
|
// Check if any profile is enabled and configured
|
|
bool shouldNotify = false;
|
|
|
|
if (isLight && settings.enableLightModeProfile && !settings.lightModeProfile.empty())
|
|
{
|
|
shouldNotify = true;
|
|
}
|
|
else if (!isLight && settings.enableDarkModeProfile && !settings.darkModeProfile.empty())
|
|
{
|
|
shouldNotify = true;
|
|
}
|
|
|
|
if (!shouldNotify)
|
|
{
|
|
return;
|
|
}
|
|
|
|
try
|
|
{
|
|
// Signal PowerDisplay with the specific theme event
|
|
// Using separate events for light/dark eliminates race conditions where PowerDisplay
|
|
// might read the registry before LightSwitch has finished updating it
|
|
const wchar_t* eventName = isLight
|
|
? CommonSharedConstants::LIGHT_SWITCH_LIGHT_THEME_EVENT
|
|
: CommonSharedConstants::LIGHT_SWITCH_DARK_THEME_EVENT;
|
|
|
|
Logger::info(L"[LightSwitchStateManager] Notifying PowerDisplay about theme change (isLight: {})", isLight);
|
|
|
|
HANDLE hThemeEvent = CreateEventW(nullptr, FALSE, FALSE, eventName);
|
|
if (hThemeEvent)
|
|
{
|
|
SetEvent(hThemeEvent);
|
|
CloseHandle(hThemeEvent);
|
|
Logger::info(L"[LightSwitchStateManager] Theme event signaled to PowerDisplay: {}", eventName);
|
|
}
|
|
else
|
|
{
|
|
Logger::warn(L"[LightSwitchStateManager] Failed to create theme event (error: {})", GetLastError());
|
|
}
|
|
}
|
|
catch (...)
|
|
{
|
|
Logger::error(L"[LightSwitchStateManager] Failed to notify PowerDisplay");
|
|
}
|
|
}
|