mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-02-24 04:00:02 +01:00
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request As title <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] Closes: #xxx <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Tests should be picked up and run and pass
128 lines
3.9 KiB
C++
128 lines
3.9 KiB
C++
#include "pch.h"
|
|
#include "TestHelpers.h"
|
|
#include <ProcessWaiter.h>
|
|
|
|
using namespace Microsoft::VisualStudio::CppUnitTestFramework;
|
|
using namespace ProcessWaiter;
|
|
|
|
namespace UnitTestsCommonUtils
|
|
{
|
|
TEST_CLASS(ProcessWaiterTests)
|
|
{
|
|
public:
|
|
TEST_METHOD(OnProcessTerminate_InvalidPid_DoesNotCrash)
|
|
{
|
|
std::atomic<bool> called{ false };
|
|
|
|
// Use a very unlikely PID (negative value as string will fail conversion)
|
|
OnProcessTerminate(L"invalid", [&called](DWORD) {
|
|
called = true;
|
|
});
|
|
|
|
// Wait briefly
|
|
std::this_thread::sleep_for(std::chrono::milliseconds(100));
|
|
|
|
// Should not crash, callback may or may not be called depending on implementation
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
TEST_METHOD(OnProcessTerminate_NonExistentPid_DoesNotCrash)
|
|
{
|
|
std::atomic<bool> called{ false };
|
|
|
|
// Use a PID that likely doesn't exist
|
|
OnProcessTerminate(L"999999999", [&called](DWORD) {
|
|
called = true;
|
|
});
|
|
|
|
// Wait briefly
|
|
std::this_thread::sleep_for(std::chrono::milliseconds(100));
|
|
|
|
// Should not crash
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
TEST_METHOD(OnProcessTerminate_ZeroPid_DoesNotCrash)
|
|
{
|
|
std::atomic<bool> called{ false };
|
|
|
|
OnProcessTerminate(L"0", [&called](DWORD) {
|
|
called = true;
|
|
});
|
|
|
|
std::this_thread::sleep_for(std::chrono::milliseconds(100));
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
TEST_METHOD(OnProcessTerminate_CurrentProcessPid_DoesNotTerminate)
|
|
{
|
|
std::atomic<bool> called{ false };
|
|
|
|
// Use current process PID - it shouldn't terminate during test
|
|
std::wstring pid = std::to_wstring(GetCurrentProcessId());
|
|
|
|
OnProcessTerminate(pid, [&called](DWORD) {
|
|
called = true;
|
|
});
|
|
|
|
// Wait briefly - current process should not terminate
|
|
std::this_thread::sleep_for(std::chrono::milliseconds(200));
|
|
|
|
// Callback should not have been called since process is still running
|
|
Assert::IsFalse(called);
|
|
}
|
|
|
|
TEST_METHOD(OnProcessTerminate_EmptyCallback_DoesNotCrash)
|
|
{
|
|
// Test with an empty function
|
|
OnProcessTerminate(L"999999999", std::function<void(DWORD)>());
|
|
|
|
std::this_thread::sleep_for(std::chrono::milliseconds(100));
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
TEST_METHOD(OnProcessTerminate_MultipleCallsForSamePid_DoesNotCrash)
|
|
{
|
|
std::atomic<int> counter{ 0 };
|
|
std::wstring pid = std::to_wstring(GetCurrentProcessId());
|
|
|
|
// Multiple waits on same (running) process
|
|
for (int i = 0; i < 5; ++i)
|
|
{
|
|
OnProcessTerminate(pid, [&counter](DWORD) {
|
|
counter++;
|
|
});
|
|
}
|
|
|
|
std::this_thread::sleep_for(std::chrono::milliseconds(200));
|
|
|
|
// None should have been called since process is running
|
|
Assert::AreEqual(0, counter.load());
|
|
}
|
|
|
|
TEST_METHOD(OnProcessTerminate_NegativeNumberString_DoesNotCrash)
|
|
{
|
|
std::atomic<bool> called{ false };
|
|
|
|
OnProcessTerminate(L"-1", [&called](DWORD) {
|
|
called = true;
|
|
});
|
|
|
|
std::this_thread::sleep_for(std::chrono::milliseconds(100));
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
TEST_METHOD(OnProcessTerminate_LargeNumber_DoesNotCrash)
|
|
{
|
|
std::atomic<bool> called{ false };
|
|
|
|
OnProcessTerminate(L"18446744073709551615", [&called](DWORD) {
|
|
called = true;
|
|
});
|
|
|
|
std::this_thread::sleep_for(std::chrono::milliseconds(100));
|
|
Assert::IsTrue(true);
|
|
}
|
|
};
|
|
}
|