mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-04-04 10:16:24 +02:00
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Add backup settings for the Hosts File Editor to allow users to customize the existing hardcoded logic. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] **Closes:** #37666 - [ ] **Communication:** I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected - [x] **Tests:** Added/updated and all pass - [ ] **Localization:** All end user facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [x] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: https://github.com/MicrosoftDocs/windows-dev-docs/pull/5342 <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <img width="707" alt="image" src="https://github.com/user-attachments/assets/e114431e-60e0-4b8c-bba7-df23f7af0182" /> <img width="707" alt="image" src="https://github.com/user-attachments/assets/a02b591e-eb46-4964-bee7-548ec175b3aa" /> <img width="707" alt="image" src="https://github.com/user-attachments/assets/6eb0ff21-74fa-4229-8832-df2df877b5cd" /> <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed - Backup on: verified that backup isn't executed - Backups off: Verified that only one backup is executed - Verified that backup is located in the expected path - Auto delete is set to "never": verified that no backups are deleted - Auto delete is set to "based on count": verified that backups are deleted according to count value - Auto delete is set to "based on age and count": verified that backups are deleted according to days and count values - Verified that files without the backup pattern aren't deleted - There is also adequate test coverage for these scenarios 🚀 --------- Co-authored-by: Gordon Lam (SH) <yeelam@microsoft.com>
100 lines
3.6 KiB
C#
100 lines
3.6 KiB
C#
// Copyright (c) Microsoft Corporation
|
||
// The Microsoft Corporation licenses this file to you under the MIT license.
|
||
// See the LICENSE file in the project root for more information.
|
||
using System.Text.RegularExpressions;
|
||
|
||
using Hosts.Tests.Mocks;
|
||
using HostsUILib.Helpers;
|
||
using HostsUILib.Models;
|
||
using HostsUILib.Settings;
|
||
using Moq;
|
||
|
||
namespace Hosts.FuzzTests
|
||
{
|
||
public class FuzzTests
|
||
{
|
||
private static Mock<IUserSettings> _userSettings;
|
||
private static Mock<IElevationHelper> _elevationHelper;
|
||
private static Mock<IBackupManager> _backupManager;
|
||
|
||
// Case1: Fuzzing method for ValidIPv4
|
||
public static void FuzzValidIPv4(ReadOnlySpan<byte> input)
|
||
{
|
||
try
|
||
{
|
||
string address = System.Text.Encoding.UTF8.GetString(input);
|
||
bool isValid = ValidationHelper.ValidIPv4(address);
|
||
}
|
||
catch (Exception ex) when (ex is RegexMatchTimeoutException)
|
||
{
|
||
throw;
|
||
}
|
||
}
|
||
|
||
// Case2: fuzzing method for ValidIPv6
|
||
public static void FuzzValidIPv6(ReadOnlySpan<byte> input)
|
||
{
|
||
try
|
||
{
|
||
string address = System.Text.Encoding.UTF8.GetString(input);
|
||
bool isValid = ValidationHelper.ValidIPv6(address);
|
||
}
|
||
catch (Exception ex) when (ex is RegexMatchTimeoutException)
|
||
{
|
||
throw;
|
||
}
|
||
}
|
||
|
||
// Case3: fuzzing method for ValidHosts
|
||
public static void FuzzValidHosts(ReadOnlySpan<byte> input)
|
||
{
|
||
try
|
||
{
|
||
string hosts = System.Text.Encoding.UTF8.GetString(input);
|
||
bool isValid = ValidationHelper.ValidHosts(hosts, true);
|
||
}
|
||
catch (Exception ex) when (ex is RegexMatchTimeoutException)
|
||
{
|
||
// It's important to filter out any *expected* exceptions from our code here.
|
||
// However, catching all exceptions is considered an anti-pattern because it may suppress legitimate
|
||
// issues, such as a NullReferenceException thrown by our code. In this case, we still re-throw
|
||
// the exception, as the ToJsonFromXmlOrCsvAsync method is not expected to throw any exceptions.
|
||
throw;
|
||
}
|
||
}
|
||
|
||
public static void FuzzWriteAsync(ReadOnlySpan<byte> data)
|
||
{
|
||
try
|
||
{
|
||
_userSettings = new Mock<IUserSettings>();
|
||
_elevationHelper = new Mock<IElevationHelper>();
|
||
_elevationHelper.Setup(m => m.IsElevated).Returns(true);
|
||
_backupManager = new Mock<IBackupManager>();
|
||
|
||
var fileSystem = new CustomMockFileSystem();
|
||
var service = new HostsService(fileSystem, _userSettings.Object, _elevationHelper.Object, _backupManager.Object);
|
||
|
||
string input = System.Text.Encoding.UTF8.GetString(data);
|
||
|
||
// Since the WriteAsync method does not involve content parsing, we won't fuzz the additionalLines in the hosts file.
|
||
string additionalLines = " ";
|
||
string hosts = input;
|
||
string address = input;
|
||
string comments = input;
|
||
var entries = new List<Entry>
|
||
{
|
||
new Entry(1, hosts, address, comments, true),
|
||
};
|
||
|
||
// fuzzing WriteAsync
|
||
_ = Task.Run(async () => await service.WriteAsync(additionalLines, entries));
|
||
}
|
||
catch (Exception ex) when (ex is ArgumentException)
|
||
{
|
||
throw;
|
||
}
|
||
}
|
||
}
|
||
}
|