mirror of
https://github.com/microsoft/PowerToys.git
synced 2025-12-15 19:27:56 +01:00
837d5ca543
## Summary This PR fixes the signing pipeline by removing 25 obsolete file references from `ESRPSigning_core.json` that were causing "0 files out of: 0 files" errors during the signing process. These references pointed to files that are either no longer built or were never produced by the current project structure. ## Root Cause Analysis The signing configuration contained references to files that fall into three categories: 1. **Static libraries incorrectly listed as DLLs** - Projects configured as `StaticLibrary` don't produce `.dll` files 2. **Obsolete/non-existent projects** - References to projects that were removed or renamed 3. **WinExe projects incorrectly listed as producing DLLs** - C# projects with `OutputType=WinExe` only produce `.exe` files, not `.dll` files ## Changes Made ### Static Libraries (3 files removed): - `Notifications.dll` - notifications project is a StaticLibrary - `os-detection.dll` - no corresponding project found - `Telemetry.dll` - telemetry projects are StaticLibraries ### Obsolete Projects (3 files removed): - `fancyzones.dll` - FancyZones now produces `PowerToys.FancyZones.exe` - `Wox.dll` - only `Wox.Plugin.dll` and `Wox.Infrastructure.dll` exist - Duplicate `PowerToys.ManagedTelemetry.dll` entry ### WinExe Projects (19 files removed): **Preview/Thumbnail Handlers (11 files):** All preview and thumbnail handler C# projects have `OutputType=WinExe` and only produce `.exe` files: - Removed `.dll` entries for: GcodePreviewHandler, MarkdownPreviewHandler, MonacoPreviewHandler, PdfPreviewHandler, QoiPreviewHandler, SvgPreviewHandler, GcodeThumbnailProvider, PdfThumbnailProvider, QoiThumbnailProvider, StlThumbnailProvider, SvgThumbnailProvider **Application Modules (8 files):** - `PowerToys.WorkspacesEditor.dll` and `PowerToys.WorkspacesLauncherUI.dll` - `PowerToys.Awake.dll` and `PowerToys.ImageResizer.dll` - `PowerToys.ColorPickerUI.dll` and `PowerToys.PowerOCR.dll` - `PowerToys.PowerAccent.dll` and `PowerToys.PowerLauncher.dll` ## Verification All removed entries were verified by: 1. Checking project files for `OutputType` and `ConfigurationType` settings 2. Confirming `AssemblyName` and `TargetName` properties 3. Ensuring no actual built artifacts are affected The signing process should now successfully find all expected files and eliminate the "0 files out of: 0 files" pattern. Fixes #40240. <!-- START COPILOT CODING AGENT TIPS --> --- 💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click [here](https://survey.alchemer.com/s3/8343779/Copilot-Coding-agent) to start the survey. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: vanzue <69313318+vanzue@users.noreply.github.com>