mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-04-05 10:46:33 +02:00
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request This PR removes the ISettingsUtils and ISettingsPath interfaces to reduce some complexity. They only existed so the classes can be used with moq. But this is also possible by using virtual methods which is cleaner. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] Closes: #xxx <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [x] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx
228 lines
10 KiB
C#
228 lines
10 KiB
C#
// Copyright (c) Microsoft Corporation
|
|
// The Microsoft Corporation licenses this file to you under the MIT license.
|
|
// See the LICENSE file in the project root for more information.
|
|
|
|
using System;
|
|
using System.Text.Json;
|
|
|
|
using Microsoft.PowerToys.Settings.UI.Library;
|
|
using Microsoft.PowerToys.Settings.UI.UnitTests.BackwardsCompatibility;
|
|
using Microsoft.PowerToys.Settings.UI.UnitTests.Mocks;
|
|
using Microsoft.PowerToys.Settings.UI.ViewModels;
|
|
using Microsoft.VisualStudio.TestTools.UnitTesting;
|
|
using Moq;
|
|
|
|
namespace ViewModelTests
|
|
{
|
|
[TestClass]
|
|
public class PowerRename
|
|
{
|
|
public const string GeneralSettingsFileName = "Test\\PowerRename";
|
|
|
|
private Mock<SettingsUtils> mockGeneralSettingsUtils;
|
|
|
|
private Mock<SettingsUtils> mockPowerRenamePropertiesUtils;
|
|
|
|
[TestInitialize]
|
|
public void SetUpStubSettingUtils()
|
|
{
|
|
mockGeneralSettingsUtils = ISettingsUtilsMocks.GetStubSettingsUtils<GeneralSettings>();
|
|
mockPowerRenamePropertiesUtils = ISettingsUtilsMocks.GetStubSettingsUtils<PowerRenameLocalProperties>();
|
|
}
|
|
|
|
/// <summary>
|
|
/// Test if the original settings files were modified.
|
|
/// </summary>
|
|
[TestMethod]
|
|
[DataRow("v0.18.2", "power-rename-settings.json")]
|
|
[DataRow("v0.19.2", "power-rename-settings.json")]
|
|
[DataRow("v0.20.1", "power-rename-settings.json")]
|
|
[DataRow("v0.22.0", "power-rename-settings.json")]
|
|
public void OriginalFilesModificationTest(string version, string fileName)
|
|
{
|
|
var settingPathMock = new Mock<SettingPath>();
|
|
var mockIOProvider = BackCompatTestProperties.GetModuleIOProvider(version, PowerRenameSettings.ModuleName, fileName);
|
|
|
|
var mockSettingsUtils = new SettingsUtils(mockIOProvider.Object, settingPathMock.Object);
|
|
PowerRenameLocalProperties originalSettings = mockSettingsUtils.GetSettingsOrDefault<PowerRenameLocalProperties>(PowerRenameSettings.ModuleName);
|
|
|
|
var mockGeneralIOProvider = BackCompatTestProperties.GetGeneralSettingsIOProvider(version);
|
|
|
|
var mockGeneralSettingsUtils = new SettingsUtils(mockGeneralIOProvider.Object, settingPathMock.Object);
|
|
GeneralSettings originalGeneralSettings = mockGeneralSettingsUtils.GetSettingsOrDefault<GeneralSettings>();
|
|
var generalSettingsRepository = new BackCompatTestProperties.MockSettingsRepository<GeneralSettings>(mockGeneralSettingsUtils);
|
|
|
|
// Initialise View Model with test Config files
|
|
Func<string, int> sendMockIPCConfigMSG = msg => { return 0; };
|
|
PowerRenameViewModel viewModel = new PowerRenameViewModel(mockSettingsUtils, generalSettingsRepository, sendMockIPCConfigMSG);
|
|
|
|
// Verify that the old settings persisted
|
|
Assert.AreEqual(originalGeneralSettings.Enabled.PowerRename, viewModel.IsEnabled);
|
|
Assert.AreEqual(originalSettings.ExtendedContextMenuOnly, viewModel.EnabledOnContextExtendedMenu);
|
|
Assert.AreEqual(originalSettings.MRUEnabled, viewModel.MRUEnabled);
|
|
Assert.AreEqual(originalSettings.ShowIcon, viewModel.EnabledOnContextMenu);
|
|
|
|
// Verify that the stub file was used
|
|
var expectedCallCount = 2; // once via the view model, and once by the test (GetSettings<T>)
|
|
BackCompatTestProperties.VerifyModuleIOProviderWasRead(mockIOProvider, PowerRenameSettings.ModuleName, expectedCallCount);
|
|
BackCompatTestProperties.VerifyGeneralSettingsIOProviderWasRead(mockGeneralIOProvider, expectedCallCount);
|
|
}
|
|
|
|
[TestMethod]
|
|
public void IsEnabledShouldEnableModuleWhenSuccessful()
|
|
{
|
|
// Assert
|
|
Func<string, int> sendMockIPCConfigMSG = msg =>
|
|
{
|
|
OutGoingGeneralSettings snd = JsonSerializer.Deserialize<OutGoingGeneralSettings>(msg);
|
|
Assert.IsTrue(snd.GeneralSettings.Enabled.PowerRename);
|
|
return 0;
|
|
};
|
|
|
|
// arrange
|
|
PowerRenameViewModel viewModel = new PowerRenameViewModel(mockPowerRenamePropertiesUtils.Object, SettingsRepository<GeneralSettings>.GetInstance(mockGeneralSettingsUtils.Object), sendMockIPCConfigMSG, GeneralSettingsFileName);
|
|
|
|
// act
|
|
viewModel.IsEnabled = true;
|
|
}
|
|
|
|
[TestMethod]
|
|
public void MRUEnabledShouldSetValue2TrueWhenSuccessful()
|
|
{
|
|
// Assert
|
|
Func<string, int> sendMockIPCConfigMSG = msg =>
|
|
{
|
|
PowerRenameSettingsIPCMessage snd = JsonSerializer.Deserialize<PowerRenameSettingsIPCMessage>(msg);
|
|
Assert.IsTrue(snd.Powertoys.PowerRename.Properties.MRUEnabled.Value);
|
|
return 0;
|
|
};
|
|
|
|
// arrange
|
|
PowerRenameViewModel viewModel = new PowerRenameViewModel(mockPowerRenamePropertiesUtils.Object, SettingsRepository<GeneralSettings>.GetInstance(mockGeneralSettingsUtils.Object), sendMockIPCConfigMSG, GeneralSettingsFileName);
|
|
|
|
// act
|
|
viewModel.MRUEnabled = true;
|
|
}
|
|
|
|
[TestMethod]
|
|
public void WhenIsEnabledIsOffAndMRUEnabledIsOffGlobalAndMruShouldBeOff()
|
|
{
|
|
Func<string, int> sendMockIPCConfigMSG = msg => { return 0; };
|
|
PowerRenameViewModel viewModel = new PowerRenameViewModel(mockPowerRenamePropertiesUtils.Object, SettingsRepository<GeneralSettings>.GetInstance(mockGeneralSettingsUtils.Object), sendMockIPCConfigMSG, GeneralSettingsFileName);
|
|
|
|
viewModel.IsEnabled = false;
|
|
viewModel.MRUEnabled = false;
|
|
|
|
Assert.IsFalse(viewModel.GlobalAndMruEnabled);
|
|
}
|
|
|
|
[TestMethod]
|
|
public void WhenIsEnabledIsOffAndMRUEnabledIsOnGlobalAndMruShouldBeOff()
|
|
{
|
|
Func<string, int> sendMockIPCConfigMSG = msg => { return 0; };
|
|
PowerRenameViewModel viewModel = new PowerRenameViewModel(mockPowerRenamePropertiesUtils.Object, SettingsRepository<GeneralSettings>.GetInstance(mockGeneralSettingsUtils.Object), sendMockIPCConfigMSG, GeneralSettingsFileName);
|
|
|
|
viewModel.IsEnabled = false;
|
|
viewModel.MRUEnabled = true;
|
|
|
|
Assert.IsFalse(viewModel.GlobalAndMruEnabled);
|
|
}
|
|
|
|
[TestMethod]
|
|
public void WhenIsEnabledIsOnAndMRUEnabledIsOffGlobalAndMruShouldBeOff()
|
|
{
|
|
Func<string, int> sendMockIPCConfigMSG = msg => { return 0; };
|
|
PowerRenameViewModel viewModel = new PowerRenameViewModel(mockPowerRenamePropertiesUtils.Object, SettingsRepository<GeneralSettings>.GetInstance(mockGeneralSettingsUtils.Object), sendMockIPCConfigMSG, GeneralSettingsFileName);
|
|
|
|
viewModel.IsEnabled = true;
|
|
viewModel.MRUEnabled = false;
|
|
|
|
Assert.IsFalse(viewModel.GlobalAndMruEnabled);
|
|
}
|
|
|
|
[TestMethod]
|
|
public void WhenIsEnabledIsOnAndMRUEnabledIsOnGlobalAndMruShouldBeOn()
|
|
{
|
|
Func<string, int> sendMockIPCConfigMSG = msg => { return 0; };
|
|
PowerRenameViewModel viewModel = new PowerRenameViewModel(mockPowerRenamePropertiesUtils.Object, SettingsRepository<GeneralSettings>.GetInstance(mockGeneralSettingsUtils.Object), sendMockIPCConfigMSG, GeneralSettingsFileName);
|
|
|
|
viewModel.IsEnabled = true;
|
|
viewModel.MRUEnabled = true;
|
|
|
|
Assert.IsTrue(viewModel.GlobalAndMruEnabled);
|
|
}
|
|
|
|
[TestMethod]
|
|
public void EnabledOnContextMenuShouldSetValue2TrueWhenSuccessful()
|
|
{
|
|
// Assert
|
|
Func<string, int> sendMockIPCConfigMSG = msg =>
|
|
{
|
|
PowerRenameSettingsIPCMessage snd = JsonSerializer.Deserialize<PowerRenameSettingsIPCMessage>(msg);
|
|
Assert.IsTrue(snd.Powertoys.PowerRename.Properties.ShowIcon.Value);
|
|
return 0;
|
|
};
|
|
|
|
// arrange
|
|
PowerRenameViewModel viewModel = new PowerRenameViewModel(mockPowerRenamePropertiesUtils.Object, SettingsRepository<GeneralSettings>.GetInstance(mockGeneralSettingsUtils.Object), sendMockIPCConfigMSG, GeneralSettingsFileName);
|
|
|
|
// act
|
|
viewModel.EnabledOnContextMenu = true;
|
|
}
|
|
|
|
[TestMethod]
|
|
public void EnabledOnContextExtendedMenuShouldSetValue2TrueWhenSuccessful()
|
|
{
|
|
// Assert
|
|
Func<string, int> sendMockIPCConfigMSG = msg =>
|
|
{
|
|
PowerRenameSettingsIPCMessage snd = JsonSerializer.Deserialize<PowerRenameSettingsIPCMessage>(msg);
|
|
Assert.IsTrue(snd.Powertoys.PowerRename.Properties.ShowIcon.Value);
|
|
return 0;
|
|
};
|
|
|
|
// arrange
|
|
PowerRenameViewModel viewModel = new PowerRenameViewModel(mockPowerRenamePropertiesUtils.Object, SettingsRepository<GeneralSettings>.GetInstance(mockGeneralSettingsUtils.Object), sendMockIPCConfigMSG, GeneralSettingsFileName);
|
|
|
|
// act
|
|
viewModel.EnabledOnContextMenu = true;
|
|
}
|
|
|
|
[TestMethod]
|
|
public void RestoreFlagsOnLaunchShouldSetValue2TrueWhenSuccessful()
|
|
{
|
|
// Assert
|
|
Func<string, int> sendMockIPCConfigMSG = msg =>
|
|
{
|
|
PowerRenameSettingsIPCMessage snd = JsonSerializer.Deserialize<PowerRenameSettingsIPCMessage>(msg);
|
|
Assert.IsTrue(snd.Powertoys.PowerRename.Properties.PersistState.Value);
|
|
return 0;
|
|
};
|
|
|
|
// arrange
|
|
PowerRenameViewModel viewModel = new PowerRenameViewModel(mockPowerRenamePropertiesUtils.Object, SettingsRepository<GeneralSettings>.GetInstance(mockGeneralSettingsUtils.Object), sendMockIPCConfigMSG, GeneralSettingsFileName);
|
|
|
|
// act
|
|
viewModel.RestoreFlagsOnLaunch = true;
|
|
}
|
|
|
|
[TestMethod]
|
|
public void MaxDispListNumShouldSetMaxSuggListTo20WhenSuccessful()
|
|
{
|
|
// Assert
|
|
Func<string, int> sendMockIPCConfigMSG = msg =>
|
|
{
|
|
PowerRenameSettingsIPCMessage snd = JsonSerializer.Deserialize<PowerRenameSettingsIPCMessage>(msg);
|
|
Assert.AreEqual(20, snd.Powertoys.PowerRename.Properties.MaxMRUSize.Value);
|
|
return 0;
|
|
};
|
|
|
|
// arrange
|
|
PowerRenameViewModel viewModel = new PowerRenameViewModel(mockPowerRenamePropertiesUtils.Object, SettingsRepository<GeneralSettings>.GetInstance(mockGeneralSettingsUtils.Object), sendMockIPCConfigMSG, GeneralSettingsFileName);
|
|
|
|
// act
|
|
viewModel.MaxDispListNum = 20;
|
|
}
|
|
}
|
|
}
|