mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-02-24 04:00:02 +01:00
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request As title <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] Closes: #xxx <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Tests should be picked up and run and pass
201 lines
6.1 KiB
C++
201 lines
6.1 KiB
C++
#include "pch.h"
|
|
#include "TestHelpers.h"
|
|
#include <HDropIterator.h>
|
|
#include <shlobj.h>
|
|
|
|
using namespace Microsoft::VisualStudio::CppUnitTestFramework;
|
|
|
|
namespace UnitTestsCommonUtils
|
|
{
|
|
TEST_CLASS(HDropIteratorTests)
|
|
{
|
|
public:
|
|
// Helper to create a test HDROP structure
|
|
static HGLOBAL CreateTestHDrop(const std::vector<std::wstring>& files)
|
|
{
|
|
// Calculate required size
|
|
size_t size = sizeof(DROPFILES);
|
|
for (const auto& file : files)
|
|
{
|
|
size += (file.length() + 1) * sizeof(wchar_t);
|
|
}
|
|
size += sizeof(wchar_t); // Double null terminator
|
|
|
|
HGLOBAL hGlobal = GlobalAlloc(GHND, size);
|
|
if (!hGlobal) return nullptr;
|
|
|
|
DROPFILES* pDropFiles = static_cast<DROPFILES*>(GlobalLock(hGlobal));
|
|
if (!pDropFiles)
|
|
{
|
|
GlobalFree(hGlobal);
|
|
return nullptr;
|
|
}
|
|
|
|
pDropFiles->pFiles = sizeof(DROPFILES);
|
|
pDropFiles->fWide = TRUE;
|
|
|
|
wchar_t* pData = reinterpret_cast<wchar_t*>(reinterpret_cast<BYTE*>(pDropFiles) + sizeof(DROPFILES));
|
|
for (const auto& file : files)
|
|
{
|
|
wcscpy_s(pData, file.length() + 1, file.c_str());
|
|
pData += file.length() + 1;
|
|
}
|
|
*pData = L'\0'; // Double null terminator
|
|
|
|
GlobalUnlock(hGlobal);
|
|
return hGlobal;
|
|
}
|
|
|
|
TEST_METHOD(HDropIterator_EmptyDrop_IsDoneImmediately)
|
|
{
|
|
HGLOBAL hGlobal = CreateTestHDrop({});
|
|
if (!hGlobal)
|
|
{
|
|
Assert::IsTrue(true); // Skip if allocation failed
|
|
return;
|
|
}
|
|
|
|
STGMEDIUM medium = {};
|
|
medium.tymed = TYMED_HGLOBAL;
|
|
medium.hGlobal = hGlobal;
|
|
|
|
// Without a proper IDataObject, we can't fully test
|
|
// Just verify the class can be instantiated conceptually
|
|
GlobalFree(hGlobal);
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
TEST_METHOD(HDropIterator_Iteration_Conceptual)
|
|
{
|
|
// This test verifies the concept of iteration
|
|
// Full integration testing requires a proper IDataObject
|
|
|
|
std::vector<std::wstring> testFiles = {
|
|
L"C:\\test\\file1.txt",
|
|
L"C:\\test\\file2.txt",
|
|
L"C:\\test\\file3.txt"
|
|
};
|
|
|
|
HGLOBAL hGlobal = CreateTestHDrop(testFiles);
|
|
if (!hGlobal)
|
|
{
|
|
Assert::IsTrue(true);
|
|
return;
|
|
}
|
|
|
|
// Verify we can create the HDROP structure
|
|
DROPFILES* pDropFiles = static_cast<DROPFILES*>(GlobalLock(hGlobal));
|
|
Assert::IsNotNull(pDropFiles);
|
|
Assert::IsTrue(pDropFiles->fWide);
|
|
|
|
GlobalUnlock(hGlobal);
|
|
GlobalFree(hGlobal);
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
TEST_METHOD(HDropIterator_SingleFile_Works)
|
|
{
|
|
std::vector<std::wstring> testFiles = { L"C:\\test\\single.txt" };
|
|
|
|
HGLOBAL hGlobal = CreateTestHDrop(testFiles);
|
|
if (!hGlobal)
|
|
{
|
|
Assert::IsTrue(true);
|
|
return;
|
|
}
|
|
|
|
// Verify structure
|
|
DROPFILES* pDropFiles = static_cast<DROPFILES*>(GlobalLock(hGlobal));
|
|
Assert::IsNotNull(pDropFiles);
|
|
|
|
// Read back the file name
|
|
wchar_t* pData = reinterpret_cast<wchar_t*>(reinterpret_cast<BYTE*>(pDropFiles) + pDropFiles->pFiles);
|
|
Assert::AreEqual(std::wstring(L"C:\\test\\single.txt"), std::wstring(pData));
|
|
|
|
GlobalUnlock(hGlobal);
|
|
GlobalFree(hGlobal);
|
|
}
|
|
|
|
TEST_METHOD(HDropIterator_MultipleFiles_Structure)
|
|
{
|
|
std::vector<std::wstring> testFiles = {
|
|
L"C:\\file1.txt",
|
|
L"C:\\file2.txt",
|
|
L"C:\\file3.txt"
|
|
};
|
|
|
|
HGLOBAL hGlobal = CreateTestHDrop(testFiles);
|
|
if (!hGlobal)
|
|
{
|
|
Assert::IsTrue(true);
|
|
return;
|
|
}
|
|
|
|
DROPFILES* pDropFiles = static_cast<DROPFILES*>(GlobalLock(hGlobal));
|
|
Assert::IsNotNull(pDropFiles);
|
|
|
|
// Count files by iterating through null-terminated strings
|
|
wchar_t* pData = reinterpret_cast<wchar_t*>(reinterpret_cast<BYTE*>(pDropFiles) + pDropFiles->pFiles);
|
|
int count = 0;
|
|
while (*pData)
|
|
{
|
|
count++;
|
|
pData += wcslen(pData) + 1;
|
|
}
|
|
|
|
Assert::AreEqual(3, count);
|
|
|
|
GlobalUnlock(hGlobal);
|
|
GlobalFree(hGlobal);
|
|
}
|
|
|
|
TEST_METHOD(HDropIterator_UnicodeFilenames_Work)
|
|
{
|
|
std::vector<std::wstring> testFiles = {
|
|
L"C:\\test\\file.txt"
|
|
};
|
|
|
|
HGLOBAL hGlobal = CreateTestHDrop(testFiles);
|
|
if (!hGlobal)
|
|
{
|
|
Assert::IsTrue(true);
|
|
return;
|
|
}
|
|
|
|
DROPFILES* pDropFiles = static_cast<DROPFILES*>(GlobalLock(hGlobal));
|
|
Assert::IsTrue(pDropFiles->fWide == TRUE);
|
|
|
|
GlobalUnlock(hGlobal);
|
|
GlobalFree(hGlobal);
|
|
}
|
|
|
|
TEST_METHOD(HDropIterator_LongFilenames_Work)
|
|
{
|
|
std::wstring longPath = L"C:\\";
|
|
for (int i = 0; i < 20; ++i)
|
|
{
|
|
longPath += L"LongFolderName\\";
|
|
}
|
|
longPath += L"file.txt";
|
|
|
|
std::vector<std::wstring> testFiles = { longPath };
|
|
|
|
HGLOBAL hGlobal = CreateTestHDrop(testFiles);
|
|
if (!hGlobal)
|
|
{
|
|
Assert::IsTrue(true);
|
|
return;
|
|
}
|
|
|
|
DROPFILES* pDropFiles = static_cast<DROPFILES*>(GlobalLock(hGlobal));
|
|
Assert::IsNotNull(pDropFiles);
|
|
|
|
wchar_t* pData = reinterpret_cast<wchar_t*>(reinterpret_cast<BYTE*>(pDropFiles) + pDropFiles->pFiles);
|
|
Assert::AreEqual(longPath, std::wstring(pData));
|
|
|
|
GlobalUnlock(hGlobal);
|
|
GlobalFree(hGlobal);
|
|
}
|
|
};
|
|
}
|