mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-02-23 19:49:43 +01:00
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request As title <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] Closes: #xxx <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Tests should be picked up and run and pass
181 lines
5.7 KiB
C++
181 lines
5.7 KiB
C++
#include "pch.h"
|
|
#include "TestHelpers.h"
|
|
#include <package.h>
|
|
|
|
using namespace Microsoft::VisualStudio::CppUnitTestFramework;
|
|
using namespace package;
|
|
|
|
namespace UnitTestsCommonUtils
|
|
{
|
|
TEST_CLASS(PackageTests)
|
|
{
|
|
public:
|
|
// IsWin11OrGreater tests
|
|
TEST_METHOD(IsWin11OrGreater_ReturnsBoolean)
|
|
{
|
|
bool result = IsWin11OrGreater();
|
|
Assert::IsTrue(result == true || result == false);
|
|
}
|
|
|
|
TEST_METHOD(IsWin11OrGreater_ConsistentResults)
|
|
{
|
|
bool result1 = IsWin11OrGreater();
|
|
bool result2 = IsWin11OrGreater();
|
|
bool result3 = IsWin11OrGreater();
|
|
|
|
Assert::AreEqual(result1, result2);
|
|
Assert::AreEqual(result2, result3);
|
|
}
|
|
|
|
// PACKAGE_VERSION struct tests
|
|
TEST_METHOD(PackageVersion_DefaultConstruction)
|
|
{
|
|
PACKAGE_VERSION version{};
|
|
Assert::AreEqual(static_cast<UINT16>(0), version.Major);
|
|
Assert::AreEqual(static_cast<UINT16>(0), version.Minor);
|
|
Assert::AreEqual(static_cast<UINT16>(0), version.Build);
|
|
Assert::AreEqual(static_cast<UINT16>(0), version.Revision);
|
|
}
|
|
|
|
TEST_METHOD(PackageVersion_Assignment)
|
|
{
|
|
PACKAGE_VERSION version{};
|
|
version.Major = 1;
|
|
version.Minor = 2;
|
|
version.Build = 3;
|
|
version.Revision = 4;
|
|
|
|
Assert::AreEqual(static_cast<UINT16>(1), version.Major);
|
|
Assert::AreEqual(static_cast<UINT16>(2), version.Minor);
|
|
Assert::AreEqual(static_cast<UINT16>(3), version.Build);
|
|
Assert::AreEqual(static_cast<UINT16>(4), version.Revision);
|
|
}
|
|
|
|
// ComInitializer tests
|
|
TEST_METHOD(ComInitializer_InitializesAndUninitializesCom)
|
|
{
|
|
{
|
|
ComInitializer comInit;
|
|
// COM should be initialized within this scope
|
|
}
|
|
// COM should be uninitialized after scope
|
|
|
|
// Verify we can initialize again
|
|
{
|
|
ComInitializer comInit2;
|
|
}
|
|
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
TEST_METHOD(ComInitializer_MultipleInstances)
|
|
{
|
|
ComInitializer init1;
|
|
ComInitializer init2;
|
|
ComInitializer init3;
|
|
|
|
// Multiple initializations should work (COM uses reference counting)
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
// GetRegisteredPackage tests
|
|
TEST_METHOD(GetRegisteredPackage_NonExistentPackage_ReturnsEmpty)
|
|
{
|
|
auto result = GetRegisteredPackage(L"NonExistentPackage12345", false);
|
|
|
|
// Should return empty for non-existent package
|
|
Assert::IsFalse(result.has_value());
|
|
}
|
|
|
|
TEST_METHOD(GetRegisteredPackage_EmptyName_DoesNotCrash)
|
|
{
|
|
auto result = GetRegisteredPackage(L"", false);
|
|
// Behavior may vary based on package enumeration; just ensure it doesn't crash.
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
// IsPackageRegisteredWithPowerToysVersion tests
|
|
TEST_METHOD(IsPackageRegisteredWithPowerToysVersion_NonExistentPackage_ReturnsFalse)
|
|
{
|
|
bool result = IsPackageRegisteredWithPowerToysVersion(L"NonExistentPackage12345");
|
|
Assert::IsFalse(result);
|
|
}
|
|
|
|
TEST_METHOD(IsPackageRegisteredWithPowerToysVersion_EmptyName_ReturnsFalse)
|
|
{
|
|
bool result = IsPackageRegisteredWithPowerToysVersion(L"");
|
|
Assert::IsFalse(result);
|
|
}
|
|
|
|
// FindMsixFile tests
|
|
TEST_METHOD(FindMsixFile_NonExistentDirectory_ReturnsEmpty)
|
|
{
|
|
auto result = FindMsixFile(L"C:\\NonExistentDirectory12345", false);
|
|
Assert::IsTrue(result.empty());
|
|
}
|
|
|
|
TEST_METHOD(FindMsixFile_SystemDirectory_DoesNotCrash)
|
|
{
|
|
// System32 probably doesn't have MSIX files, but shouldn't crash
|
|
auto result = FindMsixFile(L"C:\\Windows\\System32", false);
|
|
// May or may not find files, but should not crash
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
TEST_METHOD(FindMsixFile_RecursiveSearch_DoesNotCrash)
|
|
{
|
|
// Use temp directory which should exist
|
|
wchar_t tempPath[MAX_PATH];
|
|
GetTempPathW(MAX_PATH, tempPath);
|
|
|
|
auto result = FindMsixFile(tempPath, true);
|
|
// May or may not find files, but should not crash
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
// GetPackageNameAndVersionFromAppx tests
|
|
TEST_METHOD(GetPackageNameAndVersionFromAppx_NonExistentFile_ReturnsFalse)
|
|
{
|
|
std::wstring name;
|
|
PACKAGE_VERSION version{};
|
|
|
|
bool result = GetPackageNameAndVersionFromAppx(L"C:\\NonExistent\\file.msix", name, version);
|
|
Assert::IsFalse(result);
|
|
}
|
|
|
|
TEST_METHOD(GetPackageNameAndVersionFromAppx_EmptyPath_ReturnsFalse)
|
|
{
|
|
std::wstring name;
|
|
PACKAGE_VERSION version{};
|
|
|
|
bool result = GetPackageNameAndVersionFromAppx(L"", name, version);
|
|
Assert::IsFalse(result);
|
|
}
|
|
|
|
// Thread safety
|
|
TEST_METHOD(IsWin11OrGreater_ThreadSafe)
|
|
{
|
|
std::vector<std::thread> threads;
|
|
std::atomic<int> successCount{ 0 };
|
|
|
|
for (int i = 0; i < 10; ++i)
|
|
{
|
|
threads.emplace_back([&successCount]() {
|
|
for (int j = 0; j < 10; ++j)
|
|
{
|
|
IsWin11OrGreater();
|
|
successCount++;
|
|
}
|
|
});
|
|
}
|
|
|
|
for (auto& t : threads)
|
|
{
|
|
t.join();
|
|
}
|
|
|
|
Assert::AreEqual(100, successCount.load());
|
|
}
|
|
};
|
|
}
|