mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-04-03 17:56:44 +02:00
Both `TopLevelCommandItemWrapper` and `TopLevelViewModel` were really the same thing. The latter was from an earlier prototype, and the former is a more correct, safer abstraction. We really should have only ever used the former, but alas, we only used it for the SUI, and it piggy-backed off the latter, and that meant the latter's bugs became the former's. tldr: I made the icon access safe in the SUI. And while I was doing this, because we now have a cleaner VM abstraction here in the host, we can actually cleanly disable extensions, because the `CommandProviderWrapper` knows which `ViewModel`s it made. Closes https://github.com/zadjii-msft/PowerToys/issues/426 Closes https://github.com/zadjii-msft/PowerToys/issues/478 Closes https://github.com/zadjii-msft/PowerToys/issues/577
58 lines
1.8 KiB
C#
58 lines
1.8 KiB
C#
// Copyright (c) Microsoft Corporation
|
|
// The Microsoft Corporation licenses this file to you under the MIT license.
|
|
// See the LICENSE file in the project root for more information.
|
|
|
|
using CommunityToolkit.Mvvm.ComponentModel;
|
|
using Microsoft.CmdPal.UI.ViewModels.Models;
|
|
using Microsoft.CommandPalette.Extensions;
|
|
|
|
namespace Microsoft.CmdPal.UI.ViewModels;
|
|
|
|
public partial class IconInfoViewModel : ObservableObject, IIconInfo
|
|
{
|
|
private readonly ExtensionObject<IIconInfo> _model = new(null);
|
|
|
|
// These are properties that are "observable" from the extension object
|
|
// itself, in the sense that they get raised by PropChanged events from the
|
|
// extension. However, we don't want to actually make them
|
|
// [ObservableProperty]s, because PropChanged comes in off the UI thread,
|
|
// and ObservableProperty is not smart enough to raise the PropertyChanged
|
|
// on the UI thread.
|
|
public IconDataViewModel Light { get; private set; }
|
|
|
|
public IconDataViewModel Dark { get; private set; }
|
|
|
|
public IconDataViewModel IconForTheme(bool light) => Light = light ? Light : Dark;
|
|
|
|
public bool HasIcon(bool light) => IconForTheme(light).HasIcon;
|
|
|
|
public bool IsSet => _model.Unsafe != null;
|
|
|
|
IIconData? IIconInfo.Dark => Dark;
|
|
|
|
IIconData? IIconInfo.Light => Light;
|
|
|
|
public IconInfoViewModel(IIconInfo? icon)
|
|
{
|
|
_model = new(icon);
|
|
Light = new(null);
|
|
Dark = new(null);
|
|
}
|
|
|
|
// Unsafe, needs to be called on BG thread
|
|
public void InitializeProperties()
|
|
{
|
|
var model = _model.Unsafe;
|
|
if (model == null)
|
|
{
|
|
return;
|
|
}
|
|
|
|
Light = new(model.Light);
|
|
Light.InitializeProperties();
|
|
|
|
Dark = new(model.Dark);
|
|
Dark.InitializeProperties();
|
|
}
|
|
}
|