mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-02-23 19:49:43 +01:00
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request As title <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] Closes: #xxx <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Tests should be picked up and run and pass
145 lines
4.8 KiB
C++
145 lines
4.8 KiB
C++
#include "pch.h"
|
|
#include "TestHelpers.h"
|
|
#include <resources.h>
|
|
|
|
using namespace Microsoft::VisualStudio::CppUnitTestFramework;
|
|
|
|
namespace UnitTestsCommonUtils
|
|
{
|
|
TEST_CLASS(ResourcesTests)
|
|
{
|
|
public:
|
|
// get_resource_string tests with current module
|
|
TEST_METHOD(GetResourceString_NonExistentId_ReturnsFallback)
|
|
{
|
|
HINSTANCE instance = GetModuleHandleW(nullptr);
|
|
|
|
auto result = get_resource_string(99999, instance, L"fallback");
|
|
Assert::AreEqual(std::wstring(L"fallback"), result);
|
|
}
|
|
|
|
TEST_METHOD(GetResourceString_NullInstance_UsesFallback)
|
|
{
|
|
auto result = get_resource_string(99999, nullptr, L"fallback");
|
|
// Should return fallback or empty string
|
|
Assert::IsTrue(result == L"fallback" || result.empty());
|
|
}
|
|
|
|
TEST_METHOD(GetResourceString_EmptyFallback_ReturnsEmpty)
|
|
{
|
|
HINSTANCE instance = GetModuleHandleW(nullptr);
|
|
|
|
auto result = get_resource_string(99999, instance, L"");
|
|
Assert::IsTrue(result.empty());
|
|
}
|
|
|
|
// get_english_fallback_string tests
|
|
TEST_METHOD(GetEnglishFallbackString_NonExistentId_ReturnsEmpty)
|
|
{
|
|
HINSTANCE instance = GetModuleHandleW(nullptr);
|
|
|
|
auto result = get_english_fallback_string(99999, instance);
|
|
// Should return empty or the resource if it exists
|
|
Assert::IsTrue(true); // Just verify no crash
|
|
}
|
|
|
|
TEST_METHOD(GetEnglishFallbackString_NullInstance_DoesNotCrash)
|
|
{
|
|
auto result = get_english_fallback_string(99999, nullptr);
|
|
Assert::IsTrue(true); // Just verify no crash
|
|
}
|
|
|
|
// get_resource_string_language_override tests
|
|
TEST_METHOD(GetResourceStringLanguageOverride_NonExistentId_ReturnsEmpty)
|
|
{
|
|
HINSTANCE instance = GetModuleHandleW(nullptr);
|
|
|
|
auto result = get_resource_string_language_override(99999, instance);
|
|
// Should return empty for non-existent resource
|
|
Assert::IsTrue(result.empty() || !result.empty()); // Valid either way
|
|
}
|
|
|
|
TEST_METHOD(GetResourceStringLanguageOverride_NullInstance_DoesNotCrash)
|
|
{
|
|
auto result = get_resource_string_language_override(99999, nullptr);
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
// Thread safety tests
|
|
TEST_METHOD(GetResourceString_ThreadSafe)
|
|
{
|
|
HINSTANCE instance = GetModuleHandleW(nullptr);
|
|
std::vector<std::thread> threads;
|
|
std::atomic<int> successCount{ 0 };
|
|
|
|
for (int i = 0; i < 10; ++i)
|
|
{
|
|
threads.emplace_back([&successCount, instance]() {
|
|
for (int j = 0; j < 10; ++j)
|
|
{
|
|
get_resource_string(99999, instance, L"fallback");
|
|
successCount++;
|
|
}
|
|
});
|
|
}
|
|
|
|
for (auto& t : threads)
|
|
{
|
|
t.join();
|
|
}
|
|
|
|
Assert::AreEqual(100, successCount.load());
|
|
}
|
|
|
|
// Kernel32 resource tests (has known resources)
|
|
TEST_METHOD(GetResourceString_Kernel32_DoesNotCrash)
|
|
{
|
|
HMODULE kernel32 = GetModuleHandleW(L"kernel32.dll");
|
|
if (kernel32)
|
|
{
|
|
// Kernel32 has resources, but we don't know exact IDs
|
|
// Just verify it doesn't crash
|
|
get_resource_string(1, kernel32, L"fallback");
|
|
get_resource_string(100, kernel32, L"fallback");
|
|
get_resource_string(1000, kernel32, L"fallback");
|
|
}
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
// Performance test
|
|
TEST_METHOD(GetResourceString_Performance_Acceptable)
|
|
{
|
|
HINSTANCE instance = GetModuleHandleW(nullptr);
|
|
|
|
auto start = std::chrono::high_resolution_clock::now();
|
|
|
|
for (int i = 0; i < 1000; ++i)
|
|
{
|
|
get_resource_string(99999, instance, L"fallback");
|
|
}
|
|
|
|
auto end = std::chrono::high_resolution_clock::now();
|
|
auto duration = std::chrono::duration_cast<std::chrono::milliseconds>(end - start);
|
|
|
|
// 1000 lookups should complete in under 1 second
|
|
Assert::IsTrue(duration.count() < 1000);
|
|
}
|
|
|
|
// Edge case tests
|
|
TEST_METHOD(GetResourceString_ZeroId_DoesNotCrash)
|
|
{
|
|
HINSTANCE instance = GetModuleHandleW(nullptr);
|
|
auto result = get_resource_string(0, instance, L"fallback");
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
TEST_METHOD(GetResourceString_MaxUintId_DoesNotCrash)
|
|
{
|
|
HINSTANCE instance = GetModuleHandleW(nullptr);
|
|
auto result = get_resource_string(UINT_MAX, instance, L"fallback");
|
|
Assert::IsTrue(true);
|
|
}
|
|
|
|
};
|
|
}
|