mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-04-03 01:36:31 +02:00
## Summary of the Pull Request This PR makes RDP fallback non-global by default. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] Closes: #xxx <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed
69 lines
2.1 KiB
C#
69 lines
2.1 KiB
C#
// Copyright (c) Microsoft Corporation
|
|
// The Microsoft Corporation licenses this file to you under the MIT license.
|
|
// See the LICENSE file in the project root for more information.
|
|
|
|
using System.Text.Json.Serialization;
|
|
|
|
namespace Microsoft.CmdPal.UI.ViewModels;
|
|
|
|
public class ProviderSettings
|
|
{
|
|
// List of built-in fallbacks that should not have global results enabled by default
|
|
private readonly string[] _excludedBuiltInFallbacks = [
|
|
"com.microsoft.cmdpal.builtin.indexer.fallback",
|
|
"com.microsoft.cmdpal.builtin.calculator.fallback",
|
|
"com.microsoft.cmdpal.builtin.remotedesktop.fallback",
|
|
];
|
|
|
|
public bool IsEnabled { get; set; } = true;
|
|
|
|
public Dictionary<string, FallbackSettings> FallbackCommands { get; set; } = new();
|
|
|
|
public List<string> PinnedCommandIds { get; set; } = [];
|
|
|
|
[JsonIgnore]
|
|
public string ProviderDisplayName { get; set; } = string.Empty;
|
|
|
|
[JsonIgnore]
|
|
public string ProviderId { get; private set; } = string.Empty;
|
|
|
|
[JsonIgnore]
|
|
public bool IsBuiltin { get; private set; }
|
|
|
|
public ProviderSettings(CommandProviderWrapper wrapper)
|
|
{
|
|
Connect(wrapper);
|
|
}
|
|
|
|
[JsonConstructor]
|
|
public ProviderSettings(bool isEnabled)
|
|
{
|
|
IsEnabled = isEnabled;
|
|
}
|
|
|
|
public void Connect(CommandProviderWrapper wrapper)
|
|
{
|
|
ProviderId = wrapper.ProviderId;
|
|
IsBuiltin = wrapper.Extension is null;
|
|
|
|
ProviderDisplayName = wrapper.DisplayName;
|
|
|
|
if (wrapper.FallbackItems.Length > 0)
|
|
{
|
|
foreach (var fallback in wrapper.FallbackItems)
|
|
{
|
|
if (!FallbackCommands.ContainsKey(fallback.Id))
|
|
{
|
|
var enableGlobalResults = IsBuiltin && !_excludedBuiltInFallbacks.Contains(fallback.Id);
|
|
FallbackCommands[fallback.Id] = new FallbackSettings(enableGlobalResults);
|
|
}
|
|
}
|
|
}
|
|
|
|
if (string.IsNullOrEmpty(ProviderId))
|
|
{
|
|
throw new InvalidDataException("Did you add a built-in command and forget to set the Id? Make sure you do that!");
|
|
}
|
|
}
|
|
}
|