mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-04-06 03:07:04 +02:00
* Add more validation logic for shortcut remaps UI * Fixed a bug in CheckRepeatedModifier logic
445 lines
22 KiB
C++
445 lines
22 KiB
C++
#include "pch.h"
|
|
#include "KeyDropDownControl.h"
|
|
#include "keyboardmanager/common/Helpers.h"
|
|
|
|
// Initialized to null
|
|
KeyboardManagerState* KeyDropDownControl::keyboardManagerState = nullptr;
|
|
|
|
// Function to set properties apart from the SelectionChanged event handler
|
|
void KeyDropDownControl::SetDefaultProperties(bool isShortcut)
|
|
{
|
|
if (!isShortcut)
|
|
{
|
|
dropDown.Width(KeyboardManagerConstants::RemapTableDropDownWidth);
|
|
}
|
|
else
|
|
{
|
|
dropDown.Width(KeyboardManagerConstants::ShortcutTableDropDownWidth);
|
|
}
|
|
dropDown.MaxDropDownHeight(KeyboardManagerConstants::TableDropDownHeight);
|
|
// Initialise layout attribute
|
|
previousLayout = GetKeyboardLayout(0);
|
|
keyCodeList = keyboardManagerState->keyboardMap.GetKeyCodeList(isShortcut);
|
|
dropDown.ItemsSource(KeyboardManagerHelper::ToBoxValue(keyboardManagerState->keyboardMap.GetKeyNameList(isShortcut)));
|
|
// drop down open handler - to reload the items with the latest layout
|
|
dropDown.DropDownOpened([&, isShortcut](winrt::Windows::Foundation::IInspectable const& sender, auto args) {
|
|
ComboBox currentDropDown = sender.as<ComboBox>();
|
|
CheckAndUpdateKeyboardLayout(currentDropDown, isShortcut);
|
|
});
|
|
|
|
// Attach flyout to the drop down
|
|
warningFlyout.Content(warningMessage);
|
|
dropDown.ContextFlyout().SetAttachedFlyout((FrameworkElement)dropDown, warningFlyout);
|
|
}
|
|
|
|
// Function to check if the layout has changed and accordingly update the drop down list
|
|
void KeyDropDownControl::CheckAndUpdateKeyboardLayout(ComboBox currentDropDown, bool isShortcut)
|
|
{
|
|
// Get keyboard layout for current thread
|
|
HKL layout = GetKeyboardLayout(0);
|
|
|
|
// Check if the layout has changed
|
|
if (previousLayout != layout)
|
|
{
|
|
keyCodeList = keyboardManagerState->keyboardMap.GetKeyCodeList(isShortcut);
|
|
currentDropDown.ItemsSource(KeyboardManagerHelper::ToBoxValue(keyboardManagerState->keyboardMap.GetKeyNameList(isShortcut)));
|
|
previousLayout = layout;
|
|
}
|
|
}
|
|
|
|
// Function to set selection handler for single key remap drop down. Needs to be called after the constructor since the singleKeyControl StackPanel is null if called in the constructor
|
|
void KeyDropDownControl::SetSelectionHandler(Grid& table, StackPanel& singleKeyControl, int colIndex, std::vector<std::vector<DWORD>>& singleKeyRemapBuffer)
|
|
{
|
|
// drop down selection handler
|
|
auto onSelectionChange = [&, table, singleKeyControl, colIndex](winrt::Windows::Foundation::IInspectable const& sender) {
|
|
ComboBox currentDropDown = sender.as<ComboBox>();
|
|
int selectedKeyIndex = currentDropDown.SelectedIndex();
|
|
// Get row index of the single key control
|
|
uint32_t controlIndex;
|
|
bool indexFound = table.Children().IndexOf(singleKeyControl, controlIndex);
|
|
if (indexFound)
|
|
{
|
|
KeyboardManagerHelper::ErrorType errorType = KeyboardManagerHelper::ErrorType::NoError;
|
|
int rowIndex = (controlIndex - KeyboardManagerConstants::RemapTableHeaderCount) / KeyboardManagerConstants::RemapTableColCount;
|
|
// Check if the element was not found or the index exceeds the known keys
|
|
if (selectedKeyIndex != -1 && keyCodeList.size() > selectedKeyIndex)
|
|
{
|
|
// Check if the value being set is the same as the other column
|
|
if (singleKeyRemapBuffer[rowIndex][std::abs(int(colIndex) - 1)] == keyCodeList[selectedKeyIndex])
|
|
{
|
|
errorType = KeyboardManagerHelper::ErrorType::MapToSameKey;
|
|
}
|
|
|
|
if (errorType == KeyboardManagerHelper::ErrorType::NoError && colIndex == 0)
|
|
{
|
|
// Check if the key is already remapped to something else
|
|
for (int i = 0; i < singleKeyRemapBuffer.size(); i++)
|
|
{
|
|
if (i != rowIndex)
|
|
{
|
|
KeyboardManagerHelper::ErrorType result = KeyboardManagerHelper::DoKeysOverlap(singleKeyRemapBuffer[i][colIndex], keyCodeList[selectedKeyIndex]);
|
|
if (result != KeyboardManagerHelper::ErrorType::NoError)
|
|
{
|
|
errorType = result;
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// If there is no error, set the buffer
|
|
if (errorType == KeyboardManagerHelper::ErrorType::NoError)
|
|
{
|
|
singleKeyRemapBuffer[rowIndex][colIndex] = keyCodeList[selectedKeyIndex];
|
|
}
|
|
else
|
|
{
|
|
singleKeyRemapBuffer[rowIndex][colIndex] = NULL;
|
|
}
|
|
}
|
|
else
|
|
{
|
|
// Reset to null if the key is not found
|
|
singleKeyRemapBuffer[rowIndex][colIndex] = NULL;
|
|
}
|
|
|
|
if (errorType != KeyboardManagerHelper::ErrorType::NoError)
|
|
{
|
|
SetDropDownError(currentDropDown, KeyboardManagerHelper::GetErrorMessage(errorType));
|
|
}
|
|
}
|
|
};
|
|
|
|
// Rather than on every selection change (which gets triggered on searching as well) we set the handler only when the drop down is closed
|
|
dropDown.DropDownClosed([onSelectionChange](winrt::Windows::Foundation::IInspectable const& sender, auto const& args) {
|
|
onSelectionChange(sender);
|
|
});
|
|
|
|
// We check if the selection changed was triggered while the drop down was closed. This is required to handle Type key, initial loading of remaps and if the user just types in the combo box without opening it
|
|
dropDown.SelectionChanged([onSelectionChange](winrt::Windows::Foundation::IInspectable const& sender, SelectionChangedEventArgs const& args) {
|
|
ComboBox currentDropDown = sender.as<ComboBox>();
|
|
if (!currentDropDown.IsDropDownOpen())
|
|
{
|
|
onSelectionChange(sender);
|
|
}
|
|
});
|
|
}
|
|
|
|
std::pair<KeyboardManagerHelper::ErrorType, int> KeyDropDownControl::ValidateShortcutSelection(Grid table, StackPanel shortcutControl, StackPanel parent, int colIndex, std::vector<std::vector<Shortcut>>& shortcutRemapBuffer, std::vector<std::unique_ptr<KeyDropDownControl>>& keyDropDownControlObjects)
|
|
{
|
|
ComboBox currentDropDown = dropDown;
|
|
int selectedKeyIndex = currentDropDown.SelectedIndex();
|
|
uint32_t dropDownIndex = -1;
|
|
bool dropDownFound = parent.Children().IndexOf(currentDropDown, dropDownIndex);
|
|
// Get row index of the single key control
|
|
uint32_t controlIndex;
|
|
bool controlIindexFound = table.Children().IndexOf(shortcutControl, controlIndex);
|
|
KeyboardManagerHelper::ErrorType errorType = KeyboardManagerHelper::ErrorType::NoError;
|
|
bool IsDeleteDropDownRequired = false;
|
|
int rowIndex = -1;
|
|
|
|
if (controlIindexFound)
|
|
{
|
|
rowIndex = (controlIndex - KeyboardManagerConstants::ShortcutTableHeaderCount) / KeyboardManagerConstants::ShortcutTableColCount;
|
|
if (selectedKeyIndex != -1 && keyCodeList.size() > selectedKeyIndex && dropDownFound)
|
|
{
|
|
// If only 1 drop down and action key is chosen: Warn that a modifier must be chosen
|
|
if (parent.Children().Size() == 1 && !KeyboardManagerHelper::IsModifierKey(keyCodeList[selectedKeyIndex]))
|
|
{
|
|
// warn and reset the drop down
|
|
errorType = KeyboardManagerHelper::ErrorType::ShortcutStartWithModifier;
|
|
}
|
|
// If it is the last drop down
|
|
else if (dropDownIndex == parent.Children().Size() - 1)
|
|
{
|
|
// If last drop down and a modifier is selected: add a new drop down (max drop down count should be enforced)
|
|
if (KeyboardManagerHelper::IsModifierKey(keyCodeList[selectedKeyIndex]) && parent.Children().Size() < KeyboardManagerConstants::MaxShortcutSize)
|
|
{
|
|
// If it matched any of the previous modifiers then reset that drop down
|
|
if (CheckRepeatedModifier(parent, selectedKeyIndex, keyCodeList))
|
|
{
|
|
// warn and reset the drop down
|
|
errorType = KeyboardManagerHelper::ErrorType::ShortcutCannotHaveRepeatedModifier;
|
|
}
|
|
// If not, add a new drop down
|
|
else
|
|
{
|
|
AddDropDown(table, shortcutControl, parent, colIndex, shortcutRemapBuffer, keyDropDownControlObjects);
|
|
}
|
|
}
|
|
// If last drop down and a modifier is selected but there are already max drop downs: warn the user
|
|
else if (KeyboardManagerHelper::IsModifierKey(keyCodeList[selectedKeyIndex]) && parent.Children().Size() >= KeyboardManagerConstants::MaxShortcutSize)
|
|
{
|
|
// warn and reset the drop down
|
|
errorType = KeyboardManagerHelper::ErrorType::ShortcutMaxShortcutSizeOneActionKey;
|
|
}
|
|
// If None is selected but it's the last index: warn
|
|
else if (keyCodeList[selectedKeyIndex] == 0)
|
|
{
|
|
// warn and reset the drop down
|
|
errorType = KeyboardManagerHelper::ErrorType::ShortcutOneActionKey;
|
|
}
|
|
// If none of the above, then the action key will be set
|
|
}
|
|
// If it is the not the last drop down
|
|
else
|
|
{
|
|
if (KeyboardManagerHelper::IsModifierKey(keyCodeList[selectedKeyIndex]))
|
|
{
|
|
// If it matched any of the previous modifiers then reset that drop down
|
|
if (CheckRepeatedModifier(parent, selectedKeyIndex, keyCodeList))
|
|
{
|
|
// warn and reset the drop down
|
|
errorType = KeyboardManagerHelper::ErrorType::ShortcutCannotHaveRepeatedModifier;
|
|
}
|
|
// If not, the modifier key will be set
|
|
}
|
|
// If None is selected and there are more than 2 drop downs
|
|
else if (keyCodeList[selectedKeyIndex] == 0 && parent.Children().Size() > KeyboardManagerConstants::MinShortcutSize)
|
|
{
|
|
// set delete drop down flag
|
|
IsDeleteDropDownRequired = true;
|
|
// do not delete the drop down now since there may be some other error which would cause the drop down to be invalid after removal
|
|
}
|
|
else if (keyCodeList[selectedKeyIndex] == 0 && parent.Children().Size() <= KeyboardManagerConstants::MinShortcutSize)
|
|
{
|
|
// warn and reset the drop down
|
|
errorType = KeyboardManagerHelper::ErrorType::ShortcutAtleast2Keys;
|
|
}
|
|
// If the user tries to set an action key check if all drop down menus after this are empty if it is not the first key
|
|
else if (dropDownIndex != 0)
|
|
{
|
|
bool isClear = true;
|
|
for (int i = dropDownIndex + 1; i < (int)parent.Children().Size(); i++)
|
|
{
|
|
ComboBox ItDropDown = parent.Children().GetAt(i).as<ComboBox>();
|
|
if (ItDropDown.SelectedIndex() != -1)
|
|
{
|
|
isClear = false;
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (isClear)
|
|
{
|
|
// remove all the drop down
|
|
int elementsToBeRemoved = parent.Children().Size() - dropDownIndex - 1;
|
|
for (int i = 0; i < elementsToBeRemoved; i++)
|
|
{
|
|
parent.Children().RemoveAtEnd();
|
|
keyDropDownControlObjects.erase(keyDropDownControlObjects.end() - 1);
|
|
}
|
|
parent.UpdateLayout();
|
|
}
|
|
else
|
|
{
|
|
// warn and reset the drop down
|
|
errorType = KeyboardManagerHelper::ErrorType::ShortcutNotMoreThanOneActionKey;
|
|
}
|
|
}
|
|
// If there an action key is chosen on the first drop down and there are more than one drop down menus
|
|
else
|
|
{
|
|
// warn and reset the drop down
|
|
errorType = KeyboardManagerHelper::ErrorType::ShortcutStartWithModifier;
|
|
}
|
|
}
|
|
}
|
|
|
|
// After validating the shortcut, now for errors like remap to same shortcut, remap shortcut more than once, Win L and Ctrl Alt Del
|
|
if (errorType == KeyboardManagerHelper::ErrorType::NoError)
|
|
{
|
|
Shortcut tempShortcut;
|
|
tempShortcut.SetKeyCodes(GetKeysFromStackPanel(parent));
|
|
// Check if the value being set is the same as the other column
|
|
if (shortcutRemapBuffer[rowIndex][std::abs(int(colIndex) - 1)] == tempShortcut && shortcutRemapBuffer[rowIndex][std::abs(int(colIndex) - 1)].IsValidShortcut() && tempShortcut.IsValidShortcut())
|
|
{
|
|
errorType = KeyboardManagerHelper::ErrorType::MapToSameShortcut;
|
|
}
|
|
|
|
if (errorType == KeyboardManagerHelper::ErrorType::NoError && colIndex == 0)
|
|
{
|
|
// Check if the key is already remapped to something else
|
|
for (int i = 0; i < shortcutRemapBuffer.size(); i++)
|
|
{
|
|
if (i != rowIndex)
|
|
{
|
|
KeyboardManagerHelper::ErrorType result = Shortcut::DoKeysOverlap(shortcutRemapBuffer[i][colIndex], tempShortcut);
|
|
if (result != KeyboardManagerHelper::ErrorType::NoError)
|
|
{
|
|
errorType = result;
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
if (errorType == KeyboardManagerHelper::ErrorType::NoError)
|
|
{
|
|
errorType = tempShortcut.IsShortcutIllegal();
|
|
}
|
|
}
|
|
|
|
if (errorType != KeyboardManagerHelper::ErrorType::NoError)
|
|
{
|
|
SetDropDownError(currentDropDown, KeyboardManagerHelper::GetErrorMessage(errorType));
|
|
}
|
|
|
|
// Handle None case if there are no other errors
|
|
else if (IsDeleteDropDownRequired)
|
|
{
|
|
parent.Children().RemoveAt(dropDownIndex);
|
|
// delete drop down control object from the vector so that it can be destructed
|
|
keyDropDownControlObjects.erase(keyDropDownControlObjects.begin() + dropDownIndex);
|
|
parent.UpdateLayout();
|
|
}
|
|
}
|
|
|
|
return std::make_pair(errorType, rowIndex);
|
|
}
|
|
|
|
// Function to set selection handler for shortcut drop down. Needs to be called after the constructor since the shortcutControl StackPanel is null if called in the constructor
|
|
void KeyDropDownControl::SetSelectionHandler(Grid& table, StackPanel& shortcutControl, StackPanel parent, int colIndex, std::vector<std::vector<Shortcut>>& shortcutRemapBuffer, std::vector<std::unique_ptr<KeyDropDownControl>>& keyDropDownControlObjects)
|
|
{
|
|
auto onSelectionChange = [&, table, shortcutControl, colIndex, parent](winrt::Windows::Foundation::IInspectable const& sender) {
|
|
std::pair<KeyboardManagerHelper::ErrorType, int> validationResult = ValidateShortcutSelection(table, shortcutControl, parent, colIndex, shortcutRemapBuffer, keyDropDownControlObjects);
|
|
|
|
// Check if the drop down row index was identified from the return value of validateSelection
|
|
if (validationResult.second != -1)
|
|
{
|
|
// If an error occurred
|
|
if (validationResult.first != KeyboardManagerHelper::ErrorType::NoError)
|
|
{
|
|
// Iterate over all drop downs from left to right in that row/col and validate if there is an error in any of the drop downs. After this the state should be error-free (if it is a valid shortcut)
|
|
for (int i = 0; i < keyDropDownControlObjects.size(); i++)
|
|
{
|
|
// Check for errors only if the current selection is a valid shortcut
|
|
Shortcut tempComputedShortcut;
|
|
tempComputedShortcut.SetKeyCodes(keyDropDownControlObjects[i]->GetKeysFromStackPanel(parent));
|
|
|
|
// If the shortcut is valid and that drop down is not empty
|
|
if (tempComputedShortcut.IsValidShortcut() && keyDropDownControlObjects[i]->GetComboBox().SelectedIndex() != -1)
|
|
{
|
|
keyDropDownControlObjects[i]->ValidateShortcutSelection(table, shortcutControl, parent, colIndex, shortcutRemapBuffer, keyDropDownControlObjects);
|
|
}
|
|
}
|
|
}
|
|
|
|
// Reset the buffer based on the new selected drop down items
|
|
shortcutRemapBuffer[validationResult.second][colIndex].SetKeyCodes(GetKeysFromStackPanel(parent));
|
|
}
|
|
|
|
// If the user searches for a key the selection handler gets invoked however if they click away it reverts back to the previous state. This can result in dangling references to added drop downs which were then reset.
|
|
// We handle this by removing the drop down if it no longer a child of the parent
|
|
for (long long i = keyDropDownControlObjects.size() - 1; i >= 0; i--)
|
|
{
|
|
uint32_t index;
|
|
bool found = parent.Children().IndexOf(keyDropDownControlObjects[i]->GetComboBox(), index);
|
|
if (!found)
|
|
{
|
|
keyDropDownControlObjects.erase(keyDropDownControlObjects.begin() + i);
|
|
}
|
|
}
|
|
};
|
|
|
|
// Rather than on every selection change (which gets triggered on searching as well) we set the handler only when the drop down is closed
|
|
dropDown.DropDownClosed([onSelectionChange](winrt::Windows::Foundation::IInspectable const& sender, auto const& args) {
|
|
onSelectionChange(sender);
|
|
});
|
|
|
|
// We check if the selection changed was triggered while the drop down was closed. This is required to handle Type key, initial loading of remaps and if the user just types in the combo box without opening it
|
|
dropDown.SelectionChanged([onSelectionChange](winrt::Windows::Foundation::IInspectable const& sender, SelectionChangedEventArgs const& args) {
|
|
ComboBox currentDropDown = sender.as<ComboBox>();
|
|
if (!currentDropDown.IsDropDownOpen())
|
|
{
|
|
onSelectionChange(sender);
|
|
}
|
|
});
|
|
}
|
|
|
|
// Function to set the selected index of the drop down
|
|
void KeyDropDownControl::SetSelectedIndex(int32_t index)
|
|
{
|
|
dropDown.SelectedIndex(index);
|
|
}
|
|
|
|
// Function to return the combo box element of the drop down
|
|
ComboBox KeyDropDownControl::GetComboBox()
|
|
{
|
|
return dropDown;
|
|
}
|
|
|
|
// Function to add a drop down to the shortcut stack panel
|
|
void KeyDropDownControl::AddDropDown(Grid table, StackPanel shortcutControl, StackPanel parent, const int colIndex, std::vector<std::vector<Shortcut>>& shortcutRemapBuffer, std::vector<std::unique_ptr<KeyDropDownControl>>& keyDropDownControlObjects)
|
|
{
|
|
keyDropDownControlObjects.push_back(std::move(std::unique_ptr<KeyDropDownControl>(new KeyDropDownControl(true))));
|
|
parent.Children().Append(keyDropDownControlObjects[keyDropDownControlObjects.size() - 1]->GetComboBox());
|
|
keyDropDownControlObjects[keyDropDownControlObjects.size() - 1]->SetSelectionHandler(table, shortcutControl, parent, colIndex, shortcutRemapBuffer, keyDropDownControlObjects);
|
|
parent.UpdateLayout();
|
|
}
|
|
|
|
// Function to get the list of key codes from the shortcut combo box stack panel
|
|
std::vector<DWORD> KeyDropDownControl::GetKeysFromStackPanel(StackPanel parent)
|
|
{
|
|
std::vector<DWORD> keys;
|
|
std::vector<DWORD> keyCodeList = keyboardManagerState->keyboardMap.GetKeyCodeList(true);
|
|
for (int i = 0; i < (int)parent.Children().Size(); i++)
|
|
{
|
|
ComboBox currentDropDown = parent.Children().GetAt(i).as<ComboBox>();
|
|
int selectedKeyIndex = currentDropDown.SelectedIndex();
|
|
if (selectedKeyIndex != -1 && keyCodeList.size() > selectedKeyIndex)
|
|
{
|
|
// If None is not the selected key
|
|
if (keyCodeList[selectedKeyIndex] != 0)
|
|
{
|
|
keys.push_back(keyCodeList[selectedKeyIndex]);
|
|
}
|
|
}
|
|
}
|
|
|
|
return keys;
|
|
}
|
|
|
|
// Function to check if a modifier has been repeated in the previous drop downs
|
|
bool KeyDropDownControl::CheckRepeatedModifier(StackPanel parent, int selectedKeyIndex, const std::vector<DWORD>& keyCodeList)
|
|
{
|
|
// check if modifier has already been added before in a previous drop down
|
|
std::vector<DWORD> currentKeys = GetKeysFromStackPanel(parent);
|
|
int currentDropDownIndex = -1;
|
|
|
|
// Find the key index of the current drop down selection so that we skip that index while searching for repeated modifiers
|
|
for (int i = 0; i < currentKeys.size(); i++)
|
|
{
|
|
if (currentKeys[i] == keyCodeList[selectedKeyIndex])
|
|
{
|
|
currentDropDownIndex = i;
|
|
break;
|
|
}
|
|
}
|
|
|
|
bool matchPreviousModifier = false;
|
|
for (int i = 0; i < currentKeys.size(); i++)
|
|
{
|
|
// Skip the current drop down
|
|
if (i != currentDropDownIndex)
|
|
{
|
|
// If the key type for the newly added key matches any of the existing keys in the shortcut
|
|
if (KeyboardManagerHelper::GetKeyType(keyCodeList[selectedKeyIndex]) == KeyboardManagerHelper::GetKeyType(currentKeys[i]))
|
|
{
|
|
matchPreviousModifier = true;
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
return matchPreviousModifier;
|
|
}
|
|
|
|
// Function to set the warning message
|
|
void KeyDropDownControl::SetDropDownError(ComboBox currentDropDown, hstring message)
|
|
{
|
|
currentDropDown.SelectedIndex(-1);
|
|
warningMessage.Text(message);
|
|
currentDropDown.ContextFlyout().ShowAttachedFlyout((FrameworkElement)dropDown);
|
|
}
|