mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-04-07 03:36:44 +02:00
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Fixes the issue where Launch/Open buttons on OOBE (Welcome to PowerToys) pages remain clickable even when the corresponding module is disabled. Added enabled state checks to the following OOBE pages: - **OobeColorPicker** - checks `ModuleType.ColorPicker` - **OobeEnvironmentVariables** - checks `ModuleType.EnvironmentVariables` - **OobeHosts** - checks `ModuleType.Hosts` - **OobeRun** - checks `ModuleType.PowerLauncher` - **OobeRegistryPreview** - checks `ModuleType.RegistryPreview` - **OobeShortcutGuide** - checks `ModuleType.ShortcutGuide` <img width="1538" height="239" alt="image" src="https://github.com/user-attachments/assets/da20628e-9c82-4619-8a5c-4b75a22b6901" /> <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #44737 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed
59 lines
2.2 KiB
C#
59 lines
2.2 KiB
C#
// Copyright (c) Microsoft Corporation
|
|
// The Microsoft Corporation licenses this file to you under the MIT license.
|
|
// See the LICENSE file in the project root for more information.
|
|
|
|
using Microsoft.PowerToys.Settings.UI.Library;
|
|
using Microsoft.PowerToys.Settings.UI.Library.Helpers;
|
|
using Microsoft.PowerToys.Settings.UI.OOBE.Enums;
|
|
using Microsoft.PowerToys.Settings.UI.OOBE.ViewModel;
|
|
using Microsoft.PowerToys.Settings.UI.Views;
|
|
using Microsoft.UI.Xaml.Controls;
|
|
using Microsoft.UI.Xaml.Navigation;
|
|
|
|
namespace Microsoft.PowerToys.Settings.UI.OOBE.Views
|
|
{
|
|
/// <summary>
|
|
/// An empty page that can be used on its own or navigated to within a Frame.
|
|
/// </summary>
|
|
public sealed partial class OobeRegistryPreview : Page
|
|
{
|
|
public OobePowerToysModule ViewModel { get; set; }
|
|
|
|
public OobeRegistryPreview()
|
|
{
|
|
this.InitializeComponent();
|
|
ViewModel = new OobePowerToysModule(OobeShellPage.OobeShellHandler.Modules[(int)PowerToysModules.RegistryPreview]);
|
|
DataContext = ViewModel;
|
|
}
|
|
|
|
private void Launch_RegistryPreview_Click(object sender, Microsoft.UI.Xaml.RoutedEventArgs e)
|
|
{
|
|
ShellPage.SendDefaultIPCMessage("{\"action\":{\"RegistryPreview\":{\"action_name\":\"Launch\", \"value\":\"\"}}}");
|
|
}
|
|
|
|
private void SettingsLaunchButton_Click(object sender, Microsoft.UI.Xaml.RoutedEventArgs e)
|
|
{
|
|
if (OobeShellPage.OpenMainWindowCallback != null)
|
|
{
|
|
OobeShellPage.OpenMainWindowCallback(typeof(RegistryPreviewPage));
|
|
}
|
|
|
|
ViewModel.LogOpeningSettingsEvent();
|
|
}
|
|
|
|
protected override void OnNavigatedTo(NavigationEventArgs e)
|
|
{
|
|
ViewModel.LogOpeningModuleEvent();
|
|
|
|
// Disable the Launch button if the module is disabled
|
|
var generalSettings = SettingsRepository<GeneralSettings>.GetInstance(SettingsUtils.Default).SettingsConfig;
|
|
LaunchButton.IsEnabled = ModuleHelper.GetIsModuleEnabled(generalSettings, ManagedCommon.ModuleType.RegistryPreview);
|
|
}
|
|
|
|
protected override void OnNavigatedFrom(NavigationEventArgs e)
|
|
{
|
|
ViewModel.LogClosingModuleEvent();
|
|
}
|
|
}
|
|
}
|