mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-04-04 02:06:36 +02:00
This is a fix for a pair of related crashes. Basically, we'd crash on startup if we failed to initialize WinGet. This could happen in two different places: * If WinGet wasn't installed, then we'd explode, cause obviously we can't call its APIs * If we're running as Admin, we won't be able to instantiate it's COM server. Regardless of how it happens, I've defaulted us to just _not enabling the winget built-in_. That's the simplest solution here. As I was helpfully reminded, there's also an elevated WindowsPackageManagerFactory we could use too - though, that wouldn't solve the case of "winget isn't installed" Closes #38460 Closes #38440 (most likely)
164 lines
6.1 KiB
C#
164 lines
6.1 KiB
C#
// Copyright (c) Microsoft Corporation
|
|
// The Microsoft Corporation licenses this file to you under the MIT license.
|
|
// See the LICENSE file in the project root for more information.
|
|
|
|
using ManagedCommon;
|
|
using Microsoft.CmdPal.Common.Helpers;
|
|
using Microsoft.CmdPal.Common.Services;
|
|
using Microsoft.CmdPal.Ext.Apps;
|
|
using Microsoft.CmdPal.Ext.Bookmarks;
|
|
using Microsoft.CmdPal.Ext.Calc;
|
|
using Microsoft.CmdPal.Ext.Indexer;
|
|
using Microsoft.CmdPal.Ext.Registry;
|
|
using Microsoft.CmdPal.Ext.Shell;
|
|
using Microsoft.CmdPal.Ext.System;
|
|
using Microsoft.CmdPal.Ext.TimeDate;
|
|
using Microsoft.CmdPal.Ext.WebSearch;
|
|
using Microsoft.CmdPal.Ext.WindowsServices;
|
|
using Microsoft.CmdPal.Ext.WindowsSettings;
|
|
using Microsoft.CmdPal.Ext.WindowsTerminal;
|
|
using Microsoft.CmdPal.Ext.WindowWalker;
|
|
using Microsoft.CmdPal.Ext.WinGet;
|
|
using Microsoft.CmdPal.UI.ViewModels;
|
|
using Microsoft.CmdPal.UI.ViewModels.BuiltinCommands;
|
|
using Microsoft.CmdPal.UI.ViewModels.Models;
|
|
using Microsoft.CommandPalette.Extensions;
|
|
using Microsoft.Extensions.DependencyInjection;
|
|
using Microsoft.PowerToys.Telemetry;
|
|
using Microsoft.UI.Xaml;
|
|
|
|
// To learn more about WinUI, the WinUI project structure,
|
|
// and more about our project templates, see: http://aka.ms/winui-project-info.
|
|
namespace Microsoft.CmdPal.UI;
|
|
|
|
/// <summary>
|
|
/// Provides application-specific behavior to supplement the default Application class.
|
|
/// </summary>
|
|
public partial class App : Application
|
|
{
|
|
/// <summary>
|
|
/// Gets the current <see cref="App"/> instance in use.
|
|
/// </summary>
|
|
public static new App Current => (App)Application.Current;
|
|
|
|
public Window? AppWindow { get; private set; }
|
|
|
|
public ETWTrace EtwTrace { get; private set; } = new ETWTrace();
|
|
|
|
/// <summary>
|
|
/// Gets the <see cref="IServiceProvider"/> instance to resolve application services.
|
|
/// </summary>
|
|
public IServiceProvider Services { get; }
|
|
|
|
/// <summary>
|
|
/// Initializes a new instance of the <see cref="App"/> class.
|
|
/// Initializes the singleton application object. This is the first line of authored code
|
|
/// executed, and as such is the logical equivalent of main() or WinMain().
|
|
/// </summary>
|
|
public App()
|
|
{
|
|
Services = ConfigureServices();
|
|
|
|
this.InitializeComponent();
|
|
|
|
NativeEventWaiter.WaitForEventLoop(
|
|
"Local\\PowerToysCmdPal-ExitEvent-eb73f6be-3f22-4b36-aee3-62924ba40bfd", () =>
|
|
{
|
|
EtwTrace?.Dispose();
|
|
Environment.Exit(0);
|
|
});
|
|
}
|
|
|
|
/// <summary>
|
|
/// Invoked when the application is launched.
|
|
/// </summary>
|
|
/// <param name="args">Details about the launch request and process.</param>
|
|
protected override void OnLaunched(LaunchActivatedEventArgs args)
|
|
{
|
|
AppWindow = new MainWindow();
|
|
|
|
var cmdArgs = Environment.GetCommandLineArgs();
|
|
|
|
var runFromPT = false;
|
|
foreach (var arg in cmdArgs)
|
|
{
|
|
if (arg == "RunFromPT")
|
|
{
|
|
runFromPT = true;
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (!runFromPT)
|
|
{
|
|
AppWindow.Activate();
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Configures the services for the application
|
|
/// </summary>
|
|
private static ServiceProvider ConfigureServices()
|
|
{
|
|
// TODO: It's in the Labs feed, but we can use Sergio's AOT-friendly source generator for this: https://github.com/CommunityToolkit/Labs-Windows/discussions/463
|
|
ServiceCollection services = new();
|
|
|
|
// Root services
|
|
services.AddSingleton(TaskScheduler.FromCurrentSynchronizationContext());
|
|
|
|
// Built-in Commands. Order matters - this is the order they'll be presented by default.
|
|
var allApps = new AllAppsCommandProvider();
|
|
services.AddSingleton<ICommandProvider>(allApps);
|
|
services.AddSingleton<ICommandProvider, ShellCommandsProvider>();
|
|
services.AddSingleton<ICommandProvider, CalculatorCommandProvider>();
|
|
services.AddSingleton<ICommandProvider, IndexerCommandsProvider>();
|
|
services.AddSingleton<ICommandProvider, BookmarksCommandProvider>();
|
|
|
|
// TODO GH #527 re-enable the clipboard commands
|
|
// services.AddSingleton<ICommandProvider, ClipboardHistoryCommandsProvider>();
|
|
services.AddSingleton<ICommandProvider, WindowWalkerCommandsProvider>();
|
|
services.AddSingleton<ICommandProvider, WebSearchCommandsProvider>();
|
|
|
|
// GH #38440: Users might not have WinGet installed! Or they might have
|
|
// a ridiculously old version. Or might be running as admin.
|
|
// We shouldn't explode in the App ctor if we fail to instantiate an
|
|
// instance of PackageManager, which will happen in the static ctor
|
|
// for WinGetStatics
|
|
try
|
|
{
|
|
var winget = new WinGetExtensionCommandsProvider();
|
|
var callback = allApps.LookupApp;
|
|
winget.SetAllLookup(callback);
|
|
services.AddSingleton<ICommandProvider>(winget);
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
Logger.LogError("Couldn't load winget");
|
|
Logger.LogError(ex.ToString());
|
|
}
|
|
|
|
services.AddSingleton<ICommandProvider, WindowsTerminalCommandsProvider>();
|
|
services.AddSingleton<ICommandProvider, WindowsSettingsCommandsProvider>();
|
|
services.AddSingleton<ICommandProvider, RegistryCommandsProvider>();
|
|
services.AddSingleton<ICommandProvider, WindowsServicesCommandsProvider>();
|
|
services.AddSingleton<ICommandProvider, BuiltInsCommandProvider>();
|
|
services.AddSingleton<ICommandProvider, TimeDateCommandsProvider>();
|
|
services.AddSingleton<ICommandProvider, SystemCommandExtensionProvider>();
|
|
|
|
// Models
|
|
services.AddSingleton<TopLevelCommandManager>();
|
|
services.AddSingleton<AliasManager>();
|
|
services.AddSingleton<HotkeyManager>();
|
|
var sm = SettingsModel.LoadSettings();
|
|
services.AddSingleton(sm);
|
|
var state = AppStateModel.LoadState();
|
|
services.AddSingleton(state);
|
|
services.AddSingleton<IExtensionService, ExtensionService>();
|
|
|
|
// ViewModels
|
|
services.AddSingleton<ShellViewModel>();
|
|
|
|
return services.BuildServiceProvider();
|
|
}
|
|
}
|