mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-04-03 09:46:54 +02:00
6acb793184
What the title says. 😄
Rather than relying on the potentially overloaded `!=` or `==` operators
when checking for null, now we'll use the `is` expression (possibly
combined with the `not` operator) to ensure correct checking. Probably
overkill for many of these classes, but decided to err on the side of
consistency. Would matter more on classes that may be inherited or
extended.
Using `is` and `is not` will provide us a guarantee that no
user-overloaded equality operators (`==`/`!=`) is invoked when a
`expression is null` is evaluated.
In code form, changed all instances of:
```c#
something != null
something == null
```
to:
```c#
something is not null
something is null
```
The one exception was checking null on a `KeyChord`. `KeyChord` is a
struct which is never null so VS will raise an error when trying this
versus just providing a warning when using `keyChord != null`. In
reality, we shouldn't do this check because it can't ever be null. In
the case of a `KeyChord` it **would** be a `KeyChord` equivalent to:
```c#
KeyChord keyChord = new ()
{
Modifiers = 0,
Vkey = 0,
ScanCode = 0
};
```
47 lines
1.4 KiB
C#
47 lines
1.4 KiB
C#
// Copyright (c) Microsoft Corporation
|
|
// The Microsoft Corporation licenses this file to you under the MIT license.
|
|
// See the LICENSE file in the project root for more information.
|
|
|
|
using Microsoft.CmdPal.Core.ViewModels;
|
|
using Microsoft.UI.Dispatching;
|
|
using Microsoft.UI.Xaml.Controls;
|
|
using Microsoft.UI.Xaml.Navigation;
|
|
|
|
namespace Microsoft.CmdPal.UI.Pages;
|
|
|
|
/// <summary>
|
|
/// We use this page to do initialization of our extensions and cache loading to hydrate our ViewModels.
|
|
/// </summary>
|
|
public sealed partial class LoadingPage : Page
|
|
{
|
|
private readonly DispatcherQueue _queue = DispatcherQueue.GetForCurrentThread();
|
|
|
|
public LoadingPage()
|
|
{
|
|
this.InitializeComponent();
|
|
}
|
|
|
|
protected override void OnNavigatedTo(NavigationEventArgs e)
|
|
{
|
|
if (e.Parameter is ShellViewModel shellVM
|
|
&& shellVM.LoadCommand is not null)
|
|
{
|
|
// This will load the built-in commands, then navigate to the main page.
|
|
// Once the mainpage loads, we'll start loading extensions.
|
|
shellVM.LoadCommand.Execute(null);
|
|
|
|
_ = Task.Run(async () =>
|
|
{
|
|
await shellVM.LoadCommand.ExecutionTask!;
|
|
|
|
if (shellVM.LoadCommand.ExecutionTask.Status != TaskStatus.RanToCompletion)
|
|
{
|
|
// TODO: Handle failure case
|
|
}
|
|
});
|
|
}
|
|
|
|
base.OnNavigatedTo(e);
|
|
}
|
|
}
|