mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-07-10 12:33:27 +02:00
13639fcdba
Addresses 4 inline comments from https://github.com/microsoft/PowerToys/pull/48039#pullrequestreview-4343165759 : 1. steps-install-vcpkg.yml: dropped the `git checkout $baseline` step. DHowett: "Doesn't vcpkg handle the baseline itself? ... Terminal has never done this. This seems like an overly complicated way to do what amounts to nothing." Correct — vcpkg.json's builtin-baseline controls registry resolution regardless of which vcpkg tool commit is checked out. The template now matches Terminal's exactly (with the useVSPreview parameter kept from the previous commit). 2. deps/spdlog.props: removed the "this sheet" wording and the multi-line explanation of MSBuild import order. Per DHowett's "not a sheet" + "this is generally true of all props and targets". Replaced with a 3-line comment that just says what the file is for. 3. tools/build/build-essentials.ps1: removed the entire vcpkg detection + runtime-clone block. DHowett: "Terminal has never needed this. ... We can just direct users to install the vcpkg component in visual studio. We don't need a script or anything else to do it, we just put it in .vsconfig and then visual studio will warn them when they do not have it installed." Users now install via .vsconfig (#4 below). If they don't, the fail-fast <Target> in Cpp.Build.props produces a clear error. 4. .vsconfig: added Microsoft.VisualStudio.Component.Vcpkg to the existing component list. Matches Terminal's .vsconfig. Visual Studio prompts users to install missing components when they open PowerToys.slnx, so no separate setup step is needed. Unchanged --------- - Three-tier VcpkgRoot fallback in Cpp.Build.props (matches Terminal's src/common.build.pre.props exactly). - Fail-fast PowerToysEnsureVcpkgAvailable <Target> (gives a clearer error than missing-include when all three tiers miss). - Overlay port at deps/vcpkg-overlays/spdlog/ (unchanged). Verification ------------ Local Release|x64 build of FancyZonesLib.vcxproj green (~27 s on a warm binary cache) via VS-shipped vcpkg. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>