mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-02-24 04:00:02 +01:00
11b406feee
## Summary of the Pull Request Release pipeline is keeping failed, and local build failed at ut. This pull request introduces changes to improve how test projects are handled during release builds, ensuring that test code is not compiled or analyzed when not needed - in doing release build, to - succeed the execution and reduce built time. And, to upgrade from VS17 to VS18 in cmdpal sdk build, this is to keep consistency with all other build step <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] Closes: #xxx <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Local build & release pipeline build should all pass: Local build: <img width="1815" height="281" alt="image" src="https://github.com/user-attachments/assets/f350cf3f-b856-432d-97f3-e392d38ef7fa" /> Release pipeline is working too: <img width="1195" height="163" alt="image" src="https://github.com/user-attachments/assets/ce58de38-f0fb-45ad-9d70-2b8eb1c4db60" /> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
69 lines
3.4 KiB
XML
69 lines
3.4 KiB
XML
<Project>
|
|
<Sdk Name="Microsoft.Build.CopyOnWrite" Version="1.0.282" />
|
|
|
|
<Import Project="$(MSBuildCachePackageRoot)\build\$(MSBuildCachePackageName).targets" Condition="'$(MSBuildCacheEnabled)' == 'true'" />
|
|
<Import Project="$(MSBuildCacheSharedCompilationPackageRoot)\build\Microsoft.MSBuildCache.SharedCompilation.targets" Condition="'$(MSBuildCacheEnabled)' == 'true'" />
|
|
|
|
<!-- Override ManifestTool to the x64 host tool under WindowsSdkDir for all projects once the SDK path is known. -->
|
|
<PropertyGroup Label="ManifestToolOverride">
|
|
<ManifestTool Condition="Exists('$(WindowsSdkDir)bin\x64\mt.exe')">$(WindowsSdkDir)bin\x64\mt.exe</ManifestTool>
|
|
</PropertyGroup>
|
|
|
|
<!-- Auto-restore NuGet for native vcxproj (PackageReference) when building inside VS -->
|
|
<Target Name="EnsureNuGetRestoreForVcxproj" BeforeTargets="PrepareForBuild" Condition="
|
|
'$(BuildingInsideVisualStudio)' == 'true'
|
|
and '$(DesignTimeBuild)' != 'true'
|
|
and '$(RestoreInProgress)' != 'true'
|
|
and '$(MSBuildProjectExtension)' == '.vcxproj'
|
|
and '$(RestoreProjectStyle)' == 'PackageReference'
|
|
and '$(MSBuildProjectExtensionsPath)' != ''
|
|
and !Exists('$(MSBuildProjectExtensionsPath)project.assets.json')
|
|
">
|
|
|
|
<Message Importance="normal" Text="NuGet assets missing for $(MSBuildProjectName); running Restore...; IntDir=$(IntDir); BaseIntermediateOutputPath=$(BaseIntermediateOutputPath)" />
|
|
|
|
<MSBuild Projects="$(MSBuildProjectFullPath)" Targets="Restore" Properties="RestoreInProgress=true" BuildInParallel="false" />
|
|
</Target>
|
|
|
|
<PropertyGroup Condition="'$(IgnoreExperimentalWarnings)' == 'true'">
|
|
<NoWarn>$(NoWarn);CS8305;SA1500;CA1852</NoWarn>
|
|
</PropertyGroup>
|
|
|
|
<!-- Skipped test projects when BuildTests=false: no-op build and remove references.
|
|
This must be in targets (not props) so it runs AFTER the project file adds its items. -->
|
|
<PropertyGroup Condition="'$(_IsSkippedTestProject)' == 'true'">
|
|
<BuildDependsOn />
|
|
<CoreBuildDependsOn />
|
|
<RebuildDependsOn />
|
|
</PropertyGroup>
|
|
|
|
<!-- For C# projects: remove all items -->
|
|
<ItemGroup Condition="'$(_IsSkippedTestProject)' == 'true' and '$(MSBuildProjectExtension)' == '.csproj'">
|
|
<PackageReference Remove="@(PackageReference)" />
|
|
<ProjectReference Remove="@(ProjectReference)" />
|
|
<Reference Remove="@(Reference)" />
|
|
<Compile Remove="@(Compile)" />
|
|
<Content Remove="@(Content)" />
|
|
<EmbeddedResource Remove="@(EmbeddedResource)" />
|
|
<None Remove="@(None)" />
|
|
<Using Remove="@(Using)" />
|
|
<GlobalUsing Remove="@(GlobalUsing)" />
|
|
</ItemGroup>
|
|
|
|
<!-- For C++ projects (vcxproj): remove all compile/link items to prevent build -->
|
|
<ItemGroup Condition="'$(_IsSkippedTestProject)' == 'true' and '$(MSBuildProjectExtension)' == '.vcxproj'">
|
|
<ClCompile Remove="@(ClCompile)" />
|
|
<ClInclude Remove="@(ClInclude)" />
|
|
<Link Remove="@(Link)" />
|
|
<Lib Remove="@(Lib)" />
|
|
<ProjectReference Remove="@(ProjectReference)" />
|
|
<None Remove="@(None)" />
|
|
<ResourceCompile Remove="@(ResourceCompile)" />
|
|
<Midl Remove="@(Midl)" />
|
|
</ItemGroup>
|
|
|
|
<!-- Note: For C++ skipped test projects, build is effectively skipped by removing all compile items above.
|
|
We don't define empty Build/Rebuild/Clean targets here because MSBuild Target definitions with Condition
|
|
on the Target element still override the default targets even when condition is false. -->
|
|
</Project>
|