mirror of https://github.com/microsoft/PowerToys.git synced 2026-07-08 19:40:01 +02:00

Files

Muyuan Li a67fc2d9b7 Fix ShortcutGuide v2 crash when Manifests directory is missing (#48171 )

## Summary

Fixes #48170 — ShortcutGuide v2 crashes on launch when the bundled
`Manifests` directory is absent from the install path.

### Root Cause

The `Assets\ShortcutGuide\Manifests\*.yml` files were never reaching the
build output directory during the CI solution-level build (`msbuild
PowerToys.slnx /t:Build -graph`). The `CopyToOutputDirectory` metadata
on `<Content>` items does not reliably copy files to a shared
`OutputPath` in this build configuration. As a result, the WiX installer
generator found no yml files to package, and the installed product was
missing the Manifests directory entirely.

At runtime, `PowerToysShortcutsPopulator.Populate()` threw an unhandled
`FileNotFoundException` causing a crash loop.

### Fix (3 layers)

1. **Code resilience** (`Program.cs`, `PowerToysShortcutsPopulator.cs`):
- Wrap `Populate()` in try/catch so a missing manifest degrades
gracefully instead of crashing
   - Add `File.Exists` guard before `File.ReadAllText`

2. **Build output** (`ShortcutGuide.Ui.csproj`):
- Add explicit `CopyManifestsToOutputDir` MSBuild target
(`AfterTargets="Build"`) that copies yml files to
`$(OutDir)Assets\ShortcutGuide\Manifests\` — same pattern as the
existing `CopyPRIFileToOutputDir` target
- Keep `<Content Include>` with `CopyToOutputDirectory` as a fallback
for publish scenarios

3. **Installer packaging** (`generateAllFileComponents.ps1`,
`ShortcutGuide.wxs`):
   - Add `*.yml` to the file inclusion list
- Add `Generate-FileList` / `Generate-FileComponents` calls for
`ShortcutGuideManifestsFiles`
- Add WiX directory definition and `RemoveFolder` component for the
Manifests directory

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

2026-06-01 16:28:08 +08:00

PowerToysSetupCustomActionsVNext

Remove unused dependencies and shrink installer size (#47233 )

2026-05-15 17:15:11 +08:00

PowerToysSetupVNext

Fix ShortcutGuide v2 crash when Manifests directory is missing (#48171 )

2026-06-01 16:28:08 +08:00

License.rtf

moving the license.rtf file out of the root dir. compiled both msix and msi and both worked. (#1565 )

2020-03-13 08:48:24 -07:00

PowerToysSetup.slnx

Migrate spdlog from submodule to vcpkg (#48039 )

2026-05-27 15:45:24 +08:00

README.md

Prepare for renaming master -> main (#13235 )

2021-11-01 12:21:47 -05:00

README.md

PowerToys installer instructions

Please go to https://github.com/microsoft/PowerToys/tree/main/doc/devdocs#compile-the-installer for instructions