#include "pch.h" #include "KeyboardEventHandlers.h" #include #include #include #include namespace KeyboardEventHandlers { // Function to a handle a single key remap intptr_t HandleSingleKeyRemapEvent(KeyboardManagerInput::InputInterface& ii, LowlevelKeyboardEvent* data, State& state) noexcept { // Check if the key event was generated by KeyboardManager to avoid remapping events generated by us. if (!(data->lParam->dwExtraInfo & CommonSharedConstants::KEYBOARDMANAGER_INJECTED_FLAG)) { const auto remapping = state.GetSingleKeyRemap(data->lParam->vkCode); if (remapping) { auto it = remapping.value(); // Check if the remap is to a key or a shortcut bool remapToKey = (it->second.index() == 0); // If mapped to VK_DISABLED then the key is disabled if (remapToKey) { if (std::get(it->second) == CommonSharedConstants::VK_DISABLED) { return 1; } } int key_count; if (remapToKey) { key_count = 1; } else { key_count = std::get(it->second).Size(); } LPINPUT keyEventList = new INPUT[size_t(key_count)]{}; // Handle remaps to VK_WIN_BOTH DWORD target; if (remapToKey) { target = Helpers::FilterArtificialKeys(std::get(it->second)); } else { target = Helpers::FilterArtificialKeys(std::get(it->second).GetActionKey()); } // If Ctrl/Alt/Shift is being remapped to Caps Lock, then reset the modifier key state to fix issues in certain IME keyboards where the IME shortcut gets invoked since it detects that the modifier and Caps Lock is pressed even though it is suppressed by the hook - More information at the GitHub issue https://github.com/microsoft/PowerToys/issues/3397 if (data->wParam == WM_KEYDOWN || data->wParam == WM_SYSKEYDOWN) { ResetIfModifierKeyForLowerLevelKeyHandlers(ii, it->first, target); } if (remapToKey) { if (data->wParam == WM_KEYUP || data->wParam == WM_SYSKEYUP) { Helpers::SetKeyEvent(keyEventList, 0, INPUT_KEYBOARD, static_cast(target), KEYEVENTF_KEYUP, KeyboardManagerConstants::KEYBOARDMANAGER_SINGLEKEY_FLAG); } else { Helpers::SetKeyEvent(keyEventList, 0, INPUT_KEYBOARD, static_cast(target), 0, KeyboardManagerConstants::KEYBOARDMANAGER_SINGLEKEY_FLAG); } } else { int i = 0; Shortcut targetShortcut = std::get(it->second); if (data->wParam == WM_KEYUP || data->wParam == WM_SYSKEYUP) { Helpers::SetKeyEvent(keyEventList, i, INPUT_KEYBOARD, static_cast(targetShortcut.GetActionKey()), KEYEVENTF_KEYUP, KeyboardManagerConstants::KEYBOARDMANAGER_SINGLEKEY_FLAG); i++; Helpers::SetModifierKeyEvents(targetShortcut, ModifierKey::Disabled, keyEventList, i, false, KeyboardManagerConstants::KEYBOARDMANAGER_SINGLEKEY_FLAG); // Dummy key is not required here since SetModifierKeyEvents will only add key-up events for the modifiers here, and the action key key-up is already sent before it } else { // Dummy key is not required here since SetModifierKeyEvents will only add key-down events for the modifiers here, and the action key key-down is already sent after it Helpers::SetModifierKeyEvents(targetShortcut, ModifierKey::Disabled, keyEventList, i, true, KeyboardManagerConstants::KEYBOARDMANAGER_SINGLEKEY_FLAG); Helpers::SetKeyEvent(keyEventList, i, INPUT_KEYBOARD, static_cast(targetShortcut.GetActionKey()), 0, KeyboardManagerConstants::KEYBOARDMANAGER_SINGLEKEY_FLAG); i++; } } UINT res = ii.SendVirtualInput(key_count, keyEventList, sizeof(INPUT)); delete[] keyEventList; if (data->wParam == WM_KEYDOWN || data->wParam == WM_SYSKEYDOWN) { // If Caps Lock is being remapped to Ctrl/Alt/Shift, then reset the modifier key state to fix issues in certain IME keyboards where the IME shortcut gets invoked since it detects that the modifier and Caps Lock is pressed even though it is suppressed by the hook - More information at the GitHub issue https://github.com/microsoft/PowerToys/issues/3397 if (remapToKey) { ResetIfModifierKeyForLowerLevelKeyHandlers(ii, target, it->first); } else { std::vector shortcutKeys = std::get(it->second).GetKeyCodes(); for (auto& itSk : shortcutKeys) { ResetIfModifierKeyForLowerLevelKeyHandlers(ii, itSk, it->first); } } } return 1; } } return 0; } /* This feature has not been enabled (code from proof of concept stage) * // Function to a change a key's behavior from toggle to modifier __declspec(dllexport) intptr_t HandleSingleKeyToggleToModEvent(InputInterface& ii, LowlevelKeyboardEvent* data, State& State) noexcept { // Check if the key event was generated by KeyboardManager to avoid remapping events generated by us. if (!(data->lParam->dwExtraInfo & CommonSharedConstants::KEYBOARDMANAGER_INJECTED_FLAG)) { // The mutex should be unlocked before SendInput is called to avoid re-entry into the same mutex. More details can be found at https://github.com/microsoft/PowerToys/pull/1789#issuecomment-607555837 std::unique_lock lock(State.singleKeyToggleToMod_mutex); auto it = State.singleKeyToggleToMod.find(data->lParam->vkCode); if (it != State.singleKeyToggleToMod.end()) { // To avoid long presses (which leads to continuous keydown messages) from toggling the key on and off if (data->wParam == WM_KEYDOWN || data->wParam == WM_SYSKEYDOWN) { if (it->second == false) { State.singleKeyToggleToMod[data->lParam->vkCode] = true; } else { lock.unlock(); return 1; } } int key_count = 2; LPINPUT keyEventList = new INPUT[size_t(key_count)](); Helpers::SetKeyEvent(keyEventList, 0, INPUT_KEYBOARD, (WORD)data->lParam->vkCode, 0, KeyboardManagerConstants::KEYBOARDMANAGER_SINGLEKEY_FLAG); Helpers::SetKeyEvent(keyEventList, 1, INPUT_KEYBOARD, (WORD)data->lParam->vkCode, KEYEVENTF_KEYUP, KeyboardManagerConstants::KEYBOARDMANAGER_SINGLEKEY_FLAG); lock.unlock(); UINT res = ii.SendVirtualInput(key_count, keyEventList, sizeof(INPUT)); delete[] keyEventList; // Reset the long press flag when the key has been lifted. if (data->wParam == WM_KEYUP || data->wParam == WM_SYSKEYUP) { lock.lock(); State.singleKeyToggleToMod[data->lParam->vkCode] = false; lock.unlock(); } return 1; } } return 0; } */ // Function to a handle a shortcut remap intptr_t HandleShortcutRemapEvent(KeyboardManagerInput::InputInterface& ii, LowlevelKeyboardEvent* data, State& state, const std::optional& activatedApp) noexcept { // Check if any shortcut is currently in the invoked state bool isShortcutInvoked = state.CheckShortcutRemapInvoked(activatedApp); // Get shortcut table for given activatedApp ShortcutRemapTable& reMap = state.GetShortcutRemapTable(activatedApp); // Iterate through the shortcut remaps and apply whichever has been pressed for (auto& itShortcut : state.GetSortedShortcutRemapVector(activatedApp)) { const auto it = reMap.find(itShortcut); // If a shortcut is currently in the invoked state then skip till the shortcut that is currently invoked if (isShortcutInvoked && !it->second.isShortcutInvoked) { continue; } // Check if the remap is to a key or a shortcut bool remapToShortcut = (it->second.targetShortcut.index() == 1); const size_t src_size = it->first.Size(); const size_t dest_size = remapToShortcut ? std::get(it->second.targetShortcut).Size() : 1; // If the shortcut has been pressed down if (!it->second.isShortcutInvoked && it->first.CheckModifiersKeyboardState(ii)) { if (data->lParam->vkCode == it->first.GetActionKey() && (data->wParam == WM_KEYDOWN || data->wParam == WM_SYSKEYDOWN)) { // Check if any other keys have been pressed apart from the shortcut. If true, then check for the next shortcut. This is to be done only for shortcut to shortcut remaps if (!it->first.IsKeyboardStateClearExceptShortcut(ii) && (remapToShortcut || std::get(it->second.targetShortcut) == CommonSharedConstants::VK_DISABLED)) { continue; } size_t key_count; LPINPUT keyEventList; // Remember which win key was pressed initially if (ii.GetVirtualKeyState(VK_RWIN)) { it->second.winKeyInvoked = ModifierKey::Right; } else if (ii.GetVirtualKeyState(VK_LWIN)) { it->second.winKeyInvoked = ModifierKey::Left; } if (remapToShortcut) { // Get the common keys between the two shortcuts int commonKeys = it->first.GetCommonModifiersCount(std::get(it->second.targetShortcut)); // If the original shortcut modifiers are a subset of the new shortcut if (commonKeys == src_size - 1) { // key down for all new shortcut keys except the common modifiers key_count = dest_size - commonKeys; keyEventList = new INPUT[key_count]{}; int i = 0; Helpers::SetModifierKeyEvents(std::get(it->second.targetShortcut), it->second.winKeyInvoked, keyEventList, i, true, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG, it->first); Helpers::SetKeyEvent(keyEventList, i, INPUT_KEYBOARD, static_cast(std::get(it->second.targetShortcut).GetActionKey()), 0, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); i++; } else { // Dummy key, key up for all the original shortcut modifier keys and key down for all the new shortcut keys but common keys in each are not repeated key_count = KeyboardManagerConstants::DUMMY_KEY_EVENT_SIZE + (src_size - 1) + (dest_size) - (2 * static_cast(commonKeys)); keyEventList = new INPUT[key_count]{}; // Send a dummy key event to prevent modifier press+release from being triggered. Example: Win+A->Ctrl+V, press Win+A, since Win will be released here we need to send a dummy event before it int i = 0; Helpers::SetDummyKeyEvent(keyEventList, i, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); // Release original shortcut state (release in reverse order of shortcut to be accurate) Helpers::SetModifierKeyEvents(it->first, it->second.winKeyInvoked, keyEventList, i, false, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG, std::get(it->second.targetShortcut)); // Set new shortcut key down state Helpers::SetModifierKeyEvents(std::get(it->second.targetShortcut), it->second.winKeyInvoked, keyEventList, i, true, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG, it->first); Helpers::SetKeyEvent(keyEventList, i, INPUT_KEYBOARD, static_cast(std::get(it->second.targetShortcut).GetActionKey()), 0, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); i++; } // Modifier state reset might be required for this key depending on the shortcut's action and target modifiers - ex: Win+Caps -> Ctrl+A if (it->first.GetCtrlKey() == NULL && it->first.GetAltKey() == NULL && it->first.GetShiftKey() == NULL) { Shortcut temp = std::get(it->second.targetShortcut); for (auto keys : temp.GetKeyCodes()) { ResetIfModifierKeyForLowerLevelKeyHandlers(ii, keys, data->lParam->vkCode); } } } else { // Dummy key, key up for all the original shortcut modifier keys and key down for remapped key key_count = KeyboardManagerConstants::DUMMY_KEY_EVENT_SIZE + (src_size - 1) + dest_size; // Do not send Disable key if (std::get(it->second.targetShortcut) == CommonSharedConstants::VK_DISABLED) { key_count--; // Since the original shortcut's action key is pressed, set it to true it->second.isOriginalActionKeyPressed = true; } keyEventList = new INPUT[key_count]{}; // Send a dummy key event to prevent modifier press+release from being triggered. Example: Win+A->V, press Win+A, since Win will be released here we need to send a dummy event before it int i = 0; Helpers::SetDummyKeyEvent(keyEventList, i, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); // Release original shortcut state (release in reverse order of shortcut to be accurate) Helpers::SetModifierKeyEvents(it->first, it->second.winKeyInvoked, keyEventList, i, false, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); // Set target key down state if (std::get(it->second.targetShortcut) != CommonSharedConstants::VK_DISABLED) { Helpers::SetKeyEvent(keyEventList, i, INPUT_KEYBOARD, static_cast(Helpers::FilterArtificialKeys(std::get(it->second.targetShortcut))), 0, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); i++; } // Modifier state reset might be required for this key depending on the shortcut's action and target modifier - ex: Win+Caps -> Ctrl if (it->first.GetCtrlKey() == NULL && it->first.GetAltKey() == NULL && it->first.GetShiftKey() == NULL) { ResetIfModifierKeyForLowerLevelKeyHandlers(ii, static_cast(Helpers::FilterArtificialKeys(std::get(it->second.targetShortcut))), data->lParam->vkCode); } } it->second.isShortcutInvoked = true; // If app specific shortcut is invoked, store the target application if (activatedApp) { state.SetActivatedApp(*activatedApp); } UINT res = ii.SendVirtualInput(static_cast(key_count), keyEventList, sizeof(INPUT)); delete[] keyEventList; return 1; } } else if (it->second.isShortcutInvoked) { // The shortcut has already been pressed down at least once, i.e. the shortcut has been invoked // There are 6 cases to be handled if the shortcut has been pressed down // 1. The user lets go of one of the modifier keys - reset the keyboard back to the state of the keys actually being pressed down // 2. The user keeps the shortcut pressed - the shortcut is repeated (for example you could hold down Ctrl+V and it will keep pasting) // 3. The user lets go of the action key - keep modifiers of the new shortcut until some other key event which doesn't apply to the original shortcut // 4. The user presses a modifier key in the original shortcut - suppress that key event since the original shortcut is already held down physically (This case can occur only if a user has a duplicated modifier key (possibly by remapping) or if user presses both L/R versions of a modifier remapped with "Both") // 5. The user presses any key apart from the action key or a modifier key in the original shortcut - revert the keyboard state to just the original modifiers being held down along with the current key press // 6. The user releases any key apart from original modifier or original action key - This can't happen since the key down would have to happen first, which is handled above // Get the common keys between the two shortcuts int commonKeys = remapToShortcut ? it->first.GetCommonModifiersCount(std::get(it->second.targetShortcut)) : 0; // Case 1: If any of the modifier keys of the original shortcut are released before the action key if ((it->first.CheckWinKey(data->lParam->vkCode) || it->first.CheckCtrlKey(data->lParam->vkCode) || it->first.CheckAltKey(data->lParam->vkCode) || it->first.CheckShiftKey(data->lParam->vkCode)) && (data->wParam == WM_KEYUP || data->wParam == WM_SYSKEYUP)) { // Release new shortcut, and set original shortcut keys except the one released size_t key_count; LPINPUT keyEventList; if (remapToShortcut) { // if the released key is present in both shortcuts' modifiers (i.e part of the common modifiers) if (std::get(it->second.targetShortcut).CheckWinKey(data->lParam->vkCode) || std::get(it->second.targetShortcut).CheckCtrlKey(data->lParam->vkCode) || std::get(it->second.targetShortcut).CheckAltKey(data->lParam->vkCode) || std::get(it->second.targetShortcut).CheckShiftKey(data->lParam->vkCode)) { // release all new shortcut keys and the common released modifier except the other common modifiers, and add all original shortcut modifiers except the common ones, and dummy key key_count = (dest_size - commonKeys) + (src_size - 1 - commonKeys) + KeyboardManagerConstants::DUMMY_KEY_EVENT_SIZE; } else { // release all new shortcut keys except the common modifiers and add all original shortcut modifiers except the common ones, and dummy key key_count = (dest_size - 1) + (src_size - 2) - (2 * static_cast(commonKeys)) + KeyboardManagerConstants::DUMMY_KEY_EVENT_SIZE; } // If the target shortcut's action key is pressed, then it should be released bool isActionKeyPressed = false; if (ii.GetVirtualKeyState((std::get(it->second.targetShortcut).GetActionKey()))) { isActionKeyPressed = true; key_count += 1; } keyEventList = new INPUT[key_count]{}; // Release new shortcut state (release in reverse order of shortcut to be accurate) int i = 0; if (isActionKeyPressed) { Helpers::SetKeyEvent(keyEventList, i, INPUT_KEYBOARD, static_cast(std::get(it->second.targetShortcut).GetActionKey()), KEYEVENTF_KEYUP, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); i++; } Helpers::SetModifierKeyEvents(std::get(it->second.targetShortcut), it->second.winKeyInvoked, keyEventList, i, false, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG, it->first, data->lParam->vkCode); // Set original shortcut key down state except the action key and the released modifier since the original action key may or may not be held down. If it is held down it will generate it's own key message Helpers::SetModifierKeyEvents(it->first, it->second.winKeyInvoked, keyEventList, i, true, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG, std::get(it->second.targetShortcut), data->lParam->vkCode); // Send a dummy key event to prevent modifier press+release from being triggered. Example: Win+Ctrl+A->Ctrl+V, press Win+Ctrl+A and release A then Ctrl, since Win will be pressed here we need to send a dummy event after it Helpers::SetDummyKeyEvent(keyEventList, i, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); } else { // 1 for releasing new key and original shortcut modifiers except the one released and dummy key key_count = dest_size + src_size - 2 + KeyboardManagerConstants::DUMMY_KEY_EVENT_SIZE; bool isTargetKeyPressed = false; // Do not send Disable key up if (std::get(it->second.targetShortcut) == CommonSharedConstants::VK_DISABLED) { key_count--; } else if (ii.GetVirtualKeyState(Helpers::FilterArtificialKeys(std::get(it->second.targetShortcut)))) { isTargetKeyPressed = true; } else { isTargetKeyPressed = false; key_count--; } keyEventList = new INPUT[key_count]{}; // Release new key state int i = 0; if (std::get(it->second.targetShortcut) != CommonSharedConstants::VK_DISABLED && isTargetKeyPressed) { Helpers::SetKeyEvent(keyEventList, i, INPUT_KEYBOARD, static_cast(Helpers::FilterArtificialKeys(std::get(it->second.targetShortcut))), KEYEVENTF_KEYUP, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); i++; } // Set original shortcut key down state except the action key and the released modifier since the original action key may or may not be held down. If it is held down it will generate it's own key message Helpers::SetModifierKeyEvents(it->first, it->second.winKeyInvoked, keyEventList, i, true, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG, Shortcut(), data->lParam->vkCode); // Send a dummy key event to prevent modifier press+release from being triggered. Example: Win+Ctrl+A->V, press Win+Ctrl+A and release A then Ctrl, since Win will be pressed here we need to send a dummy event after it Helpers::SetDummyKeyEvent(keyEventList, i, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); } // Reset the remap state it->second.isShortcutInvoked = false; it->second.winKeyInvoked = ModifierKey::Disabled; it->second.isOriginalActionKeyPressed = false; // If app specific shortcut has finished invoking, reset the target application if (activatedApp) { state.SetActivatedApp(KeyboardManagerConstants::NoActivatedApp); } // key count can be 0 if both shortcuts have same modifiers and the action key is not held down. delete will throw an error if keyEventList is empty if (key_count > 0) { UINT res = ii.SendVirtualInput(static_cast(key_count), keyEventList, sizeof(INPUT)); delete[] keyEventList; } return 1; } // The system will see the modifiers of the new shortcut as being held down because of the shortcut remap if (!remapToShortcut || std::get(it->second.targetShortcut).CheckModifiersKeyboardState(ii)) { // Case 2: If the original shortcut is still held down the keyboard will get a key down message of the action key in the original shortcut and the new shortcut's modifiers will be held down (keys held down send repeated keydown messages) if (data->lParam->vkCode == it->first.GetActionKey() && (data->wParam == WM_KEYDOWN || data->wParam == WM_SYSKEYDOWN)) { // In case of mapping to disable do not send anything if (!remapToShortcut && std::get(it->second.targetShortcut) == CommonSharedConstants::VK_DISABLED) { // Since the original shortcut's action key is pressed, set it to true it->second.isOriginalActionKeyPressed = true; return 1; } size_t key_count = 1; LPINPUT keyEventList = new INPUT[key_count]{}; if (remapToShortcut) { Helpers::SetKeyEvent(keyEventList, 0, INPUT_KEYBOARD, static_cast(std::get(it->second.targetShortcut).GetActionKey()), 0, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); } else { Helpers::SetKeyEvent(keyEventList, 0, INPUT_KEYBOARD, static_cast(Helpers::FilterArtificialKeys(std::get(it->second.targetShortcut))), 0, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); } UINT res = ii.SendVirtualInput(static_cast(key_count), keyEventList, sizeof(INPUT)); delete[] keyEventList; return 1; } // Case 3: If the action key is released from the original shortcut, keep modifiers of the new shortcut until some other key event which doesn't apply to the original shortcut if (data->lParam->vkCode == it->first.GetActionKey() && (data->wParam == WM_KEYUP || data->wParam == WM_SYSKEYUP)) { size_t key_count = 1; LPINPUT keyEventList; if (remapToShortcut) { keyEventList = new INPUT[key_count]{}; Helpers::SetKeyEvent(keyEventList, 0, INPUT_KEYBOARD, static_cast(std::get(it->second.targetShortcut).GetActionKey()), KEYEVENTF_KEYUP, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); } else if (std::get(it->second.targetShortcut) == CommonSharedConstants::VK_DISABLED) { // If remapped to disable, do nothing and suppress the key event // Since the original shortcut's action key is released, set it to false it->second.isOriginalActionKeyPressed = false; return 1; } else { // Check if the keyboard state is clear apart from the target remap key (by creating a temp Shortcut object with the target key) bool isKeyboardStateClear = Shortcut(std::vector({ Helpers::FilterArtificialKeys(std::get(it->second.targetShortcut)) })).IsKeyboardStateClearExceptShortcut(ii); // If the keyboard state is clear, we release the target key but do not reset the remap state if (isKeyboardStateClear) { keyEventList = new INPUT[key_count]{}; Helpers::SetKeyEvent(keyEventList, 0, INPUT_KEYBOARD, static_cast(Helpers::FilterArtificialKeys(std::get(it->second.targetShortcut))), KEYEVENTF_KEYUP, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); } else { // If any other key is pressed, then the keyboard state must be reverted back to the physical keys. // This is to take cases like Ctrl+A->D remap and user presses B+Ctrl+A and releases A, or Ctrl+A+B and releases A // 1 for releasing new key and original shortcut modifiers, and dummy key key_count = dest_size + (src_size - 1) + KeyboardManagerConstants::DUMMY_KEY_EVENT_SIZE; keyEventList = new INPUT[key_count]{}; // Release new key state int i = 0; Helpers::SetKeyEvent(keyEventList, i, INPUT_KEYBOARD, static_cast(Helpers::FilterArtificialKeys(std::get(it->second.targetShortcut))), KEYEVENTF_KEYUP, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); i++; // Set original shortcut key down state except the action key Helpers::SetModifierKeyEvents(it->first, it->second.winKeyInvoked, keyEventList, i, true, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); // Send a dummy key event to prevent modifier press+release from being triggered. Example: Win+A->V, press Shift+Win+A and release A, since Win will be pressed here we need to send a dummy event after it Helpers::SetDummyKeyEvent(keyEventList, i, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); // Reset the remap state it->second.isShortcutInvoked = false; it->second.winKeyInvoked = ModifierKey::Disabled; it->second.isOriginalActionKeyPressed = false; // If app specific shortcut has finished invoking, reset the target application if (activatedApp != KeyboardManagerConstants::NoActivatedApp) { state.SetActivatedApp(KeyboardManagerConstants::NoActivatedApp); } } } UINT res = ii.SendVirtualInput(static_cast(key_count), keyEventList, sizeof(INPUT)); delete[] keyEventList; return 1; } // Case 4: If a modifier key in the original shortcut is pressed then suppress that key event since the original shortcut is already held down physically - This case can occur only if a user has a duplicated modifier key (possibly by remapping) or if user presses both L/R versions of a modifier remapped with "Both" if ((it->first.CheckWinKey(data->lParam->vkCode) || it->first.CheckCtrlKey(data->lParam->vkCode) || it->first.CheckAltKey(data->lParam->vkCode) || it->first.CheckShiftKey(data->lParam->vkCode)) && (data->wParam == WM_KEYDOWN || data->wParam == WM_SYSKEYDOWN)) { if (remapToShortcut) { // Modifier state reset might be required for this key depending on the target shortcut action key - ex: Ctrl+A -> Win+Caps if (std::get(it->second.targetShortcut).GetCtrlKey() == NULL && std::get(it->second.targetShortcut).GetAltKey() == NULL && std::get(it->second.targetShortcut).GetShiftKey() == NULL) { ResetIfModifierKeyForLowerLevelKeyHandlers(ii, data->lParam->vkCode, std::get(it->second.targetShortcut).GetActionKey()); } } else if (std::get(it->second.targetShortcut) != CommonSharedConstants::VK_DISABLED) { // If it is not remapped to Disable // Modifier state reset might be required for this key depending on the target key - ex: Ctrl+A -> Caps ResetIfModifierKeyForLowerLevelKeyHandlers(ii, data->lParam->vkCode, Helpers::FilterArtificialKeys(std::get(it->second.targetShortcut))); } // Suppress the modifier as it is already physically pressed return 1; } // Case 5: If any key apart from the action key or a modifier key in the original shortcut is pressed then revert the keyboard state to just the original modifiers being held down along with the current key press if (data->wParam == WM_KEYDOWN || data->wParam == WM_SYSKEYDOWN) { if (remapToShortcut) { // Modifier state reset might be required for this key depending on the target shortcut action key - ex: Ctrl+A -> Win+Caps, Shift is pressed. System should not see Shift and Caps pressed together if (std::get(it->second.targetShortcut).GetCtrlKey() == NULL && std::get(it->second.targetShortcut).GetAltKey() == NULL && std::get(it->second.targetShortcut).GetShiftKey() == NULL) { ResetIfModifierKeyForLowerLevelKeyHandlers(ii, data->lParam->vkCode, std::get(it->second.targetShortcut).GetActionKey()); } size_t key_count; LPINPUT keyEventList = nullptr; // Check if a new remapping should be applied Shortcut currentlyPressed = it->first; currentlyPressed.actionKey = data->lParam->vkCode; auto newRemappingIter = reMap.find(currentlyPressed); if (newRemappingIter != reMap.end()) { auto& newRemapping = newRemappingIter->second; Shortcut from = std::get(it->second.targetShortcut); if (newRemapping.RemapToKey()) { DWORD to = std::get<0>(newRemapping.targetShortcut); bool isLastKeyStillPressed = ii.GetVirtualKeyState(static_cast(from.actionKey)); key_count = static_cast(from.Size()) - 1 + 1 + (isLastKeyStillPressed ? 1 : 0); keyEventList = new INPUT[key_count]{}; int i = 0; Helpers::SetModifierKeyEvents(from, it->second.winKeyInvoked, keyEventList, i, false, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); if (ii.GetVirtualKeyState(static_cast(from.actionKey))) { // If the action key from the last shortcut is still being pressed, release it. Helpers::SetKeyEvent(keyEventList, i, INPUT_KEYBOARD, static_cast(from.actionKey), KEYEVENTF_KEYUP, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); i++; } Helpers::SetKeyEvent(keyEventList, i, INPUT_KEYBOARD, static_cast(to), 0, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); } else { Shortcut to = std::get(newRemapping.targetShortcut); bool isLastKeyStillPressed = ii.GetVirtualKeyState(static_cast(from.actionKey)); size_t temp_key_count_calculation = static_cast(from.Size()) - 1; temp_key_count_calculation += static_cast(to.Size()) - 1; temp_key_count_calculation -= static_cast(2) * from.GetCommonModifiersCount(to); key_count = temp_key_count_calculation + 1 + (isLastKeyStillPressed ? 1 : 0); keyEventList = new INPUT[key_count]{}; int i = 0; Helpers::SetModifierKeyEvents(from, it->second.winKeyInvoked, keyEventList, i, false, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG, to); if (ii.GetVirtualKeyState(static_cast(from.actionKey))) { // If the action key from the last shortcut is still being pressed, release it. Helpers::SetKeyEvent(keyEventList, i, INPUT_KEYBOARD, static_cast(from.actionKey), KEYEVENTF_KEYUP, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); i++; } Helpers::SetModifierKeyEvents(to, it->second.winKeyInvoked, keyEventList, i, true, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG, from); Helpers::SetKeyEvent(keyEventList, i, INPUT_KEYBOARD, static_cast(to.actionKey), 0, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); newRemapping.isShortcutInvoked = true; } // Remember which win key was pressed initially if (ii.GetVirtualKeyState(VK_RWIN)) { newRemapping.winKeyInvoked = ModifierKey::Right; } else if (ii.GetVirtualKeyState(VK_LWIN)) { newRemapping.winKeyInvoked = ModifierKey::Left; } } else { // Key up for all new shortcut keys, key down for original shortcut modifiers and current key press but common keys aren't repeated key_count = (dest_size) + (src_size - 1) - (2 * static_cast(commonKeys)); // If the target shortcut's action key is pressed, then it should be released and original shortcut's action key should be set bool isActionKeyPressed = false; if (ii.GetVirtualKeyState((std::get(it->second.targetShortcut).GetActionKey()))) { isActionKeyPressed = true; key_count += 2; } keyEventList = new INPUT[key_count]{}; // Release new shortcut state (release in reverse order of shortcut to be accurate) int i = 0; if (isActionKeyPressed) { Helpers::SetKeyEvent(keyEventList, i, INPUT_KEYBOARD, static_cast(std::get(it->second.targetShortcut).GetActionKey()), KEYEVENTF_KEYUP, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); i++; } Helpers::SetModifierKeyEvents(std::get(it->second.targetShortcut), it->second.winKeyInvoked, keyEventList, i, false, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG, it->first); // Set old shortcut key down state Helpers::SetModifierKeyEvents(it->first, it->second.winKeyInvoked, keyEventList, i, true, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG, std::get(it->second.targetShortcut)); // key down for original shortcut action key with shortcut flag so that we don't invoke the same shortcut remap again if (isActionKeyPressed) { Helpers::SetKeyEvent(keyEventList, i, INPUT_KEYBOARD, static_cast(it->first.GetActionKey()), 0, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); i++; } // Send current key pressed without shortcut flag so that it can be reprocessed in case the physical keys pressed are a different remapped shortcut Helpers::SetKeyEvent(keyEventList, i, INPUT_KEYBOARD, static_cast(data->lParam->vkCode), 0, 0); i++; // Do not send a dummy key as we want the current key press to behave as normal i.e. it can do press+release functionality if required. Required to allow a shortcut to Win key remap invoked directly after shortcut to shortcut is released to open start menu } // Reset the remap state it->second.isShortcutInvoked = false; it->second.winKeyInvoked = ModifierKey::Disabled; it->second.isOriginalActionKeyPressed = false; // If app specific shortcut has finished invoking, reset the target application if (activatedApp) { state.SetActivatedApp(KeyboardManagerConstants::NoActivatedApp); } UINT res = ii.SendVirtualInput(static_cast(key_count), keyEventList, sizeof(INPUT)); delete[] keyEventList; return 1; } else { // For remap to key, if the original action key is not currently pressed, we should revert the keyboard state to the physical keys. If it is pressed we should not suppress the event so that shortcut to key remaps can be pressed with other keys. Example use-case: Alt+D->Win, allows Alt+D+A to perform Win+A // Modifier state reset might be required for this key depending on the target key - ex: Ctrl+A -> Caps, Shift is pressed. System should not see Shift and Caps pressed together ResetIfModifierKeyForLowerLevelKeyHandlers(ii, data->lParam->vkCode, Helpers::FilterArtificialKeys(std::get(it->second.targetShortcut))); // If the shortcut is remapped to Disable then we have to revert the keyboard state to the physical keys bool isRemapToDisable = (std::get(it->second.targetShortcut) == CommonSharedConstants::VK_DISABLED); bool isOriginalActionKeyPressed = false; if (!isRemapToDisable) { // If the remap target key is currently pressed, then we do not have to revert the keyboard state to the physical keys if (ii.GetVirtualKeyState((Helpers::FilterArtificialKeys(std::get(it->second.targetShortcut))))) { isOriginalActionKeyPressed = true; } } else { isOriginalActionKeyPressed = it->second.isOriginalActionKeyPressed; } if (isRemapToDisable || !isOriginalActionKeyPressed) { // Key down for original shortcut modifiers and action key, and current key press size_t key_count = src_size + 1; LPINPUT keyEventList = new INPUT[key_count]{}; // Set original shortcut key down state int i = 0; Helpers::SetModifierKeyEvents(it->first, it->second.winKeyInvoked, keyEventList, i, true, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); // Send the original action key only if it is physically pressed. For remappings to keys other than disabled we already check earlier that it is not pressed in this scenario. For remap to disable if (isRemapToDisable && isOriginalActionKeyPressed) { // Set original action key Helpers::SetKeyEvent(keyEventList, i, INPUT_KEYBOARD, static_cast(it->first.GetActionKey()), 0, KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG); i++; } else { key_count--; } // Send current key pressed without shortcut flag so that it can be reprocessed in case the physical keys pressed are a different remapped shortcut Helpers::SetKeyEvent(keyEventList, i, INPUT_KEYBOARD, static_cast(data->lParam->vkCode), 0, 0); i++; // Do not send a dummy key as we want the current key press to behave as normal i.e. it can do press+release functionality if required. Required to allow a shortcut to Win key remap invoked directly after another shortcut to key remap is released to open start menu // Reset the remap state it->second.isShortcutInvoked = false; it->second.winKeyInvoked = ModifierKey::Disabled; it->second.isOriginalActionKeyPressed = false; // If app specific shortcut has finished invoking, reset the target application if (activatedApp != KeyboardManagerConstants::NoActivatedApp) { state.SetActivatedApp(KeyboardManagerConstants::NoActivatedApp); } UINT res = ii.SendVirtualInput(static_cast(key_count), keyEventList, sizeof(INPUT)); delete[] keyEventList; return 1; } else { return 0; } } } // Case 6: If any key apart from original modifier or original action key is released - This can't happen since the key down would have to happen first, which is handled above. If a key up message is generated for some other key (maybe by code) do not suppress it } } } return 0; } // Function to a handle an os-level shortcut remap intptr_t HandleOSLevelShortcutRemapEvent(KeyboardManagerInput::InputInterface& ii, LowlevelKeyboardEvent* data, State& state) noexcept { // Check if the key event was generated by KeyboardManager to avoid remapping events generated by us. if (data->lParam->dwExtraInfo != KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG) { bool result = HandleShortcutRemapEvent(ii, data, state); return result; } return 0; } // Function to a handle an app-specific shortcut remap intptr_t HandleAppSpecificShortcutRemapEvent(KeyboardManagerInput::InputInterface& ii, LowlevelKeyboardEvent* data, State& state) noexcept { // Check if the key event was generated by KeyboardManager to avoid remapping events generated by us. if (data->lParam->dwExtraInfo != KeyboardManagerConstants::KEYBOARDMANAGER_SHORTCUT_FLAG) { std::wstring process_name; // Allocate MAX_PATH amount of memory process_name.resize(MAX_PATH); ii.GetForegroundProcess(process_name); // Remove elements after null character process_name.erase(std::find(process_name.begin(), process_name.end(), L'\0'), process_name.end()); if (process_name.empty()) { return 0; } // Convert process name to lower case std::transform(process_name.begin(), process_name.end(), process_name.begin(), towlower); std::wstring query_string; AppSpecificShortcutRemapTable::iterator it; // Check if an app-specific shortcut is already activated if (state.GetActivatedApp() == KeyboardManagerConstants::NoActivatedApp) { query_string = process_name; it = state.appSpecificShortcutReMap.find(query_string); // If no entry is found, search for the process name without it's file extension if (it == state.appSpecificShortcutReMap.end()) { // Find index of the file extension size_t extensionIndex = process_name.find_last_of(L"."); query_string = process_name.substr(0, extensionIndex); it = state.appSpecificShortcutReMap.find(query_string); } } else { query_string = state.GetActivatedApp(); it = state.appSpecificShortcutReMap.find(query_string); } if (it != state.appSpecificShortcutReMap.end()) { bool result = HandleShortcutRemapEvent(ii, data, state, query_string); return result; } } return 0; } // Function to ensure Ctrl/Shift/Alt modifier key state is not detected as pressed down by applications which detect keys at a lower level than hooks when it is remapped for scenarios where its required void ResetIfModifierKeyForLowerLevelKeyHandlers(KeyboardManagerInput::InputInterface& ii, DWORD key, DWORD target) { // If the target is Caps Lock and the other key is either Ctrl/Alt/Shift then reset the modifier state to lower level handlers if (target == VK_CAPITAL) { // If the argument is either of the Ctrl/Shift/Alt modifier key codes if (Helpers::IsModifierKey(key) && !(key == VK_LWIN || key == VK_RWIN || key == CommonSharedConstants::VK_WIN_BOTH)) { int key_count = 1; LPINPUT keyEventList = new INPUT[size_t(key_count)]{}; // Use the suppress flag to ensure these are not intercepted by any remapped keys or shortcuts Helpers::SetKeyEvent(keyEventList, 0, INPUT_KEYBOARD, static_cast(key), KEYEVENTF_KEYUP, KeyboardManagerConstants::KEYBOARDMANAGER_SUPPRESS_FLAG); UINT res = ii.SendVirtualInput(static_cast(key_count), keyEventList, sizeof(INPUT)); delete[] keyEventList; } } } }