Commit Graph

46 Commits

Author SHA1 Message Date
Seraphima Zykova
dbcf1fca15 [FancyZones] Improve code quality (part 3: window dragging) (#23040) 2023-01-26 18:02:46 +01:00
Seraphima Zykova
6f0b16de49 [FancyZones] Improve code quality (part 2: WorkArea init) (#23030)
* init WorkArea with a rectangle
* keep the highlighted zones state in a separate class
2023-01-23 18:13:05 +01:00
sosssego
d84a13bb7e [Analyzers][CPP]Turn on warning 26471 (#23103)
Don't use reinterpret_cast. A cast from void* can use static_cast
2023-01-16 11:18:55 +00:00
sosssego
e42bbaaaf7 [Analyzers][CPP] Turn on warning 4702 (#22285)
* Turn on 4702
unreachable code

* fix warnings that didnt show locally

* add comments about disable warnings

* improve comments

* changes from comments

* fix from PR comments
2022-12-12 17:21:48 +00:00
Seraphima Zykova
eca77ad8b3 [FancyZones]Fix snap by hotkey for single-zone layouts (#22373)
* unsnap window from previous work area when snapping by hotkey
2022-12-02 10:29:11 +00:00
Josh Soref
150e7d40dd Check spelling 0 0 21 (#22335) 2022-11-29 11:41:22 -08:00
sosssego
6a6c45189e [Analyzers][CPP] Turn on warning 4458 (#22265)
* Turn on warning 4458

Fix the errors by changing variable names and
supressing the warning on winRT GDI headers

* explaining the warning disables
2022-11-29 14:10:48 +00:00
sosssego
e50cd85e9a [Analyzers][CPP]Turn on warning 4457 (#22149) 2022-11-22 19:10:46 +00:00
Seraphima Zykova
ef8415ddfe [FancyZones] Fix updating window position after switching virtual desktop (#22072) 2022-11-22 16:58:22 +00:00
Seraphima Zykova
ff290eef9d [FancyZones] Window switch shortcut fix (#21426)
* rename Layout -> LayoutData

* simplify zone

* split ZoneSet: Layout

* refactoring

* split ZoneSet: LayoutWindows

* update trace

* split ZoneSet: remove ZoneSet

* fix initialization

* split unit tests

* remove unused

* warning

* nullptr  check

* use current rect

* update work area tests

* use current rect

* simplify

* more meaningful name

* dismiss

* safety checks

* resolve conflicts

* reassign windows after switching vd

* avoid double-processing for window on switching vd

* extend windows fix

* check if window is on current desktop before cycling

* separated extend

* not reinit layout windows
2022-10-31 11:44:25 +00:00
Seraphima Zykova
10bfb014eb [FancyZones] Customize default layouts (#21156) 2022-10-25 17:55:36 +02:00
Seraphima Zykova
32fc88abd2 [FancyZones] Fix applied layout reset in multi monitor mode (#19174) 2022-07-05 12:07:59 +01:00
Seraphima Zykova
35bb4280d0 [FancyZones]Monitor identification (#19077)
* moved monitors identifying

* changed device id

* get wmi info

* convert old data

* save/load applied layouts

* changed monitor identification

* id comparison

* save/load app zone history

* moved com and security init

* update ids in editor

* lib fix

* updated tests

* changed comparison

* tests

* updated id comparison

* updated log

* moved definition

* spell check

* resolve conflicts

* refactoring

* update serial numbers if possible
2022-07-01 16:29:02 +01:00
Seraphima Zykova
9e0781d86c [FancyZones Editor] UI fixes (#18966)
* canvas scaling

* moved editor params saving

* show monitor size

* removed unused cmd args

* separate dpi unaware thread

* tests

* dpi unaware monitor size

* spell

* early return on editor params saving error

* show scaling value

* changed font
2022-06-29 16:39:03 +01:00
Seraphima Zykova
f5f8861eac [FancyZones] Update windows positions after changing the layout fix (#18805)
* removed IWorkArea interface

* split work area initialization

* changed rect type in zoneset

* tests


upd work area tests
removed obsolete, update others
updated work area tests

* get current vd windows

* update windows positions

* removed unused flag

* moved update window positions to work area

* check monitor

* refactoring
2022-06-14 15:45:45 +01:00
Seraphima Zykova
251ea6ded9 [FancyZones] Popup behavior fix (#18270)
* virtual desktop check

* refactoring

* unified check
2022-05-20 09:51:15 +01:00
Seraphima Zykova
5f4a26ebba [FancyZones] Open window in a zone fix (#18193)
* removed background thread monitoring virtual desktops

* removed virtual desktop callbacks

* centralize work with virtual desktops

* updated virtual desktops sync

* app zone history logs

* logs

* get uwp process path

* spell
2022-05-13 14:06:11 +01:00
Seraphima Zykova
98268cc10a [FancyZones] Remove resolution from "device-id" (#17412)
* removed resolution from device id

* update applied layouts device id

* app zone history device id updated

* moved old device id parsing

* updated tests

* remove resolution in the editor

* remove resolution from device id generation

* update editor params
2022-04-07 10:48:29 +01:00
Seraphima Zykova
c7e0850b7b [FancyZones]Remove check if window already snapped (#17512) 2022-04-04 16:24:52 +01:00
Seraphima Zykova
0816714782 [FancyZones]Additional logs (#16927) 2022-03-10 17:59:31 +00:00
Seraphima Zykova
3a8218be44 [FancyZones] Template layout settings reset fix (#16628) 2022-03-04 08:12:25 +03:00
Seraphima Zykova
8edfb8fe80 [FancyZones] Child windows support (#16507) 2022-02-23 17:25:28 +03:00
Seraphima Zykova
a3dbb55404 [FancyZones] Increase the number of zones limit to 128 (#15976) 2022-02-04 15:09:11 +00:00
Seraphima Zykova
03c36b4f65 [FancyZones] Split zones-settings: devices -> applied layouts (#15779) 2022-01-27 12:21:15 +00:00
Seraphima Zykova
453bb613af [FancyZones] Split zones-settings: app zone history (#15690) 2022-01-24 11:54:17 +00:00
Seraphima Zykova
714ca349ff [FancyZones] Split zones-settings: custom layouts (#15642) 2022-01-20 11:02:38 +00:00
Seraphima Zykova
ba431c5bfd [FancyZones] Split zones-settings: layout hotkeys (#15514) 2022-01-17 08:50:24 +00:00
Seraphima Zykova
7d0304fd06 [FancyZones] Do not snap child windows via the "Win+Arrow" shortcut (#15102) 2021-12-22 20:34:18 +00:00
Davide Giacometti
288e0487a0 [FancyZones] Zone Number Settings (#14910) 2021-12-20 16:50:51 +00:00
Stefan Markovic
dfe9169e39 [modules] Unify exe & dll naming (#14903)
* Unify exe/dll naming - AwakeModuleInterface

* Unify exe/dll naming - ColorPicker.dll & ColorPickerUI.exe

* Unify exe/dll naming - FancyZones, FancyZonesEditor & FancyZonesModuleInterface

* Unify exe/dll naming - ImageResizerExt & ImageResizer.exe

* Unify exe/dll naming - KeyboardManager.dll

* Unify exe/dll naming - FindMyMouse & MouseHighlighter

* Unify exe/dll naming - PowerRename.dll, PowerRenameUIHost & PowerRenameUILib

* Unify exe/dll naming - File Explorer add-ons

* Unify exe/dll naming - ShortcutGuide

* Unify exe/dll naming - VCM

* Unify exe/dll naming - PT Run

* Unify exe/dll naming - *.resources.dll

* [Fix] Unify exe/dll naming - VideoConferenceProxyFilter_x86
2021-12-10 10:50:46 +01:00
FLOAT4
9bb6d57515 [FancyZones] Cleanup (#14274)
* [FancyZones] Remove obsolete code

The field `m_zoneSets` is unused, and may be removed.

* [FancyZones] Remove obsolete code

The field `m_windows` is unused, and may be removed.

* [FancyZones] Move adjustment of `RECT` to utils.cpp

By doing so, also fix a bug where a non-`WS_SIZEBOX` window (a window that should not be resized) was resized (and not properly resized) if it was zoned into more than one zone.

* [FancyZones] Complete rename `ZoneWindow` -> `WorkArea`

Fix leftovers from "[FancyZones] Rename ZoneWindow -> WorkArea (#12223)"

* [FancyZones] Refer to the move/size action as dragging

* [FancyZones] Rename `ActiveZoneSet` -> `ZoneSet`

There is only one zone set used by a work area.

* [FancyZones] Rename `zoneUuid` -> `layoutUuid`

The variable holds the UUID of the layout (not of a zone).

Co-authored-by: float4 <float4-unspecified-mail>
2021-11-11 17:23:22 +00:00
Stefan Markovic
079a3b49de Add logging for PowerRename (#14249)
* Add logging for PowerRename

Move call tracer to common/utils/logger
Add logging to both PowerRename dll and PowerRenameUIHost
Add PowerRename to BugReportTool event viewer collection

* Log more errors and exceptions
2021-11-08 13:02:56 +01:00
Jaime Bernardo
3a6dd45741 [Telemetry] Add basic interaction events to FZ (#12793)
* [Telemetry] Add basic interaction events to FZ

Adds some basic interaction events to FancyZones, such as:
- Starting the drag Window movement.
- A newly created window snapping to a zone.
- Using the Keyboard to snap or extend to a zone.

* Update src/modules/fancyzones/FancyZonesLib/FancyZones.cpp

Co-authored-by: Seraphima Zykova <zykovas91@gmail.com>

* Update trace.cpp

* Rename EventSnapNewWindowIntoZone

* Adjust event names according to PR feedback

Co-authored-by: Seraphima Zykova <zykovas91@gmail.com>
2021-11-04 16:53:36 +00:00
Davide Giacometti
e19ecd2ba1 [FancyZones] Use accent color and theme (#14158)
* use accent color and theme

* typo

* Updated FZ color UX (#14171)

Co-authored-by: Laute <Niels.Laute@philips.com>

* fix resources

* rebase fix

* label updated

Co-authored-by: Niels Laute <niels.laute@live.nl>
Co-authored-by: Laute <Niels.Laute@philips.com>
2021-11-04 14:30:06 +00:00
FLOAT4
9d9df949ef Add keyboard shortcuts (without GUI) for switching windows in the same zone (tabs) (#13973)
Authored-by: float4 <float4-unspecified-mail>
2021-11-03 16:11:42 +01:00
Seraphima Zykova
b05378cdf7 [FancyZones] Reset zone settings after restart fix. (#13322)
* updated virtual desktop retrieving

* save with null-guid

* moved guid utils

* moved DeviceIdData related functions

* replaced strings with data structs

* default value

* clean up

* save app zone history with zones settings

* compare with null guid

* updated tests

* refactoring

* logs

* sync vd ids

* logs

* refactoring

* check virtual desktop id

* OnDisplayChange call

* compare device ids in editor
2021-09-22 22:39:48 +01:00
Seraphima Zykova
2b95eba51b check desktop id (#12930) 2021-08-27 14:59:04 +01:00
Seraphima Zykova
e35568f63d [Fancy Zones] Restore Console Applications (#12905) 2021-08-26 20:47:27 +03:00
Seraphima Zykova
ec08a1d44a [FancyZones] Windows resize on switching layout. (#12792) 2021-08-18 12:00:28 +01:00
Seraphima Zykova
7ea1f26209 [FancyZones] Zone indexes type change (#12724) 2021-08-11 15:05:03 +01:00
Seraphima Zykova
9d597faabc [FancyZones] Window opening on the last zone (#12284) 2021-07-09 18:18:21 +01:00
Seraphima Zykova
d85c3f8cc9 [FancyZones] Revisit mutexes (#12240)
* [FancyZones] Clean up (#11893)

* [FancyZones] Virtual desktop utils refactoring (#11925)

* [FancyZones] IFancyZonesCallback refactoring (#11932)

* [FancyZones] IZoneWindowHost refactoring (#12091)

* [FancyZones] Rename ZoneWindow -> WorkArea (#12223)

* [FancyZones] Clean up mutexes (#12228)
2021-07-07 13:18:52 +03:00
Andrey Nekrasov
4e23832d52 Add new VideoConference module for muting mic/cam (#11798)
* add new VideoConference module for muting mic/cam

Co-authored-by: PrzemyslawTusinski <61138537+PrzemyslawTusinski@users.noreply.github.com>
Co-authored-by: Niels Laute <niels.laute@live.nl>
2021-06-29 13:06:12 +03:00
Seraphima Zykova
2dc82f31b3 [FancyZones] "Match not found" error fix (#11840) 2021-06-23 16:28:23 +01:00
Andrey Nekrasov
eeea6b3bae [FancyZones] Do not try to zone minimized windows (#11776) 2021-06-23 17:05:55 +03:00
Seraphima Zykova
c93eb92cd0 [FancyZones] Move FancyZones out of the runner process (#11818)
* rename dll -> FancyZonesModuleInterface (#11488)

* [FancyZones] Rename "fancyzones/tests" -> "fancyzones/FancyZonesTests" (#11492)

* [FancyZones] Rename "fancyzones/lib" -> "fancyzones/FancyZonesLib" (#11489)

* [FancyZones] New FancyZones project. (#11544)

* [FancyZones] Allow single instance of "PowerToys.FancyZones.exe" (#11558)

* [FancyZones] Updated bug reports (#11571)

* [FancyZones] Updated installer (#11572)

* [FancyZones] Update string resources (#11596)

* [FancyZones] Terminate FancyZones with runner (#11696)

* [FancyZones] Drop support for the module interface API to save settings (#11661)

* Settings telemetry for FancyZones (#11766)

* commented out test

* enable dpi awareness for the process
2021-06-23 13:48:54 +01:00