12 Commits

Author	SHA1	Message	Date
Arjun Balgovind	82e1be2839	[Launcher] Categorize Lnk files in program plugin correctly as per the target file type (#6348) ... * Updated UnregisteredApps code * Added file type checking code and Folder and File classifications * Added more file formats * Removed run as admin for lnk folders * Added script files as executable and changed hashset to case insensitive * Removed runasadmin for generic files * Removed FileTypes enum * Extended ApplicationTypes enum * Fix file format error * Cleaned use of ApplicationType enum to public and match AppType and used ApplicationType in OnAppRenamed * Modify tests to use ApplicationType enum * Added tests for new App types * Modified dummy appref * Mock Directory.Exists and add tests for GetAppTypeFromPath * Combined tests	2020-09-10 15:06:37 -07:00
Arjun Balgovind	1b598ad87e	[Localization] Move PowerToys Run string resources from xaml files to resx (#6165) ... * Removed xaml files, added resx file and removed references for PowerLauncher project * Added resx file for wox.plugin * Moved Calculator resources to resx * Migrated resources for Folder and Indexer plugins * Migrated resources for Program and Shell plugin * Migrated resources for URI and Window Walker * Removed GetTranslation, tests need to be refactored * Removed internationalization classes * Removed Wox.Core.Resource references * Fixed Programs plugin tests * Fixed tests * Removed language xaml files from installer * Added locProject.json files * Fixed resource not found error * Reverted addition of resx file for Wox.Plugin	2020-09-02 15:24:59 -07:00
Clint Rutkas	d055ba1c3b	whitespace forced changes (#6002)	2020-08-17 10:00:56 -07:00
Clint Rutkas	38b0d427f8	Fix all file naming tweaks (#5945)	2020-08-13 15:31:32 -07:00
Clint Rutkas	5079ee67c3	[stylecop] program plugin unit tests part2 (#5925) ... * Another batch * Commenting out stylecop	2020-08-13 11:10:55 -07:00
Clint Rutkas	95e82ca359	[stylecop] program plugin/unit test first pass (#5908) ... * initial pass * multiple whitespace fixes	2020-08-12 11:46:11 -07:00
ryanbodrug-microsoft	db6e9b6962	Adding FxCop to Program Plugin Unit Tests (#5884) ... * Adding FxCop to Microsoft.Plugin.Program.UnitTests * CA1707: Identifiers should not contain underscores https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1707?view=vs-2019 * CA1307: Specify StringComparison https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1307?view=vs-2019 * CA1812: Avoid uninstantiated internal classes https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1812?view=vs-2019 * More CA1707: Identifiers should not contain underscores fixes now that class is public * More fixes for https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1812?view=vs-2019 List Repository and Win32ProgramRepository * More CA1707: Identifiers should not contain underscores fixes now that class is public ListRepository and Win32ProgramRepository tests * Adding `ConfigureAwait(false)` and removing Assert.DoesNotThrowAsync as thowing an exception will fail the test anyway, and the DoesNotThrowAsync method can't be awaited. Fix for CA2007: Do not directly await a Task (Consider calling ConfigureAwait on the task). CS1998 This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. * Setting treat warning as errors to true for release and debug.	2020-08-12 10:03:34 -07:00
ryanbodrug-microsoft	ac10c988b9	Enable Static Analysis on programs plugin (#5847) ... * Removing unused ProgramSettings constructor paramaters. * Fix for: Severity Code Description Project File Line Suppression State Error CA1829 Use the "Count" property instead of Enumerable.Count(). Microsoft.Plugin.Program C:\Repos\PowerToys\src\modules\launcher\Plugins\Microsoft.Plugin.Program\Views\ProgramSetting.xaml.cs 182 Active Severity Code Description Project File Line Suppression State Error CA1827 Count() is used where Any() could be used instead to improve performance. Microsoft.Plugin.Program C:\Repos\PowerToys\src\modules\launcher\Plugins\Microsoft.Plugin.Program\Views\ProgramSetting.xaml.cs 287 Active * Fixes for CA1031: https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1031?view=vs-2019 * More fixes(Suppression) for CA1031 (Catching base exception) https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1031?view=vs-2019 * Fix for nested types being externally visible. CA1034 https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1034?view=vs-2019 * Fix for CA1028 If possible, make the underlying type of Hresult System.Int32 instead of uint. Microsoft.Plugin.Program C:\Repos\PowerToys\src\modules\launcher\Plugins\Microsoft.Plugin.Program\Programs\UWP.cs 236 Active * Fix for CA2227 Collection properties should be readonly. https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2227?view=vs-2019 Fix rror CA2211 Non-constant fields should not be visible https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2211?view=vs-2019 * CA2208: Instantiate argument exceptions correctly https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2208?view=vs-2019 * Win32.cs Static analysis fixes: CA2200: Rethrow to preserve stack details https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2200?view=vs-2019 CA1825: Avoid zero-length array allocations https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1825?view=vs-2019 CA2211: Non-constant fields should not be visible https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2211?view=vs-2019 * More Win32.cs static analysis fixes: CA1307: Specify StringComparison https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1307?view=vs-2019 Verifying query is not null before using it. CA1062: Validate arguments of public methods https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1062?view=vs-2019 CA1305: Specify IFormatProvider https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1305?view=vs-2019 * UWPApplication. CA2007: Do not directly await a Task https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2007?view=vs-2019 * Error CA2010 Consume the hresult returned by method 'Microsoft.Plugin.Program.Programs.AppxPackageHelper.IAppxManifestApplication.GetStringValue(string, out string)' and call Marshal.ThrowExceptionForHR. Note: CA2010 has been removed from future FXCop versions as it can provide incorrect advice for methods that don't return hresult (possibly when [PreserveSig] has been incorrectly labeled.) I've verified the methods in question do still return hresults. * More fixes for Error CA2010 Consume the hresult returned by method and call Marshal.ThrowExceptionForHR. * Fixes for: Error CA2000 Call System.IDisposable.Dispose on object created before all references to it are out of scope. * Suppress CA1031:Do not catch general exception types * Fixes for Error CA1034 Do not nest type ... * Fixing Unit tests that were broken as per a previous fix. * Fix for: CA1034: Nested types should not be visible: https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1034?view=vs-2019 * Suppressing CA1707 for native/com types. CA1707:Identifiers should not contain underscores * Fix for Error CA1307 The behavior of 'string.Replace(string, string?)' could vary based on the current user's locale settings. * Fixes for Error CA1825 Avoid unnecessary zero-length array allocations. Use Array.Empty<string>() instead. * Fix for: Error CA1823 Unused field 'IndexLock'. * Fixes for CA1822: Mark members as static: https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1822?view=vs-2019 * Fix for Error CA1819 Properties should not return arrays * Fix for Error CA1806 ContextMenus calls Trim but does not use the new string instance that the method returns. Pass the instance as an argument to another method, assign the instance to a variable, or remove the call if it is unnecessary. * Fix for Error CA1801 Parameter settings of method UpdateSettings is never used. Remove the parameter or use it in the method body. * Fix for Error CA1724 The type name Settings conflicts in whole or in part with the namespace name 'Microsoft.PowerToys.Settings'. * Includes FxCop for static analysis * Fix for Error CA1717 Only FlagsAttribute enums should have plural names * Suppress Stgm flags: Error CA1714 Flags enums should have plural names Microsoft.Plugin.Program * Rename Win32 to Win32Program Fix for: Error CA1724 The type name Win32 conflicts in whole or in part with the namespace name 'Microsoft.Win32' defined in the .NET Framework. Rename the type to eliminate the conflict. * Fixes for Error CA1507 Use nameof in place of string literal * Using ordinal instead of invariant culture when not symbolic comparison * CA1308: Normalize strings to uppercase https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1308?view=vs-2019 * CA1304: Specify CultureInfo CA1305: Specify IFormatProvider https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1305?view=vs-2019 https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1304?view=vs-2019 * CA1062: Validate arguments of public methods https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1062?view=vs-2019 * CA1056: URI properties should not be strings https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1056?view=vs-2019 Fix: Making LogoURi private, as it is only used internally and operated on as a string * Warning CA1052 Type 'AppxPackageHelper' is a static holder type but is neither static nor NotInheritable * CA1060: Move P/Invokes to NativeMethods class https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1060?view=vs-2019 * Programs Plugin - Treat warnings as errors true * CA1031:Do not catch general exception types Missed release only compile issue. Making debug and release behave the same. * Renaming 'Create' to 'CreateWin32Program' based on PR feedback.	2020-08-11 09:08:44 -07:00
Clint Rutkas	14247fa75a	Dev/crutkas/fixing warnings (#5161) ... * new lines & braces * Tabs /space auto fix Co-authored-by: Clint Rutkas <crutkas@microsoft.com>	2020-07-22 13:27:17 -07:00
ryanbodrug-microsoft	b1d662a5b1	Improving performance of Adding and Removing Packaged Apps (#4521) (#4900) ... * Merging in Theme changes and moving win32Tests to Microsoft.Plugin.Program.UnitTests * Fixing message format for exception * Changing test structure. Need to add unit tests. * Updating packagerepository comment based on pr feedback * Fixing potential race condition in ListRepository. Now internally implemented as a concurrent dictionary. * Removing unecessary implementation of IRepository interface as this is implemented by the base class. * Restoring checks for invalid uwp apps based on PR feedback. This was accidentally removed when moving the initialize outside the constructor. * Fixing comments * Adding newline to end of file for IProgramRepository	2020-07-09 13:14:53 -07:00
ryanbodrug-microsoft	12d9d59d85	Revert "Improving performance of Adding and Removing Packaged Apps" (#4898) ... * Revert "Adding newline to end of file for IProgramRepository" This reverts commit d55cac80bf. * Revert "Fixing comments" This reverts commit a1ecdc9bfa. * Revert "Restoring checks for invalid uwp apps based on PR feedback. This was accidentally removed when moving the initialize outside the constructor." This reverts commit 0e8c1cb0fd. * Revert "Removing unecessary implementation of IRepository interface as this is implemented by the base class." This reverts commit 1c724280f5. * Revert "Fixing potential race condition in ListRepository. Now internally implemented as a concurrent dictionary." This reverts commit 9ff8246a9d. * Revert "Updating packagerepository comment based on pr feedback" This reverts commit 2c45956030. * Revert "Changing test structure. Need to add unit tests." This reverts commit 1c267a55d5. * Revert "Fixing message format for exception" This reverts commit f60bdc3dd4. * Revert "Merging in Theme changes and moving win32Tests to Microsoft.Plugin.Program.UnitTests" This reverts commit 030dfc2370.	2020-07-09 12:10:48 -07:00
ryanbodrug-microsoft	030dfc2370	Merging in Theme changes and moving win32Tests to Microsoft.Plugin.Program.UnitTests	2020-07-09 07:02:19 -07:00