Shawn Yuan
75526b9580
[Feature] PowerToys hotkey conflict detection ( #41029 )
...
<!-- Enter a brief description/summary of your PR here. What does it
fix/what does it change/how was it tested (even manually, if necessary)?
-->
## Summary of the Pull Request
Implements comprehensive hotkey conflict detection and resolution system
for PowerToys, providing real-time conflict checking and centralized
management interface.
## PR Checklist
- [ ] **Closes:** #xxx
- [x] **Communication:** I've discussed this with core contributors
already. If the work hasn't been agreed, this work might be rejected
- [ ] **Tests:** Added/updated and all pass
- [x] **Localization:** All end-user-facing strings can be localized
- [x] **Dev docs:** Added/updated
- [ ] **New binaries:** Added on the required places
- [ ] [JSON for
signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json )
for new binaries
- [ ] [WXS for
installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs )
for new binaries and localization folder
- [ ] [YML for CI
pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml )
for new test projects
- [ ] [YML for signed
pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml )
- [x] **Documentation updated:** If checked, please file a pull request
on [our docs
repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys )
and link it here: [Shortcut conflict detction dev
spec](https://github.com/MicrosoftDocs/windows-dev-docs/pull/5519 )
## TODO Lists
- [x] Add real-time hotkey validation functionality to the hotkey dialog
- [x] Immediately detect conflicts and update shortcut conflict status
after applying new shortcuts
- [x] Return conflict list from runner hotkey conflict detector for
conflict checking.
- [x] Implement the Tooltip for every shortcut control
- [x] Add dialog UI for showing all the shortcut conflicts
- [x] Support changing shortcut directly inside the shortcut conflict
window/dialog, no need to nav to the settings page.
- [x] Redesign the `ShortcutConflictDialogContentControl` to align with
the spec
- [x] Add navigating and changing hotkey auctionability to the
`ShortcutConflictDialogContentControl`
- [x] Add telemetry. Impemented in [another
PR](https://github.com/shuaiyuanxx/PowerToys/pull/47 )
## Shortcut Conflict Support Modules
<details>
<summary>Demo videos</summary>
https://github.com/user-attachments/assets/476d992c-c6ca-4bcd-a3f2-b26cc612d1b9
https://github.com/user-attachments/assets/1c1a2537-de54-4db2-bdbf-6f1908ff1ce7
https://github.com/user-attachments/assets/9c992254-fc2b-402c-beec-20fceef25e6b
https://github.com/user-attachments/assets/d66abc1c-b8bf-45f8-a552-ec989dab310f
</details>
<!-- Provide a more detailed description of the PR, other things fixed,
or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments
<!-- Describe how you validated the behavior. Add automated tests
wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
Manually validation performed.
---------
Signed-off-by: Shawn Yuan <shuaiyuan@microsoft.com >
Signed-off-by: Shuai Yuan <shuai.yuan.zju@gmail.com >
Co-authored-by: Niels Laute <niels.laute@live.nl >
2025-08-20 09:31:52 +08:00
Jeremy Sinclair
195c6f588a
[Analyzers] Resolve Stylecop SA1516 violations and others to enable fully building on VS 17.12 ( #35248 )
...
* [Analyzers][Settings] Fix SA1516
* [Analyzers][Workspaces] Fix SA1516
* [Analyzers][Awake] Fix SA1516
* [Analyzers][Wox] Fix SA1516
* [MWB] Disable CA1716 warning on class name
* [Wox] Update ExecuteFilePath property visibility for Json Source Generator
* [Analyzers][MWB] Fix CA1716 on NativeMethods.
---------
Co-authored-by: Jaime Bernardo <jaime@janeasystems.com >
2024-10-17 05:14:57 -04:00
Davide Giacometti
b14aa8276d
[Settings]Theme override fix and cleanup ( #32362 )
...
* theme override fix and cleanup
* test fix
2024-04-17 15:39:19 +01:00
Davide Giacometti
5cbe9dd911
[Build] Upgraded NetAnalyzers to 7.0.1 ( #24792 )
...
* upgraded NetAnalyzers to 7.0.1
* fix spellcheck
* Microsoft.CodeAnalysis.NetAnalyzers 7.0.1
* rebase and fix
2023-03-16 15:51:31 +01:00
Niels Laute
c1c14b4f2e
[Settings][runner]Quick access system tray launcher ( #22408 )
...
* Init
* Fix running settings
* UI design
* Left click trigger
Wire up colorpicker and pt run
* Wire up others
* Update FlyoutWindow.xaml.cs
* Removed comments
* Update FlyoutWindow.xaml
* More work
* Open Settings page
* More UI work
* Resolve conflicts
* [General] SystemTray Flyout: Add update on tray items' visibility when module gets enabled/disabled
Also remove context menu opening on tray icon.
* Adding app list
* Adding more buttons, resolving conflicts
* [General] Flyout: improving opening, closing flyout/settings window. Implementing basic bahaviour on enabling/disabling modules.
* [General] FlyoutWindow: proceed with implementation. GPO works. Main functionallity works (launching and enabling apps).
* [general] flyout: fix exit button
* [general] flyout: implement double click handling
* Localization
* [Generel] Flyout: Re-implement flyout launching, add workaround: disable flyout hiding in case the user switches on modules on the all apps page
+ minor changes
* [general] flyout: restore the context menu when right clicking on system tray icon
* Fix spellchecker
* [installer] fixing missing dll files + suppress error on not signed script
* Fix spell checker
* Fix flyout not focusing when activated
* Refresh Settings UI enabled state when flyout changes
* fix spellcheck
* Remove VCM from the list
* [General] flyout: fix settings window opening. Switch to general page only if there is no page opened
* [general] flyout: add launching hosts app
* Fix CI build
* adding check on elevation when launching hosts
* Use localization strings that already exist
* Remove dll not present in arm64 build
* Adding GPO policy check for the launcher page items
* fix hosts launching
* Add telemetry
* Also hide from all apps list when gpo is force enabling
* fix spellchecker
* Improve focus issues
* Fix flickering Bitmap Icons
* Fix telemetry error
* Fix telemetry call
* Fix wrong comment
---------
Co-authored-by: Stefan Markovic <stefan@janeasystems.com >
Co-authored-by: Laszlo Nemeth <laszlo.nemeth.hu@gmail.com >
Co-authored-by: Jaime Bernardo <jaime@janeasystems.com >
2023-01-30 23:00:11 +00:00
Stefan Markovic
27c4b1be0e
[settings-ui] Settings WinUI3 ( #17797 )
...
* Add Settings.WinUI3 project
* New namespace
* Activation and Services
* Assets and Behaviors
* Converters and Helpers
* Controls
* View and ViewModels
* Styles and Themes
* OOBE
* Strings
* Small App moves
* [check] Project files - publish profiles and launchSettings.json
* [using:Microsoft.UI.Xaml.Automation]AutomationProperties.Name workaround
* [WIP] Workarounds to make it work
* Fix suppressed warnings - naming
* Add code analysis
* Fix KBMPage and App dispatcher
Fix MessageBox - replace with MessageDialog
* Fix ImageResizerPage & mark ColorPickerButton with TODO
* Add icon to windows
Cleanup MainWindow.xaml.cs and OobeWindow.xaml.cs
MainWindows and OobeWindow management
* App Icon
No framework and runtime subdirs
* Remove PowerToys.Settings and Settings.UI from solution
Update output paths
* Installer work & publish.cmd
* Fix dispatcher crashes
* Fix crashes
* Add all dlls to installer
Cleanup installer
Add OpenOOBE and OpenScoobe logic
Fix minor issues
Fix update scenario - REINSTALLMODE
* Rename back namespaces, project name and project dir
* [wip] move to winappsdk 1.1
* Fix propagating isElevated & installer runtimes dlls
* Remove obsolete dir/file
* PowerToys.Interop to netstandard2.0
* Move everything to .Net6
* [Settings] Always launch settings process non-elevated (#17791 )
* Move back to WinAppSdk 1.0.1
* Add Settings.WinUI3 project
* New namespace
* Activation and Services
* Assets and Behaviors
* Converters and Helpers
* Controls
* View and ViewModels
* Styles and Themes
* OOBE
* Strings
* Small App moves
* [check] Project files - publish profiles and launchSettings.json
* [using:Microsoft.UI.Xaml.Automation]AutomationProperties.Name workaround
* [WIP] Workarounds to make it work
* Fix suppressed warnings - naming
* Add code analysis
* Fix KBMPage and App dispatcher
Fix MessageBox - replace with MessageDialog
* Fix ImageResizerPage & mark ColorPickerButton with TODO
* Add icon to windows
Cleanup MainWindow.xaml.cs and OobeWindow.xaml.cs
MainWindows and OobeWindow management
* App Icon
No framework and runtime subdirs
* Remove PowerToys.Settings and Settings.UI from solution
Update output paths
* Installer work & publish.cmd
* Fix dispatcher crashes
* Fix crashes
* Add all dlls to installer
Cleanup installer
Add OpenOOBE and OpenScoobe logic
Fix minor issues
Fix update scenario - REINSTALLMODE
* Rename back namespaces, project name and project dir
* [wip] move to winappsdk 1.1
* Fix propagating isElevated & installer runtimes dlls
* Remove obsolete dir/file
* PowerToys.Interop to netstandard2.0
* Move everything to .Net6
* [Settings] Always launch settings process non-elevated (#17791 )
* Move back to WinAppSdk 1.0.1
* Revert merge conflict ARM64 removal
* Fix KBM Browse overlay image button
* Bring back settings publish profile
* Update release.yml
* Change target frameworkd windows version
* [Setup] Add Windows Application Runtime SDK (#17809 )
* Update requirements doc
* Update compiling docs
* Fix signing
* Fix Settings exe and dll versions
* Add exception for dlls that have version 1.0.0.0
* Fix powershell condition
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com >
2022-04-19 21:00:28 +01:00
Stefan Markovic
073caffef4
[Settings, Common.UI, runner exe] Unify exe/dll naming ( #15005 )
...
* Unify exe/dll naming - PowerToys.Runner
Align naming with other exes - PowerToys Runner -> PowerToys.Runner
* Unify exe/dll naming - Microsoft.PowerToys.Common.UI
Project name - Microsoft.PowerToys.Common.UI -> Common.UI
dll name - Microsoft.PowerToys.Common.UI.dll -> PowerToys.Common.UI.dll
* Unify exe/dll naming - Settings
Project names - Microsoft.PowerToys.Settings* -> Settings*
Dll names - Microsoft.PowerToys.Settings*.dll -> PowerToys.Settings*.dll
* Revert file autoformat
* [Docs] Update paths to settings projects/files
* Fix tests - Update path
2021-12-15 12:56:52 +01:00
