Josh Soref
bf16e10baf
Updates for check-spelling v0.0.25 ( #40386 )
...
## Summary of the Pull Request
- #39572 updated check-spelling but ignored:
> 🐣 Breaking Changes
[Code Scanning action requires a Code Scanning
Ruleset](https://github.com/check-spelling/check-spelling/wiki/Breaking-Change:-Code-Scanning-action-requires-a-Code-Scanning-Ruleset )
If you use SARIF reporting, then instead of the workflow yielding an ❌
when it fails, it will rely on [github-advanced-security
🤖 ](https://github.com/apps/github-advanced-security ) to report the
failure. You will need to adjust your checks for PRs.
This means that check-spelling hasn't been properly doing its job 😦 .
I'm sorry, I should have pushed a thing to this repo earlier,...
Anyway, as with most refreshes, this comes with a number of fixes, some
are fixes for typos that snuck in before the 0.0.25 upgrade, some are
for things that snuck in after, some are based on new rules in
spell-check-this, and some are hand written patterns based on running
through this repository a few times.
About the 🐣 **breaking change**: someone needs to create a ruleset for
this repository (see [Code Scanning action requires a Code Scanning
Ruleset: Sample ruleset
](https://github.com/check-spelling/check-spelling/wiki/Breaking-Change:-Code-Scanning-action-requires-a-Code-Scanning-Ruleset#sample-ruleset )).
The alternative to adding a ruleset is to change the condition to not
use sarif for this repository. In general, I think the github
integration from sarif is prettier/more helpful, so I think that it's
the better choice.
You can see an example of it working in:
- https://github.com/check-spelling-sandbox/PowerToys/pull/23
---------
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
Co-authored-by: Mike Griese <migrie@microsoft.com >
Co-authored-by: Dustin L. Howett <dustin@howett.net >
2025-07-08 17:16:52 -05:00
Kai Tao
498ef676f4
Runner: Add log when error happen in setting startup ( #39801 )
...
<!-- Enter a brief description/summary of your PR here. What does it
fix/what does it change/how was it tested (even manually, if necessary)?
-->
## Summary of the Pull Request
Add log when error happen in setting startup
<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
- [X] **Closes:** #39798
- [ ] **Communication:** I've discussed this with core contributors
already. If work hasn't been agreed, this work might be rejected
- [X] **Tests:** Added/updated and all pass
- [ ] **Localization:** All end user facing strings can be localized
- [ ] **Dev docs:** Added/updated
- [ ] **New binaries:** Added on the required places
- [ ] [JSON for
signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json )
for new binaries
- [ ] [WXS for
installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs )
for new binaries and localization folder
- [ ] [YML for CI
pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml )
for new test projects
- [ ] [YML for signed
pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml )
- [ ] **Documentation updated:** If checked, please file a pull request
on [our docs
repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys )
and link it here: #xxx
<!-- Provide a more detailed description of the PR, other things fixed
or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments
<!-- Describe how you validated the behavior. Add automated tests
wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
Set error in code deliberately, and verify that the error appears in the
log.
2025-05-30 10:03:36 +08:00
Jaime Bernardo
f0b460312a
[Build]Fix building on Visual Studio 17.8 ( #29303 )
...
* Add definition to ignore deprecated stdext checked_array_iterator
* Disable warning to ignore direct mention of dll in C# headers
* Fix PowerAccent Keyboard Service build errors
* Remove unused event variables
* Fix uninitialized events
* Remove unused telemetry events
* Fix building ShortcutGuide
* Fix C-style casts
* Fix spellcheck
2023-10-19 15:04:09 +01:00
Laszlo Nemeth
03a5a4200e
[Installer] add priority settings to the task scheduler PT task. ( #27058 )
...
* Installer: add priority settings to the task scheduler PT task.
* Add priority settings for task creation (for Task Scheduler) to the runner as well
* Modifying priority value
2023-06-30 15:23:02 +02:00
sosssego
9168f871af
[Analyzers][CPP]Changes to fix warning 26493 on src/runner ( #23672 )
...
* Changes to fix warning 26493 on src/runner
* formating
2023-02-08 11:17:33 +00:00
Andrey Nekrasov
063e704321
build: Treat warnings as errors in the remaining projects ( #8689 )
...
* build: remove #pragma comment(lib
* build: treat warnings as errors for all src projects
2020-12-21 18:51:48 +03:00
Josh Soref
0bcaa13056
Spelling: ... runner settings ( #3783 )
...
* spelling: default
* spelling: elevated
* spelling: instance
* spelling: relative
2020-05-27 17:06:50 +02:00
Nghia M. Luong
c768b6bd0c
Remove unused headers ( #2471 )
2020-04-30 20:14:33 +03:00
PrzemyslawTusinski
72eb76191f
Fixed issue with autostarting as admin even if it should as user, fixed issue with autostart permissions bug ( #1538 )
...
* Fixed issue with autostarting as admin even if it should as user, fixed permissions issue for autostart configuration
* Indentation fix
* Added support for all cases of autostart task modifying
* Fix for compilation
2020-03-17 11:04:45 +01:00
Enrico Giordani
415a0cdf28
Coding style (runner) ( #1013 )
2019-12-26 17:26:11 +01:00
Bartosz Sosnowski
8431b80e48
FancyZones and Shortcut Guide initial commit
...
Co-authored-by: Alexis Campailla <alexis@janeasystems.com >
Co-authored-by: Bret Anderson <bretan@microsoft.com >
Co-authored-by: Enrico Giordani <enrico.giordani@gmail.com >
Co-authored-by: Jaime Bernardo <jaime@janeasystems.com >
Co-authored-by: Jeff Bogdan <jeffbog@microsoft.com >
Co-authored-by: March Rogers <marchr@microsoft.com >
Co-authored-by: Mike Harsh <mharsh@microsoft.com >
Co-authored-by: Nachum Bundak <Nachum.Bundak@microsoft.com >
Co-authored-by: Oliver Jones <ojones@microsoft.com >
Co-authored-by: Patrick Little <plittle@microsoft.com >
2019-09-05 18:12:40 +02:00
