From fe5bb1d8850a0ea9cf25bd2990ee27aa266a1758 Mon Sep 17 00:00:00 2001 From: bao-qian Date: Fri, 6 May 2016 01:55:30 +0100 Subject: [PATCH] parallel foreach + list is not thread safe --- Wox.Core/Plugin/PluginConfig.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Wox.Core/Plugin/PluginConfig.cs b/Wox.Core/Plugin/PluginConfig.cs index 8fb851c220..075bf27071 100644 --- a/Wox.Core/Plugin/PluginConfig.cs +++ b/Wox.Core/Plugin/PluginConfig.cs @@ -31,7 +31,8 @@ namespace Wox.Core.Plugin private static void ParsePluginConfigs(IEnumerable directories) { - Parallel.ForEach(directories, directory => + // todo use linq when diable plugin is implmented since parallel.foreach + list is not thread saft + foreach (var directory in directories) { if (File.Exists(Path.Combine(directory, "NeedDelete.txt"))) { @@ -52,7 +53,7 @@ namespace Wox.Core.Plugin PluginMetadatas.Add(metadata); } } - }); + } } private static PluginMetadata GetPluginMetadata(string pluginDirectory)