Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2025-12-16 11:48:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Test]Fix flaky markdown preview test (#18840)

Browse Source
This commit is contained in:
Jaime Bernardo
2022-06-15 00:30:33 +01:00
committed by GitHub
parent 244394865f
commit fdc813a5ca
2 changed files with 17 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/modules/previewpane/UnitTests-MarkdownPreviewHandler/MarkdownPreviewHandlerTest.cs
View File

@@ -16,7 +16,8 @@ namespace MarkdownPreviewHandlerUnitTests
[STATestClass] [STATestClass]
public class MarkdownPreviewHandlerTest public class MarkdownPreviewHandlerTest
{ {
private static readonly int TenSecondsInMilliseconds = 10000; // A long timeout is needed. WebView2 can take a long time to load the first time in some CI systems.
private static readonly int HardTimeoutInMilliseconds = 30000;
private static readonly int SleepTimeInMilliseconds = 200; private static readonly int SleepTimeInMilliseconds = 200;
[TestMethod] [TestMethod]
@@ -30,7 +31,7 @@ namespace MarkdownPreviewHandlerUnitTests
int beforeTick = Environment.TickCount; int beforeTick = Environment.TickCount;
while (markdownPreviewHandlerControl.Controls.Count == 0 && Environment.TickCount < beforeTick + TenSecondsInMilliseconds) while (markdownPreviewHandlerControl.Controls.Count == 0 && Environment.TickCount < beforeTick + HardTimeoutInMilliseconds)
{ {
Application.DoEvents(); Application.DoEvents();
Thread.Sleep(SleepTimeInMilliseconds); Thread.Sleep(SleepTimeInMilliseconds);
@@ -53,7 +54,7 @@ namespace MarkdownPreviewHandlerUnitTests
int beforeTick = Environment.TickCount; int beforeTick = Environment.TickCount;
while (markdownPreviewHandlerControl.Controls.Count == 0 && Environment.TickCount < beforeTick + TenSecondsInMilliseconds) while (markdownPreviewHandlerControl.Controls.Count == 0 && Environment.TickCount < beforeTick + HardTimeoutInMilliseconds)
{ {
Application.DoEvents(); Application.DoEvents();
Thread.Sleep(SleepTimeInMilliseconds); Thread.Sleep(SleepTimeInMilliseconds);
@@ -76,7 +77,7 @@ namespace MarkdownPreviewHandlerUnitTests
int beforeTick = Environment.TickCount; int beforeTick = Environment.TickCount;
while (markdownPreviewHandlerControl.Controls.Count < 2 && Environment.TickCount < beforeTick + TenSecondsInMilliseconds) while (markdownPreviewHandlerControl.Controls.Count < 2 && Environment.TickCount < beforeTick + HardTimeoutInMilliseconds)
{ {
Application.DoEvents(); Application.DoEvents();
Thread.Sleep(SleepTimeInMilliseconds); Thread.Sleep(SleepTimeInMilliseconds);
@@ -99,7 +100,7 @@ namespace MarkdownPreviewHandlerUnitTests
int beforeTick = Environment.TickCount; int beforeTick = Environment.TickCount;
while (markdownPreviewHandlerControl.Controls.Count == 0 && Environment.TickCount < beforeTick + TenSecondsInMilliseconds) while (markdownPreviewHandlerControl.Controls.Count == 0 && Environment.TickCount < beforeTick + HardTimeoutInMilliseconds)
{ {
Application.DoEvents(); Application.DoEvents();
Thread.Sleep(SleepTimeInMilliseconds); Thread.Sleep(SleepTimeInMilliseconds);
@@ -122,7 +123,7 @@ namespace MarkdownPreviewHandlerUnitTests
int beforeTick = Environment.TickCount; int beforeTick = Environment.TickCount;
while (markdownPreviewHandlerControl.Controls.Count < 2 && Environment.TickCount < beforeTick + TenSecondsInMilliseconds) while (markdownPreviewHandlerControl.Controls.Count < 2 && Environment.TickCount < beforeTick + HardTimeoutInMilliseconds)
{ {
Application.DoEvents(); Application.DoEvents();
Thread.Sleep(SleepTimeInMilliseconds); Thread.Sleep(SleepTimeInMilliseconds);
@@ -145,7 +146,7 @@ namespace MarkdownPreviewHandlerUnitTests
int beforeTick = Environment.TickCount; int beforeTick = Environment.TickCount;
while (markdownPreviewHandlerControl.Controls.Count == 0 && Environment.TickCount < beforeTick + TenSecondsInMilliseconds) while (markdownPreviewHandlerControl.Controls.Count == 0 && Environment.TickCount < beforeTick + HardTimeoutInMilliseconds)
{ {
Application.DoEvents(); Application.DoEvents();
Thread.Sleep(SleepTimeInMilliseconds); Thread.Sleep(SleepTimeInMilliseconds);

17
src/modules/previewpane/UnitTests-SvgPreviewHandler/SvgPreviewControlTests.cs
View File

@@ -21,7 +21,8 @@ namespace SvgPreviewHandlerUnitTests
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2201:Do not raise reserved exception types", Justification = "new Exception() is fine in test projects.")] [System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2201:Do not raise reserved exception types", Justification = "new Exception() is fine in test projects.")]
public class SvgPreviewControlTests public class SvgPreviewControlTests
{ {
private static readonly int ThreeSecondsInMilliseconds = 3000; // A long timeout is needed. WebView2 can take a long time to load the first time in some CI systems.
private static readonly int HardTimeoutInMilliseconds = 30000;
private static readonly int SleepTimeInMilliseconds = 200; private static readonly int SleepTimeInMilliseconds = 200;
[TestMethod] [TestMethod]
@@ -35,7 +36,7 @@ namespace SvgPreviewHandlerUnitTests
int beforeTick = Environment.TickCount; int beforeTick = Environment.TickCount;
while (svgPreviewControl.Controls.Count == 0 && Environment.TickCount < beforeTick + ThreeSecondsInMilliseconds) while (svgPreviewControl.Controls.Count == 0 && Environment.TickCount < beforeTick + HardTimeoutInMilliseconds)
{ {
Application.DoEvents(); Application.DoEvents();
Thread.Sleep(SleepTimeInMilliseconds); Thread.Sleep(SleepTimeInMilliseconds);
@@ -58,7 +59,7 @@ namespace SvgPreviewHandlerUnitTests
int beforeTick = Environment.TickCount; int beforeTick = Environment.TickCount;
while (svgPreviewControl.Controls.Count == 0 && Environment.TickCount < beforeTick + ThreeSecondsInMilliseconds) while (svgPreviewControl.Controls.Count == 0 && Environment.TickCount < beforeTick + HardTimeoutInMilliseconds)
{ {
Application.DoEvents(); Application.DoEvents();
Thread.Sleep(SleepTimeInMilliseconds); Thread.Sleep(SleepTimeInMilliseconds);
@@ -85,7 +86,7 @@ namespace SvgPreviewHandlerUnitTests
int beforeTick = Environment.TickCount; int beforeTick = Environment.TickCount;
while (svgPreviewControl.Controls.Count == 0 && Environment.TickCount < beforeTick + ThreeSecondsInMilliseconds) while (svgPreviewControl.Controls.Count == 0 && Environment.TickCount < beforeTick + HardTimeoutInMilliseconds)
{ {
Application.DoEvents(); Application.DoEvents();
Thread.Sleep(SleepTimeInMilliseconds); Thread.Sleep(SleepTimeInMilliseconds);
@@ -119,7 +120,7 @@ namespace SvgPreviewHandlerUnitTests
int beforeTick = Environment.TickCount; int beforeTick = Environment.TickCount;
while (svgPreviewControl.Controls.Count == 0 && Environment.TickCount < beforeTick + ThreeSecondsInMilliseconds) while (svgPreviewControl.Controls.Count == 0 && Environment.TickCount < beforeTick + HardTimeoutInMilliseconds)
{ {
Application.DoEvents(); Application.DoEvents();
Thread.Sleep(SleepTimeInMilliseconds); Thread.Sleep(SleepTimeInMilliseconds);
@@ -156,7 +157,7 @@ namespace SvgPreviewHandlerUnitTests
int beforeTick = Environment.TickCount; int beforeTick = Environment.TickCount;
while (svgPreviewControl.Controls.Count < 2 && Environment.TickCount < beforeTick + ThreeSecondsInMilliseconds) while (svgPreviewControl.Controls.Count < 2 && Environment.TickCount < beforeTick + HardTimeoutInMilliseconds)
{ {
Application.DoEvents(); Application.DoEvents();
Thread.Sleep(SleepTimeInMilliseconds); Thread.Sleep(SleepTimeInMilliseconds);
@@ -186,7 +187,7 @@ namespace SvgPreviewHandlerUnitTests
int beforeTick = Environment.TickCount; int beforeTick = Environment.TickCount;
while (svgPreviewControl.Controls.Count == 0 && Environment.TickCount < beforeTick + ThreeSecondsInMilliseconds) while (svgPreviewControl.Controls.Count == 0 && Environment.TickCount < beforeTick + HardTimeoutInMilliseconds)
{ {
Application.DoEvents(); Application.DoEvents();
Thread.Sleep(SleepTimeInMilliseconds); Thread.Sleep(SleepTimeInMilliseconds);
@@ -212,7 +213,7 @@ namespace SvgPreviewHandlerUnitTests
int beforeTick = Environment.TickCount; int beforeTick = Environment.TickCount;
while (svgPreviewControl.Controls.Count == 0 && Environment.TickCount < beforeTick + ThreeSecondsInMilliseconds) while (svgPreviewControl.Controls.Count == 0 && Environment.TickCount < beforeTick + HardTimeoutInMilliseconds)
{ {
Application.DoEvents(); Application.DoEvents();
Thread.Sleep(SleepTimeInMilliseconds); Thread.Sleep(SleepTimeInMilliseconds);