Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2026-04-05 18:57:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

adding in FxCop to Svg tests (#6111)

Browse Source
This commit is contained in:
Clint Rutkas
2020-08-21 17:23:42 -07:00
committed by GitHub
parent 9c6b2c3e81
commit f64df97652
6 changed files with 102 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/modules/previewpane/UnitTests-SvgPreviewHandler/SvgPreviewControlTests.cs
View File

@@ -14,13 +14,13 @@ using Moq;
using PreviewHandlerCommon;
using SvgPreviewHandler;
namespace UnitTests_SvgPreviewHandler
namespace SvgPreviewHandlerUnitTests
{
[TestClass]
public class SvgPreviewControlTests
{
[TestMethod]
public void SvgPreviewControl_ShouldAddExtendedBrowserControl_WhenDoPreviewCalled()
public void SvgPreviewControlShouldAddExtendedBrowserControlWhenDoPreviewCalled()
{
// Arrange
using (var svgPreviewControl = new SvgPreviewControl())
@@ -35,7 +35,7 @@ namespace UnitTests_SvgPreviewHandler
}
[TestMethod]
public void SvgPreviewControl_ShouldSetDocumentStream_WhenDoPreviewCalled()
public void SvgPreviewControlShouldSetDocumentStreamWhenDoPreviewCalled()
{
// Arrange
using (var svgPreviewControl = new SvgPreviewControl())
@@ -49,7 +49,7 @@ namespace UnitTests_SvgPreviewHandler
}
[TestMethod]
public void SvgPreviewControl_ShouldDisableWebBrowserContextMenu_WhenDoPreviewCalled()
public void SvgPreviewControlShouldDisableWebBrowserContextMenuWhenDoPreviewCalled()
{
// Arrange
using (var svgPreviewControl = new SvgPreviewControl())
@@ -63,7 +63,7 @@ namespace UnitTests_SvgPreviewHandler
}
[TestMethod]
public void SvgPreviewControl_ShouldFillDockForWebBrowser_WhenDoPreviewCalled()
public void SvgPreviewControlShouldFillDockForWebBrowserWhenDoPreviewCalled()
{
// Arrange
using (var svgPreviewControl = new SvgPreviewControl())
@@ -77,7 +77,7 @@ namespace UnitTests_SvgPreviewHandler
}
[TestMethod]
public void SvgPreviewControl_ShouldSetScriptErrorsSuppressedProperty_WhenDoPreviewCalled()
public void SvgPreviewControlShouldSetScriptErrorsSuppressedPropertyWhenDoPreviewCalled()
{
// Arrange
using (var svgPreviewControl = new SvgPreviewControl())
@@ -91,7 +91,7 @@ namespace UnitTests_SvgPreviewHandler
}
[TestMethod]
public void SvgPreviewControl_ShouldSetScrollBarsEnabledProperty_WhenDoPreviewCalled()
public void SvgPreviewControlShouldSetScrollBarsEnabledPropertyWhenDoPreviewCalled()
{
// Arrange
using (var svgPreviewControl = new SvgPreviewControl())
@@ -105,7 +105,7 @@ namespace UnitTests_SvgPreviewHandler
}
[TestMethod]
public void SvgPreviewControl_ShouldDisableAllowNavigation_WhenDoPreviewCalled()
public void SvgPreviewControlShouldDisableAllowNavigationWhenDoPreviewCalled()
{
// Arrange
using (var svgPreviewControl = new SvgPreviewControl())
@@ -119,7 +119,7 @@ namespace UnitTests_SvgPreviewHandler
}
[TestMethod]
public void SvgPreviewControl_ShouldAddValidInfoBar_IfSvgPreviewThrows()
public void SvgPreviewControlShouldAddValidInfoBarIfSvgPreviewThrows()
{
// Arrange
using (var svgPreviewControl = new SvgPreviewControl())
@@ -146,7 +146,7 @@ namespace UnitTests_SvgPreviewHandler
}
[TestMethod]
public void SvgPreviewControl_InfoBarWidthShouldAdjustWithParentControlWidthChanges_IfSvgPreviewThrows()
public void SvgPreviewControlInfoBarWidthShouldAdjustWithParentControlWidthChangesIfSvgPreviewThrows()
{
// Arrange
using (var svgPreviewControl = new SvgPreviewControl())
@@ -172,7 +172,7 @@ namespace UnitTests_SvgPreviewHandler
}
[TestMethod]
public void SvgPreviewControl_ShouldAddTextBox_IfBlockedElementsArePresent()
public void SvgPreviewControlShouldAddTextBoxIfBlockedElementsArePresent()
{
// Arrange
using (var svgPreviewControl = new SvgPreviewControl())
@@ -193,7 +193,7 @@ namespace UnitTests_SvgPreviewHandler
}
[TestMethod]
public void SvgPreviewControl_ShouldNotAddTextBox_IfNoBlockedElementsArePresent()
public void SvgPreviewControlShouldNotAddTextBoxIfNoBlockedElementsArePresent()
{
// Arrange
using (var svgPreviewControl = new SvgPreviewControl())
@@ -214,7 +214,7 @@ namespace UnitTests_SvgPreviewHandler
}
[TestMethod]
public void SvgPreviewControl_InfoBarWidthShouldAdjustWithParentControlWidthChanges_IfBlockedElementsArePresent()
public void SvgPreviewControlInfoBarWidthShouldAdjustWithParentControlWidthChangesIfBlockedElementsArePresent()
{
// Arrange
using (var svgPreviewControl = new SvgPreviewControl())
@@ -239,7 +239,7 @@ namespace UnitTests_SvgPreviewHandler
}
}
private IStream GetMockStream(string streamData)
private static IStream GetMockStream(string streamData)
{
var mockStream = new Mock<IStream>();
var streamBytes = Encoding.UTF8.GetBytes(streamData);

12
src/modules/previewpane/UnitTests-SvgPreviewHandler/SvgPreviewHandlerHelperTests.cs
View File

@@ -6,13 +6,13 @@ using System.Text;
using Common.Utilities;
using Microsoft.VisualStudio.TestTools.UnitTesting;
namespace UnitTests_SvgPreviewHandler
namespace SvgPreviewHandlerUnitTests
{
[TestClass]
public class SvgPreviewHandlerHelperTests
{
[TestMethod]
public void CheckBlockedElements_ShouldReturnTrue_IfABlockedElementIsPresent()
public void CheckBlockedElementsShouldReturnTrueIfABlockedElementIsPresent()
{
// Arrange
var svgBuilder = new StringBuilder();
@@ -29,7 +29,7 @@ namespace UnitTests_SvgPreviewHandler
}
[TestMethod]
public void CheckBlockedElements_ShouldReturnTrue_IfBlockedElementsIsPresentInNestedLevel()
public void CheckBlockedElementsShouldReturnTrueIfBlockedElementsIsPresentInNestedLevel()
{
// Arrange
var svgBuilder = new StringBuilder();
@@ -48,7 +48,7 @@ namespace UnitTests_SvgPreviewHandler
}
[TestMethod]
public void CheckBlockedElements_ShouldReturnTrue_IfMultipleBlockedElementsArePresent()
public void CheckBlockedElementsShouldReturnTrueIfMultipleBlockedElementsArePresent()
{
// Arrange
var svgBuilder = new StringBuilder();
@@ -66,7 +66,7 @@ namespace UnitTests_SvgPreviewHandler
}
[TestMethod]
public void CheckBlockedElements_ShouldReturnFalse_IfNoBlockedElementsArePresent()
public void CheckBlockedElementsShouldReturnFalseIfNoBlockedElementsArePresent()
{
// Arrange
var svgBuilder = new StringBuilder();
@@ -87,7 +87,7 @@ namespace UnitTests_SvgPreviewHandler
[DataRow("")]
[DataRow(" ")]
[DataRow(null)]
public void CheckBlockedElements_ShouldReturnFalse_IfSvgDataIsNullOrWhiteSpaces(string svgData)
public void CheckBlockedElementsShouldReturnFalseIfSvgDataIsNullOrWhiteSpaces(string svgData)
{
// Arrange
bool foundFilteredElement;

8
src/modules/previewpane/UnitTests-SvgPreviewHandler/UnitTests-SvgPreviewHandler.csproj
View File

@@ -44,7 +44,7 @@
<ProjectGuid>{060D75DA-2D1C-48E6-A4A1-6F0718B64661}</ProjectGuid>
<OutputType>Library</OutputType>
<AppDesignerFolder>Properties</AppDesignerFolder>
<RootNamespace>UnitTests_SvgPreviewHandler</RootNamespace>
<RootNamespace>SvgPreviewHandlerUnitTests</RootNamespace>
<AssemblyName>UnitTests-SvgPreviewHandler</AssemblyName>
<TargetFrameworkVersion>v4.7.2</TargetFrameworkVersion>
<FileAlignment>512</FileAlignment>
@@ -82,7 +82,6 @@
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>
@@ -101,6 +100,11 @@
<Compile Include="SvgPreviewHandlerHelperTests.cs" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers">
<Version>3.3.0</Version>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="Moq">
<Version>4.14.5</Version>
</PackageReference>