mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-04-05 18:57:19 +02:00
[Light Switch] Hotfixes (#42434)
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Adds new "Off" mode for the schedule mode options which disable the schedule. Adds explicit function to disable light switch by default. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist Closes: - #42402 New behavior: "Off" mode added. when off, the regular service loop stops and all actions are event driven to either resume the loop or listen for hotkey. - #42386 New behavior: Disabled explicitly by default - #42389 New behavior: When switching from dark to light mode the system theme will remove the accent color. - #42513 New behavior: Manual mode no longer gets reset. It was being overridden by the sun calculations that were invertedly running when in manual mode. Todo: - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx @alvinashcraft we will need to add this new mode to the documentation. ## Validation Steps Performed - Removed all default settings and tested new logic. Light Switch is set to off by default. - Updated UI and tested new "Off" mode, logs indicate mode switched and ticker stopped. Polling resumes on mode change. (need to check that the shortcut still works) --------- Co-authored-by: Niels Laute <niels.laute@live.nl> Co-authored-by: Gordon Lam <73506701+yeelam-gordon@users.noreply.github.com>
This commit is contained in:
@@ -5269,12 +5269,18 @@ To record a specific window, enter the hotkey with the Alt key in the opposite m
|
||||
<data name="LightSwitch_ModeSettingsExpander.Description" xml:space="preserve">
|
||||
<value>Determine when dark mode should be turned on</value>
|
||||
</data>
|
||||
<data name="LightSwitch_ModeOff.Content" xml:space="preserve">
|
||||
<value>Off</value>
|
||||
</data>
|
||||
<data name="LightSwitch_ModeManual.Content" xml:space="preserve">
|
||||
<value>Manual</value>
|
||||
<value>Fixed hours</value>
|
||||
</data>
|
||||
<data name="LightSwitch_ModeSunsetToSunrise.Content" xml:space="preserve">
|
||||
<value>Sunset to sunrise</value>
|
||||
</data>
|
||||
<data name="LightSwitch_ScheduleOffMessage.Title" xml:space="preserve">
|
||||
<value>Scheduling is turned off.</value>
|
||||
</data>
|
||||
<data name="LightSwitch_TurnOnDarkMode.Header" xml:space="preserve">
|
||||
<value>Turn on dark mode</value>
|
||||
</data>
|
||||
|
||||
Reference in New Issue
Block a user