Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2025-12-16 03:37:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

[CPP][Analyzers] turn on warning 4189 (#21522)

Browse Source 
* Turn on 4189 and fix code

* changes from PR comments
This commit is contained in:
sosssego
2022-11-14 22:15:58 +00:00
committed by GitHub
parent 0a19f0dfc7
commit f408c34aca
14 changed files with 24 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
tools/BugReportTool/BugReportTool/InstallationFolder.cpp
View File

@@ -62,7 +62,6 @@ optional<path> GetRootPath()
wstring GetChecksum(path filePath)
{
DWORD dwStatus = 0;
BOOL bResult = FALSE;
HCRYPTPROV hProv = 0;
HCRYPTHASH hHash = 0;

4
tools/BugReportTool/BugReportTool/RegistryUtils.cpp
View File

@@ -57,7 +57,7 @@ namespace
vector<pair<wstring, wstring>> QueryValues(HKEY key)
{
DWORD cValues;
DWORD retCode = RegQueryInfoKeyW(key, nullptr, nullptr, nullptr, nullptr, nullptr, nullptr, &cValues, nullptr, nullptr, nullptr, nullptr);
RegQueryInfoKeyW(key, nullptr, nullptr, nullptr, nullptr, nullptr, nullptr, &cValues, nullptr, nullptr, nullptr, nullptr);
TCHAR achValue[255];
DWORD cchValue = 255;
LPBYTE value;
@@ -282,7 +282,7 @@ void ReportRegistry(const filesystem::path& tmpDir)
{
DWORD data = 0;
DWORD dataSize = sizeof(data);
LONG retCode = RegGetValueW(rootKey, subKey.c_str(), value.c_str(), flags, &type, &data, &dataSize);
result = RegGetValueW(rootKey, subKey.c_str(), value.c_str(), flags, &type, &data, &dataSize);
if (result == ERROR_SUCCESS)
{
registryReport << "\t" << value << " > " << data << "\n";