Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2026-04-06 19:26:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

[CPP][Analyzers] turn on warning 4189 (#21522)

Browse Source 
* Turn on 4189 and fix code

* changes from PR comments
This commit is contained in:
sosssego
2022-11-14 22:15:58 +00:00
committed by GitHub
parent 0a19f0dfc7
commit f408c34aca
14 changed files with 24 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/common/updating/updating.cpp
View File

@@ -57,7 +57,7 @@ namespace updating
const bool architecture_matched = filename_lower.find(required_architecture) != std::wstring::npos;
const bool filename_matched = filename_lower.find(required_filename_pattern) != std::wstring::npos;
const bool asset_matched = extension_matched && architecture_matched && filename_matched;
if (extension_matched && architecture_matched && filename_matched)
if (asset_matched)
{
return std::make_pair(Uri{ asset.GetNamedString(L"browser_download_url") }, std::move(filename_lower));
}