Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2026-04-05 10:46:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

Revert "[FxCop] Telemetry.csproj" (#6690)

Browse Source 
* Revert "marking all warnings (#6642)"

This reverts commit b0f0940534.

* Added warning comment
This commit is contained in:
Arjun Balgovind
2020-09-17 14:02:25 -07:00
committed by GitHub
parent b5cc24fcff
commit f19bad3761
4 changed files with 8 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/common/ManagedTelemetry/Telemetry/Events/EventBase.cs
View File

@@ -14,8 +14,6 @@ namespace Microsoft.PowerToys.Telemetry.Events
[EventData]
public class EventBase
{
[System.Diagnostics.CodeAnalysis.SuppressMessage("Naming", "CA1707:Identifiers should not contain underscores", Justification = "Part of telem, can't adjust")]
[System.Diagnostics.CodeAnalysis.SuppressMessage("Performance", "CA1822:Mark members as static", Justification = "Part of telem, can't adjust")]
public bool UTCReplace_AppSessionGuid => true;
private string _version;
@@ -33,12 +31,11 @@ namespace Microsoft.PowerToys.Telemetry.Events
}
}
private static string GetVersionFromAssembly()
private string GetVersionFromAssembly()
{
// For consistency this should be formatted the same way as
// https://github.com/microsoft/PowerToys/blob/710f92d99965109fd788d85ebf8b6b9e0ba1524a/src/common/common.cpp#L635
var version = Assembly.GetExecutingAssembly()?.GetName()?.Version ?? new Version();
return $"v{version.Major}.{version.Minor}.{version.Build}";
}
}

1
src/common/ManagedTelemetry/Telemetry/Events/IEvent.cs
View File

@@ -6,7 +6,6 @@ namespace Microsoft.PowerToys.Telemetry.Events
{
public interface IEvent
{
[System.Diagnostics.CodeAnalysis.SuppressMessage("Naming", "CA1707:Identifiers should not contain underscores", Justification = "Part of telem, can't adjust")]
PartA_PrivTags PartA_PrivTags { get; }
}
}

6
src/common/ManagedTelemetry/Telemetry/Telemetry.csproj
View File

@@ -32,12 +32,6 @@
<PrivateAssets>all</PrivateAssets>
</PackageReference>
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.3.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</ItemGroup>
<ItemGroup>
<Compile Include="..\..\..\codeAnalysis\GlobalSuppressions.cs">
<Link>GlobalSuppressions.cs</Link>