mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-04-03 01:36:31 +02:00
Fix for CmdPal settings page offset (#46568)
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request This is a weird bug in WinUI where a child panel gets a weird offset when wrapped in a `ScrollViewer` and if it has a `MaxWidth`. The solution is to wrap it with another panel 🤷 Top: with fix Bottom: 0.98.1 <img width="1351" height="1259" alt="image" src="https://github.com/user-attachments/assets/076ac947-58d1-4031-8be3-300a8511a636" /> <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #46238 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Jiří Polášek <me@jiripolasek.com>
This commit is contained in:
@@ -13,8 +13,10 @@
|
||||
mc:Ignorable="d">
|
||||
<Grid>
|
||||
<ScrollViewer AutomationProperties.AutomationId="PageScrollViewer">
|
||||
<!-- Wrapper Grid required to work around WinUI ScrollViewer + MaxWidth layout offset issue. Do not remove. -->
|
||||
<Grid>
|
||||
<Grid
|
||||
MaxWidth="1000"
|
||||
MaxWidth="{StaticResource PageMaxWidth}"
|
||||
Padding="16,0,16,0"
|
||||
VerticalAlignment="Top"
|
||||
Background="{ThemeResource CardBackgroundFillColorDefaultBrush}"
|
||||
@@ -216,6 +218,7 @@
|
||||
IsEnabled="{x:Bind ViewModel.IsEnabled, Mode=OneWay}" />
|
||||
</StackPanel>
|
||||
</Grid>
|
||||
</Grid>
|
||||
</ScrollViewer>
|
||||
</Grid>
|
||||
</local:NavigablePage>
|
||||
|
||||
Reference in New Issue
Block a user