Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2026-04-04 02:06:36 +02:00
Code Issues Packages Projects Releases Wiki Activity

[Registry Preview] Adds application to Open with list for REG files (#26033)

Browse Source 
* 25834

* Asociate Registry Preview with .reg files

* Add setting for making RP default app for .reg files

* Run spellcheck

* Run spellcheck again

* Fix build

---------

Co-authored-by: Stefan Markovic <stefan@janeasystems.com>
This commit is contained in:
Randy
2023-06-10 15:02:53 -07:00
committed by GitHub
parent b6ff97f795
commit eddb617484
13 changed files with 246 additions and 93 deletions
Download Patch File Download Diff File Expand all files Collapse all files

85
src/modules/registrypreview/RegistryPreviewExt/dllmain.cpp
View File

@@ -37,11 +37,19 @@ BOOL APIENTRY DllMain(HMODULE /*hModule*/, DWORD ul_reason_for_call, LPVOID /*lp
const static wchar_t* MODULE_NAME = L"RegistryPreview";
const static wchar_t* MODULE_DESC = L"A quick little utility to visualize and edit complex Windows Registry files.";
namespace
{
const wchar_t JSON_KEY_PROPERTIES[] = L"properties";
const wchar_t JSON_KEY_ENABLED[] = L"enabled";
const wchar_t JSON_KEY_DEFAULT_APP[] = L"default_reg_app";
}
class RegistryPreviewModule : public PowertoyModuleIface
{
private:
bool m_enabled = false;
bool m_default_app = false;
//Hotkey m_hotkey;
HANDLE m_hProcess;
@@ -87,23 +95,70 @@ private:
TerminateProcess(m_hProcess, 1);
}
void parse_default_app_settings(PowerToysSettings::PowerToyValues settings)
{
const std::wstring installationDir = get_module_folderpath();
auto changeSet = getRegistryPreviewSetDefaultAppChangeSet(installationDir, true);
auto settingsObject = settings.get_raw_json();
if (settingsObject.GetView().Size())
{
auto default_app = settingsObject.GetNamedObject(JSON_KEY_PROPERTIES).GetNamedBoolean(JSON_KEY_DEFAULT_APP);
if (default_app != m_default_app)
{
m_default_app = default_app;
auto result = default_app ? changeSet.apply() : changeSet.unApply();
if (!result)
{
Logger::error(L"Failed to {} default app registry change set.", default_app ? L"apply" : L"unapply");
}
SHChangeNotify(SHCNE_ASSOCCHANGED, SHCNF_IDLIST, NULL, NULL);
}
}
else
{
Logger::info("Registry Preview settings are empty");
}
}
// Load the settings file.
void init_settings()
{
try
{
// Load and parse the settings file for this PowerToy.
PowerToysSettings::PowerToyValues settings =
PowerToysSettings::PowerToyValues::load_from_settings_file(get_key());
auto enabled = settings.get_bool_value(JSON_KEY_ENABLED);
auto result = true;
const std::wstring installationDir = get_module_folderpath();
auto enabledChangeSet = getRegistryPreviewChangeSet(installationDir, true);
result = enabled ? enabledChangeSet.apply() : enabledChangeSet.unApply();
if (!result)
{
Logger::error(L"Failed to {} enabled registry change set.", enabled ? L"apply" : L"unapply");
}
parse_default_app_settings(settings);
}
catch (std::exception&)
{
Logger::error("Invalid json when trying to load the Registry Preview settings json from file.");
}
}
public:
RegistryPreviewModule()
{
LoggerHelpers::init_logger(GET_RESOURCE_STRING(IDS_REGISTRYPREVIEW_NAME), L"ModuleInterface", "RegistryPreview");
Logger::info("Registry Preview object is constructing");
if (!m_enabled)
{
const std::wstring installationDir = get_module_folderpath();
auto regChanges = getRegistryPreviewChangeSet(installationDir, true);
if (!regChanges.unApply())
{
Logger::error(L"Unapplying registry changes failed");
}
}
init_settings();
triggerEvent = CreateEvent(nullptr, false, false, CommonSharedConstants::REGISTRY_PREVIEW_TRIGGER_EVENT);
triggerEventWaiter = EventWaiter(CommonSharedConstants::REGISTRY_PREVIEW_TRIGGER_EVENT, [this](int) {
@@ -184,13 +239,13 @@ public:
// Parse the input JSON string.
PowerToysSettings::PowerToyValues values = PowerToysSettings::PowerToyValues::from_json_string(config, get_key());
// If you don't need to do any custom processing of the settings, proceed
// to persists the values.
parse_default_app_settings(values);
values.save_to_settings_file();
}
catch (std::exception&)
{
// Improper JSON.
Logger::error(L"Invalid json when trying to parse Registry Preview settings json.");
}
}
@@ -226,6 +281,8 @@ public:
{
Logger::error(L"Unapplying registry changes failed");
}
SHChangeNotify(SHCNE_ASSOCCHANGED, SHCNF_IDLIST, NULL, NULL);
}
m_enabled = false;

47
src/modules/registrypreview/RegistryPreviewUI/App.xaml.cs
View File

@@ -6,6 +6,7 @@ using System;
using System.Diagnostics;
using System.Diagnostics.CodeAnalysis;
using Microsoft.UI.Xaml;
using Microsoft.Windows.AppLifecycle;
using Windows.ApplicationModel.Activation;
using LaunchActivatedEventArgs = Windows.ApplicationModel.Activation.LaunchActivatedEventArgs;
@@ -31,23 +32,47 @@ namespace RegistryPreview
/// <param name="args">Details about the launch request and process.</param>
protected override void OnLaunched(Microsoft.UI.Xaml.LaunchActivatedEventArgs args)
{
// Grab the command line parameters directly from the Environment since this is expected to be run
// via Context Menu of a REG file.
string[] cmdArgs = Environment.GetCommandLineArgs();
if (cmdArgs == null)
// Keeping commented out but this is invaluable for protocol activation testing.
// #if DEBUG
// System.Diagnostics.Debugger.Launch();
// #endif
// Open With... handler - gets activation arguments if they are available.
AppActivationArguments activatedArgs = AppInstance.GetCurrent().GetActivatedEventArgs();
if (activatedArgs.Kind == ExtendedActivationKind.File)
{
// Covers the double click exe scenario and treated as no file loaded
AppFilename = string.Empty;
}
else if (cmdArgs.Length == 2)
{
// GetCommandLineArgs() send in the called EXE as 0 and the selected filename as 1
AppFilename = cmdArgs[1];
if (activatedArgs.Data != null)
{
IFileActivatedEventArgs eventArgs = (IFileActivatedEventArgs)activatedArgs.Data;
if (eventArgs.Files.Count > 0)
{
AppFilename = eventArgs.Files[0].Path;
}
}
}
else
{
// Anything else should be treated as no file loaded
AppFilename = string.Empty;
// Right click on a REG file and selected Preview
// Grab the command line parameters directly from the Environment since this is expected to be run
// via Context Menu of a REG file.
string[] cmdArgs = Environment.GetCommandLineArgs();
if (cmdArgs == null)
{
// Covers the double click exe scenario and treated as no file loaded
AppFilename = string.Empty;
}
else if (cmdArgs.Length == 2)
{
// GetCommandLineArgs() send in the called EXE as 0 and the selected filename as 1
AppFilename = cmdArgs[1];
}
else
{
// Anything else should be treated as no file loaded
AppFilename = string.Empty;
}
}
// Start the application