mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-04-08 12:18:50 +02:00
[FancyZones]Fix snap by hotkey for single-zone layouts (#22373)
* unsnap window from previous work area when snapping by hotkey
This commit is contained in:
1
.github/actions/spell-check/expect.txt
vendored
1
.github/actions/spell-check/expect.txt
vendored
@@ -1859,6 +1859,7 @@ UIs
|
|||||||
Ulaanbaatar
|
Ulaanbaatar
|
||||||
ULARGE
|
ULARGE
|
||||||
ULONGLONG
|
ULONGLONG
|
||||||
|
unassign
|
||||||
uncompilable
|
uncompilable
|
||||||
UNCPRIORITY
|
UNCPRIORITY
|
||||||
UNDNAME
|
UNDNAME
|
||||||
|
|||||||
@@ -808,6 +808,15 @@ bool FancyZones::OnSnapHotkeyBasedOnZoneNumber(HWND window, DWORD vkCode) noexce
|
|||||||
auto workArea = m_workAreaHandler.GetWorkArea(VirtualDesktop::instance().GetCurrentVirtualDesktopId(), *currMonitorInfo);
|
auto workArea = m_workAreaHandler.GetWorkArea(VirtualDesktop::instance().GetCurrentVirtualDesktopId(), *currMonitorInfo);
|
||||||
if (m_windowMoveHandler.MoveWindowIntoZoneByDirectionAndIndex(window, vkCode, false /* cycle through zones */, workArea))
|
if (m_windowMoveHandler.MoveWindowIntoZoneByDirectionAndIndex(window, vkCode, false /* cycle through zones */, workArea))
|
||||||
{
|
{
|
||||||
|
// unassign from previous work area
|
||||||
|
for (auto& prevWorkArea : m_workAreaHandler.GetAllWorkAreas())
|
||||||
|
{
|
||||||
|
if (workArea != prevWorkArea)
|
||||||
|
{
|
||||||
|
prevWorkArea->UnsnapWindow(window);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
Trace::FancyZones::KeyboardSnapWindowToZone(workArea->GetLayout().get(), workArea->GetLayoutWindows().get());
|
Trace::FancyZones::KeyboardSnapWindowToZone(workArea->GetLayout().get(), workArea->GetLayoutWindows().get());
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -134,11 +134,7 @@ void WindowMoveHandler::MoveSizeStart(HWND window, HMONITOR monitor, POINT const
|
|||||||
auto workArea = workAreaMap.find(monitor);
|
auto workArea = workAreaMap.find(monitor);
|
||||||
if (workArea != workAreaMap.end())
|
if (workArea != workAreaMap.end())
|
||||||
{
|
{
|
||||||
const auto& layoutWindows = workArea->second->GetLayoutWindows();
|
workArea->second->UnsnapWindow(window);
|
||||||
if (layoutWindows)
|
|
||||||
{
|
|
||||||
layoutWindows->Dismiss(window);
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -289,6 +285,8 @@ void WindowMoveHandler::MoveSizeEnd(HWND window, const std::unordered_map<HMONIT
|
|||||||
AppZoneHistory::instance().RemoveAppLastZone(window, workAreaPtr->UniqueId(), guidStr.value());
|
AppZoneHistory::instance().RemoveAppLastZone(window, workAreaPtr->UniqueId(), guidStr.value());
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
workAreaPtr->UnsnapWindow(window);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -462,6 +462,22 @@ void WorkArea::SaveWindowProcessToZoneIndex(HWND window) noexcept
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
bool WorkArea::UnsnapWindow(HWND window) noexcept
|
||||||
|
{
|
||||||
|
if (!m_layoutWindows)
|
||||||
|
{
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!m_layoutWindows->GetZoneIndexSetFromWindow(window).empty())
|
||||||
|
{
|
||||||
|
m_layoutWindows->Dismiss(window);
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
ZoneIndexSet WorkArea::GetWindowZoneIndexes(HWND window) const noexcept
|
ZoneIndexSet WorkArea::GetWindowZoneIndexes(HWND window) const noexcept
|
||||||
{
|
{
|
||||||
if (m_layout)
|
if (m_layout)
|
||||||
|
|||||||
@@ -69,6 +69,7 @@ public:
|
|||||||
bool MoveWindowIntoZoneByDirectionAndPosition(HWND window, DWORD vkCode, bool cycle) noexcept;
|
bool MoveWindowIntoZoneByDirectionAndPosition(HWND window, DWORD vkCode, bool cycle) noexcept;
|
||||||
bool ExtendWindowByDirectionAndPosition(HWND window, DWORD vkCode) noexcept;
|
bool ExtendWindowByDirectionAndPosition(HWND window, DWORD vkCode) noexcept;
|
||||||
void SaveWindowProcessToZoneIndex(HWND window) noexcept;
|
void SaveWindowProcessToZoneIndex(HWND window) noexcept;
|
||||||
|
bool UnsnapWindow(HWND window) noexcept;
|
||||||
|
|
||||||
void UpdateActiveZoneSet() noexcept;
|
void UpdateActiveZoneSet() noexcept;
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user