diff --git a/.github/actions/spell-check/advice.md b/.github/actions/spell-check/advice.md new file mode 100644 index 0000000000..2a32b65207 --- /dev/null +++ b/.github/actions/spell-check/advice.md @@ -0,0 +1,27 @@ + +
If you see a bunch of garbage + +If it relates to a ... +
well-formed pattern + +See if there's a [pattern](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns) that would match it. + +If not, try writing one and adding it to the `patterns.txt` file. + +Patterns are Perl 5 Regular Expressions - you can [test]( +https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your lines. + +Note that patterns can't match multiline strings. +
+
binary-ish string + +Please add a file path to the `excludes.txt` file instead of just accepting the garbage. + +File paths are Perl 5 Regular Expressions - you can [test]( +https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your files. + +`^` refers to the file's path from the root of the repository, so `^README\.md$` would exclude [README.md]( +../tree/HEAD/README.md) (on whichever branch you're using). +
+ +
diff --git a/.github/actions/spell-check/excludes.txt b/.github/actions/spell-check/excludes.txt index f67ef73b90..2320d2b36e 100644 --- a/.github/actions/spell-check/excludes.txt +++ b/.github/actions/spell-check/excludes.txt @@ -21,9 +21,22 @@ ignore$ \.min\. \.mod$ \.pdf$ -\.png$ \.PNG$ +\.png$ \.woff$ \.zip$ +^src/common/logger/logger\.vcxproj\.filters$ +^src/common/notifications/BackgroundActivatorDLL/BackgroundActivator\.vcxproj\.filters$ +^src/common/notifications/BackgroundActivatorDLL/cpp\.hint$ +^src/modules/colorPicker/ColorPickerUI/Resources/colorPicker\.cur$ +^src/modules/fancyzones/lib/FancyZonesWinHookEventIDs\.h$ +^src/modules/imageresizer/dll/ContextMenuHandler\.rgs$ +^src/modules/imageresizer/dll/ImageResizerExt\.rgs$ +^src/modules/powerrename/testapp/PowerRenameTest\.vcxproj\.filters$ +^src/modules/powerrename/UWPui/pch\.h$ +^src/modules/powerrename/UWPui/PowerRenameUWPUI\.vcxproj\.filters$ +^src/modules/previewpane/PreviewPaneUnitTests/HelperFiles/MarkdownWithHTMLImageTag\.txt$ +^tools/CleanUp_tool/CleanUp_tool\.vcxproj\.filters$ ^\.github/ ^\.github/actions/spell-check/ +^\.gitmodules$ diff --git a/.github/actions/spell-check/expect.txt b/.github/actions/spell-check/expect.txt index 5b24af3dee..128a9c69e7 100644 --- a/.github/actions/spell-check/expect.txt +++ b/.github/actions/spell-check/expect.txt @@ -1,7 +1,9 @@ +aaaa aac abcd abcdef abcdefgh +ABCDEFGHIJKLMNOPQRSTUVWXYZ abgr ABlocked Abug @@ -19,6 +21,7 @@ Actioncenter actioned activatable ACTIVATEAPP +activationaction Addavirtualdesktop addrum ADDUNDORECORD @@ -112,6 +115,7 @@ aumid AUTHN AUTOAPPEND autocomplete +autogenerated autogenerates AUTOHIDE AUTOMATIONPROPERTIES @@ -201,6 +205,8 @@ cdpxwin CENTERALIGN cfg cguid +changecursor +Changemove charconv charset chdir @@ -212,7 +218,7 @@ CHILDWINDOW chrdavis Chris's chrono -chrzan +Chrzan CHT CImage cinttypes @@ -254,6 +260,8 @@ codereview Codespaces COINIT colorconv +colorhistory +colorhistorylimit colorpicker COLORREF colorscheme @@ -287,6 +295,7 @@ CONTROLL CONTROLPARENT Controlz coords +copiedcolorrepresentation cortana cotaskmem COULDNOT @@ -339,6 +348,7 @@ CUI currentculture CURSORINFO cursorpos +customaction CUSTOMACTIONTEST cvd cwchar @@ -438,7 +448,6 @@ DLIMAGES dll dllexport dllhost -dllimport dllmain DNLEN doctype @@ -822,6 +831,7 @@ IImage Iindex IInitialize IInspectable +IIO IItem IJson IKs @@ -830,6 +840,7 @@ ILogon IMAGEHLP imageresizer IMAGERESIZEREXT +imageresizersettings IMain IMarkdown ime @@ -969,6 +980,7 @@ jpeg jpg JPN json +JSONOf jsonval JSX junja @@ -1116,7 +1128,7 @@ LVS LVSIL LWA lwin -LZW +lzw mailto MAINICON Mainwindow @@ -1259,7 +1271,7 @@ NCMBUTTONDOWN NCMBUTTONUP NCMOUSELEAVE NCMOUSEMOVE -NCol +ncol NCPAINT NCRBUTTONDBLCLK NCRBUTTONDOWN @@ -1272,6 +1284,7 @@ NESW netcore netcoreapp netframework +NETFX netsh netstandard Neue @@ -1338,6 +1351,7 @@ npm npos NResize ntdll +NTFS NTSTATUS nuget nullopt @@ -1366,7 +1380,6 @@ oldnewthing oldpath oldtheme oleaut -OleAut OLECHAR OLEDB OLIVEGREEN @@ -1392,6 +1405,7 @@ OUTOFCONTEXT OUTOFMEMORY Outptr outro +outsettings OVERLAPPEDWINDOW overlaywindow OWNDC @@ -1632,7 +1646,6 @@ rexit rfind rgb RGBQUAD -rge rgelt Rgn rgs @@ -1671,6 +1684,7 @@ runtimeclass runtimeconfig runtimes rv +RUS rvalue rvm rwin @@ -1752,6 +1766,7 @@ SHORTCUTSTARTWITHMODIFIER Shortcuttool shortdate SHORTPATH +showcolorname SHOWDEFAULT SHOWELEVATIONPROMPT SHOWMAXIMIZED @@ -1786,7 +1801,7 @@ SLGP sln SMALLICON SMTO -Snd +snd somil SORTDOWN SOURCECLIENTAREAONLY @@ -1882,6 +1897,7 @@ svgpreviewhandler Switchbetweenvirtualdesktops SWP swprintf +SWRESTORE SYMED SYMOPT SYNCPAINT @@ -1956,6 +1972,7 @@ TNP todo toggleswitch toolbar +Toolchain toolset tooltip toolwindow @@ -2084,11 +2101,13 @@ VIDEOINFOHEADER viewbox viewmodel virtualization +visiblecolorformats Visibletrue visualbrush visualstudio vk VKey +VKTAB vm vmax vmin @@ -2125,6 +2144,7 @@ wcsncmp wcsnicmp wdp wdupenv +We'd weakme webcam webclient @@ -2219,7 +2239,6 @@ wsz wtoi WTS WTSAT -wu Wwan www wxs @@ -2228,6 +2247,7 @@ xamarin xaml XAttribute xbf +XBind XBUTTON XBUTTONDBLCLK XBUTTONDOWN @@ -2269,7 +2289,6 @@ zh ZIndex zipfolder zm -zom zonable ZONECOLOR ZONEHIGHLIGHTCOLOR diff --git a/.github/workflows/spelling.yml b/.github/workflows/spelling.yml index e1a4335cbb..1b008e2366 100644 --- a/.github/workflows/spelling.yml +++ b/.github/workflows/spelling.yml @@ -2,6 +2,7 @@ name: Spell checking on: pull_request_target: push: + issue_comment: jobs: build: @@ -13,12 +14,9 @@ jobs: uses: actions/checkout@v2.0.0 with: ref: refs/pull/${{github.event.pull_request.number}}/merge - fetch-depth: 5 - name: checkout if: "!contains(github.event_name, 'pull_request')" uses: actions/checkout@v2.0.0 - with: - fetch-depth: 5 - - uses: check-spelling/check-spelling@0.0.17-alpha + - uses: check-spelling/check-spelling@v0.0.18 with: config: .github/actions/spell-check diff --git a/src/settings-ui/Microsoft.PowerToys.Settings.UI.Library/SndModuleSettings`1.cs b/src/settings-ui/Microsoft.PowerToys.Settings.UI.Library/SndModuleSettings`1.cs index 463ec535ad..f8069791f3 100644 --- a/src/settings-ui/Microsoft.PowerToys.Settings.UI.Library/SndModuleSettings`1.cs +++ b/src/settings-ui/Microsoft.PowerToys.Settings.UI.Library/SndModuleSettings`1.cs @@ -7,7 +7,7 @@ using System.Text.Json.Serialization; namespace Microsoft.PowerToys.Settings.UI.Library { - // Represents a powertoys module settings setnt to the runner. + // Represents a powertoys module settings sent to the runner. public class SndModuleSettings { [JsonPropertyName("powertoys")]