From e8afe02adfa6c03b32cf026ce32b76d6f0bae1b2 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 5 Feb 2026 15:23:47 +0000 Subject: [PATCH] Code review: Update null check to modern C++ convention - Use modern convention (extension == nullptr) for better readability - Add clarifying comment about lowercase requirement in extension list Co-authored-by: yeelam-gordon <73506701+yeelam-gordon@users.noreply.github.com> --- .../imageresizer/ImageResizerLib/ImageResizerConstants.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/modules/imageresizer/ImageResizerLib/ImageResizerConstants.h b/src/modules/imageresizer/ImageResizerLib/ImageResizerConstants.h index ea3183410f..a8db6ed516 100644 --- a/src/modules/imageresizer/ImageResizerLib/ImageResizerConstants.h +++ b/src/modules/imageresizer/ImageResizerLib/ImageResizerConstants.h @@ -15,6 +15,7 @@ namespace ImageResizerConstants // List of supported image extensions that Image Resizer can process // This must match the list in RuntimeRegistration.h + // Note: All extensions must be in lowercase for case-insensitive comparison inline const std::vector SupportedImageExtensions = { L".bmp", L".dib", L".gif", L".jfif", L".jpe", L".jpeg", L".jpg", L".jxr", L".png", L".rle", L".tif", L".tiff", L".wdp" @@ -23,7 +24,7 @@ namespace ImageResizerConstants // Helper function to check if a file extension is supported by Image Resizer inline bool IsSupportedImageExtension(LPCWSTR extension) { - if (nullptr == extension || wcslen(extension) == 0) + if (extension == nullptr || wcslen(extension) == 0) { return false; }