[PT Run] VirtualDesktopHelper & WindowWalker improvements (#16325)

* Import vdh from poc * last changes * push changes * small change * add error handling to vdh * last changes * make spellchecker happy * last changes * last changes * spell check * fix settings defaults * Improve WindowWalkerSettings class * add comment * New settings and improvements * new features * subtitle and tool tip * spell fixes * small fixes * fixes * Explorer info * spell fixes * fixes and CloseWindow feature * last changes * first part of implementing KillProcess * killProcess Part 2 & Fixes * text fix and installer * update access modifiers * some fixes * update dev docs * fix dev docs * dev doc change * dev docs: add missed infos * dev docs: add link * Update src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Components/WindowWalkerSettings.cs * fix build * resolve feedback * fix settings * add tests
2026-04-05 02:36:19 +02:00 · 2022-03-07 12:45:29 +01:00
parent 27611593bd
commit e8363a3be1
33 changed files with 1764 additions and 103 deletions
--- a/src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Components/ContextMenuHelper.cs
+++ b/src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Components/ContextMenuHelper.cs
@@ -0,0 +1,116 @@
+// Copyright (c) Microsoft Corporation
+// The Microsoft Corporation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+using System;
+using System.Collections.Generic;
+using System.Windows;
+using System.Windows.Input;
+using Microsoft.Plugin.WindowWalker.Properties;
+using Wox.Plugin;
+using Wox.Plugin.Logger;
+
+namespace Microsoft.Plugin.WindowWalker.Components
+{
+    internal class ContextMenuHelper
+    {
+        /// <summary>
+        /// Returns a list of all <see cref="ContextMenuResult"/>s for the selected <see cref="Result"/>.
+        /// </summary>
+        /// <param name="result">Selected result</param>
+        /// <returns>List of context menu results</returns>
+        internal static List<ContextMenuResult> GetContextMenuResults(in Result result)
+        {
+            if (!(result?.ContextData is Window windowData))
+            {
+                return new List<ContextMenuResult>(0);
+            }
+
+            var contextMenu = new List<ContextMenuResult>()
+            {
+                new ContextMenuResult
+                {
+                    AcceleratorKey = Key.F4,
+                    AcceleratorModifiers = ModifierKeys.Control,
+                    FontFamily = "Segoe MDL2 Assets",
+                    Glyph = "\xE8BB",                       // E8B8 => Symbol: ChromeClose
+                    Title = $"{Resources.wox_plugin_windowwalker_Close} (Ctrl+F4)",
+                    Action = _ =>
+                    {
+                        if (!windowData.IsWindow)
+                        {
+                            Log.Debug($"Can not close the window '{windowData.Title}' ({windowData.Hwnd}), because it doesn't exist.", typeof(ContextMenuHelper));
+                            return false;
+                        }
+
+                        // As a workaround to close PT Run after executing the context menu command, we switch to the window before closing it (Issue #16601).
+                        // We use the setting OpenAfterKillAndClose to detect if we have to switch.
+                        windowData.CloseThisWindow(!WindowWalkerSettings.Instance.OpenAfterKillAndClose);
+
+                        return !WindowWalkerSettings.Instance.OpenAfterKillAndClose;
+                    },
+                },
+            };
+
+            // Hide menu if Explorer.exe is the shell process or the process name is ApplicationFrameHost.exe
+            // In the first case we would crash the windows ui and in the second case we would kill the generic process for uwp apps.
+            if (!windowData.Process.IsShellProcess && !(windowData.Process.IsUwpApp & windowData.Process.Name.ToLower() == "applicationframehost.exe")
+                && !(windowData.Process.IsFullAccessDenied & WindowWalkerSettings.Instance.HideKillProcessOnElevatedProcesses))
+            {
+                contextMenu.Add(new ContextMenuResult
+                {
+                    AcceleratorKey = Key.Delete,
+                    AcceleratorModifiers = ModifierKeys.Control,
+                    FontFamily = "Segoe MDL2 Assets",
+                    Glyph = "\xE74D",                       // E74D => Symbol: Delete
+                    Title = $"{Resources.wox_plugin_windowwalker_Kill} (Ctrl+Delete)",
+                    Action = _ => KillProcessCommand(windowData),
+                });
+            }
+
+            return contextMenu;
+        }
+
+        /// <summary>
+        /// Method to initiate killing the process of a window
+        /// </summary>
+        /// <param name="window">Window data</param>
+        /// <returns>True if the PT Run window should close, otherwise false.</returns>
+        private static bool KillProcessCommand(Window window)
+        {
+            // Validate process
+            if (!window.IsWindow || !window.Process.DoesExist || !window.Process.Name.Equals(WindowProcess.GetProcessNameFromProcessID(window.Process.ProcessID)) )
+            {
+                Log.Debug($"Can not kill process '{window.Process.Name}' ({window.Process.ProcessID}) of the window '{window.Title}' ({window.Hwnd}), because it doesn't exist.", typeof(ContextMenuHelper));
+                return false;
+            }
+
+            // Request user confirmation
+            if (WindowWalkerSettings.Instance.ConfirmKillProcess)
+            {
+                string messageBody = $"{Resources.wox_plugin_windowwalker_KillMessage}\n"
+                    + $"{window.Process.Name} ({window.Process.ProcessID})\n\n"
+                    + $"{(window.Process.IsUwpApp ? Resources.wox_plugin_windowwalker_KillMessageUwp : Resources.wox_plugin_windowwalker_KillMessageQuestion)}";
+                MessageBoxResult messageBoxResult = MessageBox.Show(
+                    messageBody,
+                    Resources.wox_plugin_windowwalker_plugin_name + " - " + Resources.wox_plugin_windowwalker_KillMessageTitle,
+                    MessageBoxButton.YesNo,
+                    MessageBoxImage.Warning);
+
+                if (messageBoxResult == MessageBoxResult.No)
+                {
+                    return false;
+                }
+            }
+
+            // As a workaround to close PT Run before executing the command, we switch to the window before killing it's process
+            if (!WindowWalkerSettings.Instance.OpenAfterKillAndClose)
+            {
+                window.SwitchToWindow();
+            }
+
+            // Kill process
+            window.Process.KillThisProcess(WindowWalkerSettings.Instance.KillProcessTree);
+            return !WindowWalkerSettings.Instance.OpenAfterKillAndClose;
+        }
+    }
+}