From e323da939bc2dc3ee585eafaaaa022e42b400ddc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ji=C5=99=C3=AD=20Pol=C3=A1=C5=A1ek?= Date: Mon, 9 Mar 2026 11:48:49 +0100 Subject: [PATCH] CmdPal: Don't be smart and stop passing a string file path with a file drop (#45951) ## Summary of the Pull Request This PR removes the text data format from the data package attached to list items for files, keeping only the file drop-related formats. MS Teams doesn't handle having both formats simultaneously well. :/ ## PR Checklist - [x] Closes: #45950 - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx ## Detailed Description of the Pull Request / Additional comments ## Validation Steps Performed --- .../Microsoft.CmdPal.Ext.Indexer/Helpers/DataPackageHelper.cs | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/Helpers/DataPackageHelper.cs b/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/Helpers/DataPackageHelper.cs index a4e7873189..f98b933062 100644 --- a/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/Helpers/DataPackageHelper.cs +++ b/src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/Helpers/DataPackageHelper.cs @@ -38,9 +38,6 @@ internal static class DataPackageHelper }, }; - // Cheap + immediate. - dataPackage.SetText(capturedPath); - // Expensive + only computed if the consumer asks for StorageItems. dataPackage.SetDataProvider(StandardDataFormats.StorageItems, async void (request) => {