[WindowsSettings Plugin] Improve subtitle and area naming (#12915)

* Update WindowsSettings clas

* Update TranslationHelper

* Adding ToDos to code

* Adding ToDo notes

* Introduce AreaPathHelper

* Small improvement

* Improve helper class

* Update ResultHelper

* Fix spelling

* adding todo marker

* Improve calling of <WindowsSettingsPathHelper>: Update class <WindowsSetting>

* Improve calling of <WindowsSettingsPathHelper>: Update helper class

* Improve calling of <WindowsSettingsPathHelper>: Implement method call

* TranslationHelper: Small fixes

* Fix scoring for areas property

* Fix search filters for area property

* small fixes

* Update WindowsSettings.json

* adding todos

* Code cleanup, improvements and fixes

* Small changes

* Update resource strings

* Fix msitakes

* Update settings

* resolve review feedback
This commit is contained in:
Heiko
2021-09-06 12:46:14 +02:00
committed by GitHub
parent a4f84844bc
commit dcc4563c8c
9 changed files with 415 additions and 329 deletions

View File

@@ -86,6 +86,7 @@ namespace Microsoft.PowerToys.Run.Plugin.WindowsSettings
_settingsList = UnsupportedSettingsHelper.FilterByBuild(_settingsList);
TranslationHelper.TranslateAllSettings(_settingsList);
WindowsSettingsPathHelper.GenerateSettingsPathValues(_settingsList);
}
/// <summary>
@@ -114,16 +115,23 @@ namespace Microsoft.PowerToys.Run.Plugin.WindowsSettings
return true;
}
// Search for Area only by key char
if (found.Area.Contains(query.Search.Replace(":", string.Empty), StringComparison.CurrentCultureIgnoreCase)
&& query.Search.EndsWith(":"))
if (!(found.Areas is null))
{
return true;
}
foreach (var area in found.Areas)
{
// Search for areas on normal queries.
if (area.Contains(query.Search, StringComparison.CurrentCultureIgnoreCase))
{
return true;
}
if (found.Area.Contains(query.Search, StringComparison.CurrentCultureIgnoreCase))
{
return true;
// Search for Area only on queries with action char.
if (area.Contains(query.Search.Replace(":", string.Empty), StringComparison.CurrentCultureIgnoreCase)
&& query.Search.EndsWith(":"))
{
return true;
}
}
}
if (!(found.AltNames is null))